[GHC] #12575: Support US spelling of `specialise` throughout
#12575: Support US spelling of `specialise` throughout -------------------------------------+------------------------------------- Reporter: crockeea | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.0.1 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: Other Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- GHC doesn't accept `-Wmissed-specializations`. Based on the [http://downloads.haskell.org/~ghc/latest/docs/html/users_guide/glasgow_exts.... #specialize-pragma docs], it seems like GHC is trying to support both spellings, so both spellings in the warning should be supported. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12575 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#12575: Support US spelling of `specialise` throughout -------------------------------------+------------------------------------- Reporter: crockeea | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.0.1 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by mpickering): * keywords: => newcomer -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12575#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#12575: Support US spelling of `specialise` throughout -------------------------------------+------------------------------------- Reporter: crockeea | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.0.1 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by tmcgilchrist): I'd like to have a go at fixing this issue. Just so I understand it correctly a fix for this would involve supporting both `specialisation` spelling for that command line argument. I believe I have something working for `-Wmissed-specializations` and `-Wall-missed-specializations`. I couldn't find any specific tests that cover these command line arguments, is there any? As a follow up, I'm not sure if it's required, but there are other flags that appear to have the UK spelling of `specialise` like `specialise- aggressively` and `cross-module-specialise` -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12575#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#12575: Support US spelling of `specialise` throughout -------------------------------------+------------------------------------- Reporter: crockeea | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.0.1 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by tmcgilchrist): * Attachment "0001-Support-US-spelling-for-specialise-flags.patch" added. Initial patch for supporting US spellings of specialise -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12575 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#12575: Support US spelling of `specialise` throughout -------------------------------------+------------------------------------- Reporter: crockeea | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.0.1 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by crockeea): Please fix all flags to support both spellings! -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12575#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#12575: Support US spelling of `specialise` throughout -------------------------------------+------------------------------------- Reporter: crockeea | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.0.1 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by tmcgilchrist): * Attachment "0001-Support-US-spelling-for-specialise-flags.patch" added. Initial patch for supporting US spellings of specialise -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12575 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#12575: Support US spelling of `specialise` throughout -------------------------------------+------------------------------------- Reporter: crockeea | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.0.1 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by mpickering): tmcgilchrist, please you put your patch on phabricator? You can find instructions on the [https://ghc.haskell.org/trac/ghc/wiki/Phabricator wiki]. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12575#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#12575: Support US spelling of `specialise` throughout -------------------------------------+------------------------------------- Reporter: crockeea | Owner: tmcgilchrist Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.0.1 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by tmcgilchrist): * owner: => tmcgilchrist -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12575#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#12575: Support US spelling of `specialise` throughout -------------------------------------+------------------------------------- Reporter: crockeea | Owner: tmcgilchrist Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.0.1 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by tmcgilchrist): Submitted as https://phabricator.haskell.org/D2542 Think I followed the instructions correctly, please let me know if I didn't. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12575#comment:6 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#12575: Support US spelling of `specialise` throughout -------------------------------------+------------------------------------- Reporter: crockeea | Owner: tmcgilchrist Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.0.1 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2542 Wiki Page: | -------------------------------------+------------------------------------- Changes (by mpickering): * differential: => Phab:D2542 Comment: Looks like you did everything right. I left some comments. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12575#comment:7 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#12575: Support US spelling of `specialise` throughout
-------------------------------------+-------------------------------------
Reporter: crockeea | Owner: tmcgilchrist
Type: bug | Status: new
Priority: normal | Milestone:
Component: Compiler | Version: 8.0.1
Resolution: | Keywords: newcomer
Operating System: Unknown/Multiple | Architecture:
| Unknown/Multiple
Type of failure: Other | Test Case:
Blocked By: | Blocking:
Related Tickets: | Differential Rev(s): Phab:D2542
Wiki Page: |
-------------------------------------+-------------------------------------
Comment (by Ben Gamari
#12575: Support US spelling of `specialise` throughout -------------------------------------+------------------------------------- Reporter: crockeea | Owner: tmcgilchrist Type: bug | Status: closed Priority: normal | Milestone: 8.2.1 Component: Compiler | Version: 8.0.1 Resolution: fixed | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2542 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => closed * resolution: => fixed * milestone: => 8.2.1 Comment: Thanks Tim! -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12575#comment:9 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC