[GHC] #13746: Typeable changes in base-4.10 break ChasingBottoms's test suite
#13746: Typeable changes in base-4.10 break ChasingBottoms's test suite -------------------------------------+------------------------------------- Reporter: refold | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: | Version: 8.2.1-rc2 libraries/base | Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: Runtime crash Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- When compiled against base-4.10, `ChasingBottoms`'s test suite fails with: {{{ Approx: ChasingBottomsTestSuite: typeRepTyCon: FunTy CallStack (from HasCallStack): error, called at libraries/base/Data/Typeable/Internal.hs:308:33 in base:Data.Typeable.Internal }}} This is due to the use of `error` in the following function in [https://github.com/ghc/ghc/blob/master/libraries/base/Data/Typeable/Internal... `Data.Typeable.Internal`]: {{{#!hs -- | Observe the type constructor of a type representation typeRepTyCon :: TypeRep a -> TyCon typeRepTyCon (TrTyCon _ tc _) = tc typeRepTyCon (TrApp _ a _) = typeRepTyCon a typeRepTyCon (TrFun _ _ _) = error "typeRepTyCon: FunTy" -- TODO }}} `ChasingBottoms`'s test suite works fine when compiled with GHC 8.0.2. It seems to me that the change in behaviour constitutes a bug or a breaking change (for which there is no mention in the changelog). -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13746 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#13746: Typeable changes in base-4.10 break ChasingBottoms's test suite -------------------------------------+------------------------------------- Reporter: refold | Owner: (none) Type: bug | Status: patch Priority: normal | Milestone: Component: libraries/base | Version: 8.2.1-rc2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Runtime crash | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3605 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => patch * differential: => Phab:D3605 Comment: Oh dear, how embarrassing! Thanks for the report. Patch in Phab:D3605. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13746#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#13746: Typeable changes in base-4.10 break ChasingBottoms's test suite
-------------------------------------+-------------------------------------
Reporter: refold | Owner: (none)
Type: bug | Status: patch
Priority: normal | Milestone:
Component: libraries/base | Version: 8.2.1-rc2
Resolution: | Keywords:
Operating System: Unknown/Multiple | Architecture:
| Unknown/Multiple
Type of failure: Runtime crash | Test Case:
Blocked By: | Blocking:
Related Tickets: | Differential Rev(s): Phab:D3605
Wiki Page: |
-------------------------------------+-------------------------------------
Comment (by Ben Gamari
#13746: Typeable changes in base-4.10 break ChasingBottoms's test suite -------------------------------------+------------------------------------- Reporter: refold | Owner: (none) Type: bug | Status: closed Priority: normal | Milestone: Component: libraries/base | Version: 8.2.1-rc2 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Runtime crash | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3605 Wiki Page: | -------------------------------------+------------------------------------- Changes (by RyanGlScott): * status: patch => closed * resolution: => fixed Comment: This was merged into GHC 8.2.1 in commit 979cc34b03909939c007e7b719687362dbfdf153. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13746#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC