[GHC] #12992: Language.Haskell.TH doesn't reexport everything from Language.Haskell.TH.Lib
#12992: Language.Haskell.TH doesn't reexport everything from Language.Haskell.TH.Lib -------------------------------------+------------------------------------- Reporter: RyanGlScott | Owner: RyanGlScott Type: bug | Status: new Priority: normal | Milestone: 8.2.1 Component: Template | Version: 8.0.1 Haskell | Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: Other Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- The documentation for `Language.Haskell.TH.Lib` [http://git.haskell.org/ghc.git/blob/9e862765ffe161da8a4fd9cd67b0a600874feaa9... /template-haskell/Language/Haskell/TH/Lib.hs#l8 claims]: {{{#!hs -- All of the exports from this module should -- be "public" functions. The main module TH -- re-exports them all. }}} Sadly, this isn't true. There are a number of functions that `Language.Haskell.TH` accidentally forgets to export. Notably, this includes all of the unboxed tuple library functions, as noticed [https://phabricator.haskell.org/D2448#inline-20282 here], but there are many others as well. To avoid this sort of thing in the future, I think the cleanest solution would be to just reexport the entirely of the `Language.Haskell.TH.Lib` module from `Language.Haskell.TH`. This would have the downside that you'll have to click an extra link in order to see the Haddocks for `Language.Haskell.TH.Lib`, but I believe the simplification will be worth it. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12992> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12992: Language.Haskell.TH doesn't reexport everything from Language.Haskell.TH.Lib -------------------------------------+------------------------------------- Reporter: RyanGlScott | Owner: RyanGlScott Type: bug | Status: patch Priority: normal | Milestone: 8.2.1 Component: Template Haskell | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2867 Wiki Page: | -------------------------------------+------------------------------------- Changes (by RyanGlScott): * status: new => patch * differential: => Phab:D2867 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12992#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12992: Language.Haskell.TH doesn't reexport everything from Language.Haskell.TH.Lib -------------------------------------+------------------------------------- Reporter: RyanGlScott | Owner: RyanGlScott Type: bug | Status: patch Priority: normal | Milestone: 8.2.1 Component: Template Haskell | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2867 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"343b1473fa3ad1f90e4f9708dbc4d8127382dc36/ghc" 343b1473/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="343b1473fa3ad1f90e4f9708dbc4d8127382dc36" Reexport Language.Haskell.TH.Lib from Language.Haskell.TH Reexporting `Language.Haskell.TH.Lib` from `Language.Haskell.TH` ensures that `Language.Haskell.TH` will continue to expose all of the functions that `Language.Haskell.TH.Lib` does in the future. Fixes #12992. Test Plan: ./validate Reviewers: austin, bgamari, goldfire Reviewed By: bgamari, goldfire Subscribers: thomie Differential Revision: https://phabricator.haskell.org/D2867 GHC Trac Issues: #12992 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12992#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12992: Language.Haskell.TH doesn't reexport everything from Language.Haskell.TH.Lib -------------------------------------+------------------------------------- Reporter: RyanGlScott | Owner: RyanGlScott Type: bug | Status: closed Priority: normal | Milestone: 8.2.1 Component: Template Haskell | Version: 8.0.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2867 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: patch => closed * resolution: => fixed -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12992#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC