[GHC] #10490: Missing binder type check in coercion equality test?
#10490: Missing binder type check in coercion equality test? -------------------------------------+------------------------------------- Reporter: ezyang | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.11 (Type checker) | Operating System: Unknown/Multiple Keywords: | Type of failure: None/Unknown Architecture: | Blocked By: Unknown/Multiple | Related Tickets: Test Case: | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- I was reading the equality testing code for coercions and I noticed this line: {{{ coreEqCoercion2 env (ForAllCo v1 co1) (ForAllCo v2 co2) = coreEqCoercion2 (rnBndr2 env v1 v2) co1 co2 }}} This doesn't test if the types of the binders are equal. Should it? (Or is the type always trivially the same?) -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10490 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#10490: Missing binder type check in coercion equality test? -------------------------------------+------------------------------------- Reporter: ezyang | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler (Type | Version: 7.11 checker) | Keywords: Resolution: | Architecture: Operating System: Unknown/Multiple | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: -------------------------------------+------------------------------------- Changes (by simonpj): * cc: goldfire (added) Comment: That does look wrong, well caught. Richard, you agree? Edward, could you fix? -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10490#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#10490: Missing binder type check in coercion equality test? -------------------------------------+------------------------------------- Reporter: ezyang | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler (Type | Version: 7.11 checker) | Keywords: Resolution: | Architecture: Operating System: Unknown/Multiple | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by goldfire): Yes it's a bug. But do what you like here. I think you'll have a very hard time tickling this bug, and this code is all going away once kind equalities hits (later this summer, really!). -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10490#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#10490: Missing binder type check in coercion equality test? -------------------------------------+------------------------------------- Reporter: ezyang | Owner: (none) Type: bug | Status: closed Priority: normal | Milestone: Component: Compiler (Type | Version: 7.11 checker) | Resolution: invalid | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by RyanGlScott): * status: new => closed * resolution: => invalid Comment: As of 6746549772c5cc0ac66c0fce562f297f4d4b80a2, `coreEqCoercion2` is no more, so this issue is moot. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10490#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC