[GHC] #11756: Data.Functor.Classes instances for Proxy
#11756: Data.Functor.Classes instances for Proxy -------------------------------------+------------------------------------- Reporter: andrewthad | Owner: Type: feature | Status: new request | Priority: normal | Milestone: Component: Compiler | Version: 8.0.1-rc2 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- It looks like Proxy is missing instances for Eq1, Ord1, Show1, and Read1. These are all completely trivial. Can I add them? -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11756 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11756: Data.Functor.Classes instances for Proxy -------------------------------------+------------------------------------- Reporter: andrewthad | Owner: Type: feature request | Status: new Priority: normal | Milestone: 8.0.1 Component: Core Libraries | Version: 8.0.1-rc2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * cc: RyanGlScott, ekmett (added) * component: Compiler => Core Libraries * milestone: => 8.0.1 @@ -1,2 +1,2 @@ - It looks like Proxy is missing instances for Eq1, Ord1, Show1, and Read1. - These are all completely trivial. Can I add them? + It looks like `Proxy` is missing instances for `Eq1`, `Ord1`, `Show1`, and + `Read1`. These are all completely trivial. Can I add them? New description: It looks like `Proxy` is missing instances for `Eq1`, `Ord1`, `Show1`, and `Read1`. These are all completely trivial. Can I add them? -- Comment: Sure, feel free to submit a patch. Cc'ing RyanGlScott who has thought more about the implications of these instances. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11756#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11756: Data.Functor.Classes instances for Proxy -------------------------------------+------------------------------------- Reporter: andrewthad | Owner: Type: feature request | Status: new Priority: normal | Milestone: 8.0.1 Component: Core Libraries | Version: 8.0.1-rc2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by RyanGlScott): By all means, start adding instances if you need them. As I noted [https://ghc.haskell.org/trac/ghc/ticket/11135#comment:25 here], I plan to eventually create a language extension for deriving `Eq1` and friends, which will make adding these kinds of instances much less painful in the future. But we don't derive `Eq`, `Ord`, etc. for `Proxy` anyway to make the instances sufficiently lazy, so we should provide similar treatment for `Eq1`, `Ord1`, etc. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11756#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11756: Data.Functor.Classes instances for Proxy -------------------------------------+------------------------------------- Reporter: andrewthad | Owner: Type: feature request | Status: new Priority: normal | Milestone: 8.0.1 Component: Core Libraries | Version: 8.0.1-rc2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by andrewthad): I've added a differential for this on phabricator: https://phabricator.haskell.org/D2051 It's my first time using phabricator and arcanist, so I probably did something wrong. Feel free to point out any conventions that I missed. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11756#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11756: Data.Functor.Classes instances for Proxy -------------------------------------+------------------------------------- Reporter: andrewthad | Owner: Type: feature request | Status: patch Priority: normal | Milestone: 8.0.1 Component: Core Libraries | Version: 8.0.1-rc2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2051 Wiki Page: | -------------------------------------+------------------------------------- Changes (by RyanGlScott): * status: new => patch * differential: => Phab:D2051 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11756#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11756: Data.Functor.Classes instances for Proxy
-------------------------------------+-------------------------------------
Reporter: andrewthad | Owner:
Type: feature request | Status: patch
Priority: normal | Milestone: 8.0.1
Component: Core Libraries | Version: 8.0.1-rc2
Resolution: | Keywords:
Operating System: Unknown/Multiple | Architecture:
| Unknown/Multiple
Type of failure: None/Unknown | Test Case:
Blocked By: | Blocking:
Related Tickets: | Differential Rev(s): Phab:D2051
Wiki Page: |
-------------------------------------+-------------------------------------
Comment (by Ben Gamari
#11756: Data.Functor.Classes instances for Proxy -------------------------------------+------------------------------------- Reporter: andrewthad | Owner: Type: feature request | Status: closed Priority: normal | Milestone: 8.0.1 Component: Core Libraries | Version: 8.0.1-rc2 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2051 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: patch => closed * resolution: => fixed Comment: Merged to `ghc-8.0` as dc81cca703559ffd4acb0a2f47c2f20956c22a3a. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11756#comment:6 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC