[GHC] #13356: gmp/ghc.mk's use of TARGETPLATFORM and BUILDPLATFORM is wrong

#13356: gmp/ghc.mk's use of TARGETPLATFORM and BUILDPLATFORM is wrong -------------------------------------+------------------------------------- Reporter: rwbarton | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: Build System | Version: 8.1 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: Building GHC Unknown/Multiple | failed Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- `libraries/integer-gmp/gmp/ghc.mk` invokes `libgmp`'s configure script with the options {{{ --host=$(TARGETPLATFORM) --build=$(BUILDPLATFORM) }}} Using `TARGETPLATFORM` is wrong, as it is the GHC-munged target triple. For example if the triple passed to the top-level configure script was `--target=aarch64-apple-darwin14` (for iPhone), `TARGETPLATFORM` will be `aarch64-apple-ios`, which `configure` does not understand. Instead of `TARGETPLATFORM` we should use `TargetPlatformFull`. I don't think we have a corresponding variable for `BUILDPLATFORM`, so we should add one if it's important. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13356 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#13356: gmp/ghc.mk's use of TARGETPLATFORM and BUILDPLATFORM is wrong -------------------------------------+------------------------------------- Reporter: rwbarton | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: Build System | Version: 8.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Building GHC | Unknown/Multiple failed | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by nicolast): * cc: nicolast (added) Comment: Interesting, I wasn't aware those variables don't correspond to what Autoconf handles when landing the related change (https://phabricator.haskell.org/D1960) Somewhat related: looking for `TargetPlatformAll` in the GHC tree, I noticed {{{ rules/build-package-data.mk:$1_$2_CONFIGURE_OPTS += --configure- option=--host=$(TargetPlatformFull) }}} which seems a bit odd. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13356#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC