[GHC] #11530: Make fails on systems with GREP_OPTIONS
#11530: Make fails on systems with GREP_OPTIONS ----------------------------------------+--------------------------------- Reporter: alexlegg | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Build System | Version: 7.10.3 Keywords: | Operating System: POSIX Architecture: Unknown/Multiple | Type of failure: None/Unknown Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: ----------------------------------------+--------------------------------- In rules/manual-package-config.mk the following use of grep will cause later errors if -n (prepending line numbers) is set in GREP_OPTIONS. {{{ grep -v '^#pragma GCC' $$@.raw | \ sed -e 's/""//g' -e 's/:[ ]*,/: /g' >$$@ }}} It causes parsing issues later, with errors like: {{{ : Warning: Unrecognized field 420 on line 420 : Warning: Unrecognized field 419 on line 419 ... : Warning: Unrecognized field 1 on line 1 : missing id field : invalid package identifier: : invalid package key: }}} It may be worth adding an `export GREP_OPTIONS=` somewhere in the make file as it's reasonably difficult to figure out the actual problem from the error message. I would do this and submit a patch but I'm not sure if it is desired since GREP_OPTIONS is now deprecated. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11530> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11530: Make fails on systems with GREP_OPTIONS ---------------------------------+---------------------------------------- Reporter: alexlegg | Owner: Type: bug | Status: patch Priority: normal | Milestone: Component: Build System | Version: 7.10.3 Resolution: | Keywords: Operating System: POSIX | Architecture: Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1886 Wiki Page: | ---------------------------------+---------------------------------------- Changes (by bgamari): * status: new => patch * differential: => Phab:D1886 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11530#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11530: Make fails on systems with GREP_OPTIONS ---------------------------------+---------------------------------------- Reporter: alexlegg | Owner: Type: bug | Status: patch Priority: normal | Milestone: Component: Build System | Version: 7.10.3 Resolution: | Keywords: Operating System: POSIX | Architecture: Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1887 Wiki Page: | ---------------------------------+---------------------------------------- Changes (by thomie): * differential: Phab:D1886 => Phab:D1887 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11530#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11530: Make fails on systems with GREP_OPTIONS ---------------------------------+---------------------------------------- Reporter: alexlegg | Owner: Type: bug | Status: patch Priority: normal | Milestone: Component: Build System | Version: 7.10.3 Resolution: | Keywords: Operating System: POSIX | Architecture: Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1887 Wiki Page: | ---------------------------------+---------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"bfec4a6aade005b6dbd170645d4f2d062cee1d92/ghc" bfec4a6/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="bfec4a6aade005b6dbd170645d4f2d062cee1d92" Unset GREP_OPTIONS in build system Test Plan: GREP_OPTIONS=--blah ./validate Reviewers: austin, thomie Reviewed By: thomie Differential Revision: https://phabricator.haskell.org/D1887 GHC Trac Issues: #11530 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11530#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11530: Make fails on systems with GREP_OPTIONS ---------------------------------+---------------------------------------- Reporter: alexlegg | Owner: Type: bug | Status: merge Priority: normal | Milestone: Component: Build System | Version: 7.10.3 Resolution: | Keywords: Operating System: POSIX | Architecture: Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1887 Wiki Page: | ---------------------------------+---------------------------------------- Changes (by bgamari): * status: patch => merge -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11530#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11530: Make fails on systems with GREP_OPTIONS ---------------------------------+---------------------------------------- Reporter: alexlegg | Owner: Type: bug | Status: merge Priority: normal | Milestone: 8.0.1 Component: Build System | Version: 7.10.3 Resolution: | Keywords: Operating System: POSIX | Architecture: Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1887 Wiki Page: | ---------------------------------+---------------------------------------- Changes (by bgamari): * milestone: => 8.0.1 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11530#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11530: Make fails on systems with GREP_OPTIONS -------------------------------------+------------------------------------- Reporter: alexlegg | Owner: Type: bug | Status: merge Priority: normal | Milestone: 8.0.1 Component: Build System | Version: 7.10.3 Resolution: | Keywords: Operating System: POSIX | Architecture: Type of failure: Building GHC | Unknown/Multiple failed | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1887 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * failure: None/Unknown => Building GHC failed -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11530#comment:6> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11530: Make fails on systems with GREP_OPTIONS -------------------------------------+------------------------------------- Reporter: alexlegg | Owner: Type: bug | Status: closed Priority: normal | Milestone: 8.0.1 Component: Build System | Version: 7.10.3 Resolution: fixed | Keywords: Operating System: POSIX | Architecture: Type of failure: Building GHC | Unknown/Multiple failed | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1887 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: merge => closed * resolution: => fixed Comment: Merged in ac0732ff36280b99f53a30ee6ecf0ce2e5eee60a. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11530#comment:7> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC