[GHC] #12771: GHCi incorrectly favors static libraries over import libraries
#12771: GHCi incorrectly favors static libraries over import libraries ----------------------------------------+---------------------------- Reporter: Phyx- | Owner: Type: bug | Status: new Priority: normal | Milestone: 8.2.1 Component: Compiler | Version: 8.0.1 Keywords: | Operating System: Windows Architecture: Unknown/Multiple | Type of failure: Other Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: ----------------------------------------+---------------------------- Given a static library and an import library in the same folder. e.g. {{{ libfoo.a libfoo.dll.a }}} running `ghci -lfoo` we should prefer the import library `libfoo.dll.a` over `libfoo.a` because we prefer having to just load the DLL. and not having to do any linking. This also more closely emulated the behaviour of LD, which has a search order of {{{ libxxx.dll.a xxx.dll.a libxxx.a cygxxx.dll (*) libxxx.dll xxx.dll }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12771> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12771: GHCi incorrectly favors static libraries over import libraries -----------------------------+---------------------------------------- Reporter: Phyx- | Owner: Phyx- Type: bug | Status: new Priority: normal | Milestone: 8.2.1 Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Windows | Architecture: Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2651 Wiki Page: | -----------------------------+---------------------------------------- Changes (by Phyx-): * owner: => Phyx- * differential: => Phab:D2651 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12771#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12771: GHCi incorrectly favors static libraries over import libraries -----------------------------+---------------------------------------- Reporter: Phyx- | Owner: Phyx- Type: bug | Status: patch Priority: normal | Milestone: 8.2.1 Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Windows | Architecture: Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2651 Wiki Page: | -----------------------------+---------------------------------------- Changes (by Phyx-): * status: new => patch -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12771#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12771: GHCi incorrectly favors static libraries over import libraries -----------------------------+---------------------------------------- Reporter: Phyx- | Owner: Phyx- Type: bug | Status: patch Priority: normal | Milestone: 8.2.1 Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Windows | Architecture: Unknown/Multiple Type of failure: Other | Test Case: T12771 Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2651 Wiki Page: | -----------------------------+---------------------------------------- Changes (by Phyx-): * testcase: => T12771 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12771#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12771: GHCi incorrectly favors static libraries over import libraries -----------------------------+---------------------------------------- Reporter: Phyx- | Owner: Phyx- Type: bug | Status: patch Priority: normal | Milestone: 8.2.1 Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Windows | Architecture: Unknown/Multiple Type of failure: Other | Test Case: T12771 Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2651 Wiki Page: | -----------------------------+---------------------------------------- Comment (by Tamar Christina <tamar@…>): In [changeset:"795be0ea60fc81aefdaf6ecb1dc9b03c4a5c9f86/ghc" 795be0e/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="795be0ea60fc81aefdaf6ecb1dc9b03c4a5c9f86" Align GHCi's library search order more closely with LDs Summary: Given a static library and an import library in the same folder. e.g. ``` libfoo.a libfoo.dll.a ``` running `ghci -lfoo` we should prefer the import library `libfoo.dll.a` over `libfoo.a` because we prefer having to just load the DLL. And not having to do any linking. This also more closely emulated the behaviour of LD, which has a search order of ``` libxxx.dll.a xxx.dll.a libxxx.a cygxxx.dll (*) libxxx.dll xxx.dll ``` Test Plan: ./validate Reviewers: RyanGlScott, austin, hvr, bgamari, erikd, simonmar Reviewed By: RyanGlScott Subscribers: thomie, #ghc_windows_task_force Differential Revision: https://phabricator.haskell.org/D2651 GHC Trac Issues: #12771 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12771#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12771: GHCi incorrectly favors static libraries over import libraries -----------------------------+---------------------------------------- Reporter: Phyx- | Owner: Phyx- Type: bug | Status: merge Priority: normal | Milestone: 8.0.2 Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Windows | Architecture: Unknown/Multiple Type of failure: Other | Test Case: T12771 Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2651 Wiki Page: | -----------------------------+---------------------------------------- Changes (by Phyx-): * status: patch => merge * milestone: 8.2.1 => 8.0.2 Comment: Small patch that re-orders import lib searching. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12771#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12771: GHCi incorrectly favors static libraries over import libraries -----------------------------+---------------------------------------- Reporter: Phyx- | Owner: Phyx- Type: bug | Status: closed Priority: normal | Milestone: 8.0.2 Component: Compiler | Version: 8.0.1 Resolution: fixed | Keywords: Operating System: Windows | Architecture: Unknown/Multiple Type of failure: Other | Test Case: T12771 Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2651 Wiki Page: | -----------------------------+---------------------------------------- Changes (by bgamari): * status: merge => closed * resolution: => fixed Comment: Merged to `ghc-8.0` as 95b6affcf2c03495d6635c80bfa3c8636f684363. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12771#comment:6> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC