[GHC] #9604: Python test runner assumes native Python on Windows
#9604: Python test runner assumes native Python on Windows -------------------------------------+------------------------------------- Reporter: gintas | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Build System | Version: 7.8.2 Keywords: | Operating System: Windows Architecture: Unknown/Multiple | Type of failure: Building Difficulty: Unknown | GHC failed Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- runtests.py assumes that ctypes.windll is always available when running on Windows, but that is in fact only available when using a native Windows Python, but not the mingw/msys Python. The code causes a crash over a trivial issue of setting the terminal to UTF-8 mode. See attached patch for a fix. (The second patch is a cleanup.) -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9604> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9604: Python test runner assumes native Python on Windows -------------------------------------+------------------------------------- Reporter: gintas | Owner: Type: bug | Status: patch Priority: normal | Milestone: Component: Build | Version: 7.8.2 System | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: Windows | Difficulty: Unknown Type of failure: Building | Blocked By: GHC failed | Related Tickets: Test Case: | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Changes (by gintas): * status: new => patch -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9604#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9604: Python test runner assumes native Python on Windows -------------------------------------+------------------------------------- Reporter: gintas | Owner: Type: bug | Status: patch Priority: normal | Milestone: Component: Build | Version: 7.8.2 System | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: Windows | Difficulty: Unknown Type of failure: Building | Blocked By: GHC failed | Related Tickets: Test Case: | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Comment (by hvr): The first patch has landed via 1032554a7084a12d38a08beaaeb7a07088883e29 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9604#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9604: Python test runner assumes native Python on Windows -------------------------------------+------------------------------------- Reporter: gintas | Owner: Type: bug | Status: patch Priority: normal | Milestone: Component: Build | Version: 7.8.2 System | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: Windows | Difficulty: Unknown Type of failure: Building | Blocked By: GHC failed | Related Tickets: Test Case: | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Comment (by Herbert Valerio Riedel <hvr@…>): In [changeset:"034b2035d6099c8a253bb1fbd1864001a27b44d6/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="034b2035d6099c8a253bb1fbd1864001a27b44d6" Extend windows detection in testsuite to recognize MSYS target Currently, the detection recognizes the following `uname -s` strings: - `CYGWIN_NT-6.3` - `MINGW32_NT-6.3` - `MINGW64_NT_6.3` However, MSYS2 provides an additional target, in which case `uname -s` returns a string such as `MSYS_NT-6.3`. In all these cases, the system ought to be recognized as being a `windows` os by the testsuite runner. See also #9604 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9604#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9604: Python test runner assumes native Python on Windows -------------------------------------+------------------------------------- Reporter: gintas | Owner: Type: bug | Status: closed Priority: normal | Milestone: 7.10.1 Component: Build | Version: 7.8.2 System | Keywords: Resolution: fixed | Architecture: Unknown/Multiple Operating System: Windows | Difficulty: Unknown Type of failure: Building | Blocked By: GHC failed | Related Tickets: Test Case: | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Changes (by hvr): * status: patch => closed * resolution: => fixed * milestone: => 7.10.1 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9604#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC