[GHC] #11119: WERROR in build.mk doesn't work
#11119: WERROR in build.mk doesn't work -------------------------------------+------------------------------------- Reporter: goldfire | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Build System | Version: 7.11 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- There is a line in `build.mk.sample` that suggests setting `WERROR=-Werror` will turn warnings into errors. This used to work. But now it doesn't, as confirmed by examining the command using `V=1`. I believe the change happened in the last 2-3 weeks. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11119 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11119: WERROR in build.mk doesn't work -------------------------------------+------------------------------------- Reporter: goldfire | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Build System | Version: 7.11 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by thomie): I think you are experiencing the change from 31bcf9b62ceaed98bdd3b7605e68d315bcff0c8a: "Apply WERROR only to stage2 HC options". You can add the following to your mk/build.mk file (below everything else) to get the old behaviour back: {{{ GhcStage1HcOpts += -Werror }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11119#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11119: WERROR in build.mk doesn't work -------------------------------------+------------------------------------- Reporter: goldfire | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Build System | Version: 7.11 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by goldfire): Yes -- that sounds right. I'm fine with the new behavior, but it should be documented in build.mk.sample. Thanks for the clarification. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11119#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11119: WERROR in build.mk doesn't work -------------------------------------+------------------------------------- Reporter: goldfire | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Build System | Version: 7.11 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by bgamari): Fair point; I should have left a note about this. I've added one in 02c689cd1ce2a55adf6318eb9bd69f227f1abda2. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11119#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11119: WERROR in build.mk doesn't work -------------------------------------+------------------------------------- Reporter: goldfire | Owner: Type: bug | Status: closed Priority: normal | Milestone: Component: Build System | Version: 7.11 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => closed * resolution: => fixed -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11119#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC