[GHC] #15924: Do not save performance test results if work tree is dirty
#15924: Do not save performance test results if work tree is dirty -------------------------------------+------------------------------------- Reporter: davide | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: 8.6.3 Component: Test Suite | Version: 8.6.2 Keywords: performance | Operating System: Unknown/Multiple tests git notes | Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: 12758 Differential Rev(s): | Wiki Page: | Performance/Tests -------------------------------------+------------------------------------- The test driver will automatically save performance results to git notes. Notes are attached to commits, but if the working tree is dirty, performance characteristics my be affected and the saved results will not be valid. * Only save performance test results if work tree is dirty. * Bonus: don't save to a git note if we have 0 results. * Update wiki page. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15924 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#15924: Do not save performance test results if work tree is dirty -------------------------------------+------------------------------------- Reporter: davide | Owner: davide Type: bug | Status: new Priority: normal | Milestone: 8.6.3 Component: Test Suite | Version: 8.6.2 Resolution: | Keywords: performance | tests git notes Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: 12758 | Differential Rev(s): Wiki Page: | Performance/Tests | -------------------------------------+------------------------------------- Changes (by davide): * owner: (none) => davide -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15924#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#15924: Do not save performance test results if worktree is dirty -------------------------------------+------------------------------------- Reporter: davide | Owner: davide Type: bug | Status: new Priority: normal | Milestone: 8.6.3 Component: Test Suite | Version: 8.6.2 Resolution: | Keywords: performance | tests git notes Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: 12758 | Differential Rev(s): D5368 Wiki Page: | Performance/Tests | -------------------------------------+------------------------------------- Changes (by davide): * differential: => D5368 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15924#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#15924: Do not save performance test results if worktree is dirty -------------------------------------+------------------------------------- Reporter: davide | Owner: davide Type: bug | Status: new Priority: normal | Milestone: 8.6.3 Component: Test Suite | Version: 8.6.2 Resolution: | Keywords: performance | tests git notes Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: 12758 | Differential Rev(s): D5368 Wiki Page: | Performance/Tests | -------------------------------------+------------------------------------- Comment (by osa1): Are we currently generating these notes in the committer's system? What happens if I commit without running perf tests? What happens if my computer is too slow or fast and generates deviated numbers? -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15924#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#15924: Do not save performance test results if worktree is dirty
-------------------------------------+-------------------------------------
Reporter: davide | Owner: davide
Type: bug | Status: new
Priority: normal | Milestone:
Component: Test Suite | Version: 8.6.2
Resolution: | Keywords: performance
| tests git notes
Operating System: Unknown/Multiple | Architecture:
| Unknown/Multiple
Type of failure: None/Unknown | Test Case:
Blocked By: | Blocking:
Related Tickets: 12758 | Differential Rev(s): D5368
Wiki Page: |
Performance/Tests |
-------------------------------------+-------------------------------------
Comment (by Ben Gamari
#15924: Do not save performance test results if worktree is dirty -------------------------------------+------------------------------------- Reporter: davide | Owner: davide Type: bug | Status: closed Priority: normal | Milestone: 8.8.1 Component: Test Suite | Version: 8.6.2 Resolution: fixed | Keywords: performance | tests git notes Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: 12758 | Differential Rev(s): D5368 Wiki Page: | Performance/Tests | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => closed * resolution: => fixed * milestone: => 8.8.1 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15924#comment:6 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC