[GHC] #10977: Arm: Undeclared indentifier when build un-registerised
#10977: Arm: Undeclared indentifier when build un-registerised ----------------------------------+---------------------------------------- Reporter: erikd | Owner: erikd Type: bug | Status: new Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 7.11 Keywords: rts linker | Operating System: Unknown/Multiple Architecture: arm | Type of failure: Building GHC failed Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: ----------------------------------+---------------------------------------- I have a Jenkins job which builds un-registerised on armhf and just got this: {{{ rts/Linker.c:6209:21: error: error: ‘target_shndx’ undeclared (first use in this function) if (oc->sections[target_shndx].kind == SECTIONKIND_OTHER) { ^ rts/Linker.c:6209:21: error: note: each undeclared identifier is reported only once for each function it appears in `gcc' failed in phase `C Compiler'. (Exit code: 1) }}} Seems this is a result of 04e8366608 and the fix is pretty obvious. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10977> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10977: Arm: Undeclared indentifier when build un-registerised ----------------------------------------+---------------------------------- Reporter: erikd | Owner: erikd Type: bug | Status: new Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 7.11 Resolution: | Keywords: rts linker Operating System: Unknown/Multiple | Architecture: arm Type of failure: Building GHC failed | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | ----------------------------------------+---------------------------------- Comment (by erikd): This problem is really easy to fix by pulling: {{{#!C int target_shndx = shdr[shnum].sh_info; }}} out of the `#ifdef`, but that just fixes the most obvious and immediate problem. The real problem is the heavy usage of `#ifdef` in this file. For instance, I cannot figure out why in this line {{{ #if defined(DEBUG) || defined(sparc_HOST_ARCH) || defined(ia64_HOST_ARCH) || \ defined(powerpc_HOST_ARCH) || defined(x86_64_HOST_ARCH) }}} Sparc, Ia64, PowerPC and x86_64 are all included, but i386, Arm and PowerPC64 are not. Furthermore, when someone is working on a new architecture like AArch64, how are they supposed to know whether it should be part of this magical set or not? -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10977#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10977: Arm: Undeclared indentifier when compiling rts/Linker.c ----------------------------------------+---------------------------------- Reporter: erikd | Owner: erikd Type: bug | Status: new Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 7.11 Resolution: | Keywords: rts linker Operating System: Unknown/Multiple | Architecture: arm Type of failure: Building GHC failed | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | ----------------------------------------+---------------------------------- Description changed by erikd: Old description:
I have a Jenkins job which builds un-registerised on armhf and just got this:
{{{ rts/Linker.c:6209:21: error: error: ‘target_shndx’ undeclared (first use in this function) if (oc->sections[target_shndx].kind == SECTIONKIND_OTHER) { ^
rts/Linker.c:6209:21: error: note: each undeclared identifier is reported only once for each function it appears in `gcc' failed in phase `C Compiler'. (Exit code: 1) }}}
Seems this is a result of 04e8366608 and the fix is pretty obvious.
New description: I have a Jenkins job which builds GHC on armhf and just got this: {{{ rts/Linker.c:6209:21: error: error: ‘target_shndx’ undeclared (first use in this function) if (oc->sections[target_shndx].kind == SECTIONKIND_OTHER) { ^ rts/Linker.c:6209:21: error: note: each undeclared identifier is reported only once for each function it appears in `gcc' failed in phase `C Compiler'. (Exit code: 1) }}} Seems this is a result of 04e8366608 and the fix is pretty obvious. -- -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10977#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10977: Arm: Undeclared indentifier when compiling rts/Linker.c ----------------------------------------+---------------------------------- Reporter: erikd | Owner: erikd Type: bug | Status: new Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 7.11 Resolution: | Keywords: rts linker Operating System: Unknown/Multiple | Architecture: arm Type of failure: Building GHC failed | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1330 Wiki Page: | ----------------------------------------+---------------------------------- Changes (by erikd): * differential: => Phab:D1330 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10977#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10977: Arm: Undeclared indentifier when compiling rts/Linker.c ----------------------------------------+---------------------------------- Reporter: erikd | Owner: erikd Type: bug | Status: new Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 7.11 Resolution: | Keywords: rts linker Operating System: Unknown/Multiple | Architecture: arm Type of failure: Building GHC failed | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1330 Wiki Page: | ----------------------------------------+---------------------------------- Comment (by Erik de Castro Lopo <erikd@…>): In [changeset:"4d6844a54f1fc72b3ba31f1b6e09991add816875/ghc" 4d6844a/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="4d6844a54f1fc72b3ba31f1b6e09991add816875" rts/Linker.c : Fix armhf build (#10977) Test Plan: Validate on x86_64, PowerPC and Arm Reviewers: simonmar, austin, bgamari Subscribers: thomie Differential Revision: https://phabricator.haskell.org/D1330 GHC Trac Issues: #10977 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10977#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10977: Arm: Undeclared indentifier when compiling rts/Linker.c ----------------------------------------+---------------------------------- Reporter: erikd | Owner: erikd Type: bug | Status: closed Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 7.11 Resolution: fixed | Keywords: rts linker Operating System: Unknown/Multiple | Architecture: arm Type of failure: Building GHC failed | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1330 Wiki Page: | ----------------------------------------+---------------------------------- Changes (by erikd): * status: new => closed * resolution: => fixed -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10977#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC