[GHC] #12398: Expose 'withCleanupSession' as a replacement for 'defaultCleanupHandler'
#12398: Expose 'withCleanupSession' as a replacement for 'defaultCleanupHandler' -------------------------------------+------------------------------------- Reporter: DanielG | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.0.1 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- GHC used to export 'defaultCleanupHandler' going back as far as 7.4, starting with 8.0 no equivalent function seems to be exported. Please consider exporting 'withCleanupSession' as a replacement. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12398> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12398: Expose 'withCleanupSession' as a replacement for 'defaultCleanupHandler' -------------------------------------+------------------------------------- Reporter: DanielG | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by DanielG): I should also note that using runGhc/runGhcT is not fesible as they mess with signal handlers which is undesirable for what I'm doing. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12398#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12398: Expose 'withCleanupSession' as a replacement for 'defaultCleanupHandler' -------------------------------------+------------------------------------- Reporter: DanielG | Owner: Type: bug | Status: new Priority: normal | Milestone: 8.0.2 Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * cc: simonmar (added) * milestone: => 8.0.2 Comment: Adding Simon Marlow who deprecated `defaultCleanupHandler` in 4905b83a2d448c65ccced385343d4e8124548a3b. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12398#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12398: Expose 'withCleanupSession' as a replacement for 'defaultCleanupHandler' -------------------------------------+------------------------------------- Reporter: DanielG | Owner: Type: bug | Status: new Priority: normal | Milestone: 8.0.2 Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by simonmar): Ok, I can see why you might not want the signal handlers installed. But you probably want the other stuff that `runGhc` does, like initialising the DynFlags and the HscEnv, right? Or do you want to use your own `runGhc`? -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12398#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12398: Expose 'withCleanupSession' as a replacement for 'defaultCleanupHandler' -------------------------------------+------------------------------------- Reporter: DanielG | Owner: Type: bug | Status: new Priority: normal | Milestone: 8.0.2 Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by DanielG): I have my own `GhcT`/`runGhcT` variant that does all the initialization. Ideally a function doing just the important initialization bits would be exported too but it's simple enough that it doesn't bother me either way. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12398#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12398: Expose 'withCleanupSession' as a replacement for 'defaultCleanupHandler' -------------------------------------+------------------------------------- Reporter: DanielG | Owner: Type: bug | Status: patch Priority: normal | Milestone: 8.0.2 Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2492 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => patch * differential: => Phab:D2492 Comment: DanielG, how does Phab:D2492 look? -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12398#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12398: Expose 'withCleanupSession' as a replacement for 'defaultCleanupHandler' -------------------------------------+------------------------------------- Reporter: DanielG | Owner: Type: bug | Status: patch Priority: normal | Milestone: 8.0.2 Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2492 Wiki Page: | -------------------------------------+------------------------------------- Comment (by DanielG): Perfect, thanks! -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12398#comment:6> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12398: Expose 'withCleanupSession' as a replacement for 'defaultCleanupHandler' -------------------------------------+------------------------------------- Reporter: DanielG | Owner: Type: bug | Status: patch Priority: normal | Milestone: 8.0.2 Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2492 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"0e7492508cefbcabb4cf1398cfb3669edb72db77/ghc" 0e749250/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="0e7492508cefbcabb4cf1398cfb3669edb72db77" GHC: Expose installSignalHandlers, withCleanupSession Test Plan: Validate Reviewers: austin, simonmar Reviewed By: simonmar Subscribers: thomie Differential Revision: https://phabricator.haskell.org/D2492 GHC Trac Issues: #12398 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12398#comment:7> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12398: Expose 'withCleanupSession' as a replacement for 'defaultCleanupHandler' -------------------------------------+------------------------------------- Reporter: DanielG | Owner: Type: bug | Status: merge Priority: normal | Milestone: 8.0.2 Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2492 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: patch => merge -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12398#comment:8> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12398: Expose 'withCleanupSession' as a replacement for 'defaultCleanupHandler' -------------------------------------+------------------------------------- Reporter: DanielG | Owner: Type: bug | Status: merge Priority: normal | Milestone: 8.0.2 Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2492 Wiki Page: | -------------------------------------+------------------------------------- Comment (by bgamari): Merged to `ghc-8.0` with aedb41292d042963ad281641f85c26e5c9ea4d4d. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12398#comment:9> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12398: Expose 'withCleanupSession' as a replacement for 'defaultCleanupHandler' -------------------------------------+------------------------------------- Reporter: DanielG | Owner: Type: bug | Status: closed Priority: normal | Milestone: 8.0.2 Component: Compiler | Version: 8.0.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2492 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: merge => closed * resolution: => fixed -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12398#comment:10> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC