[GHC] #9912: Allow access to full logs in Harbormaster builds
#9912: Allow access to full logs in Harbormaster builds -------------------------------------+------------------------------------- Reporter: goldfire | Owner: hvr Type: bug | Status: new Priority: normal | Milestone: Component: Trac & Git | Version: 7.8.3 Keywords: | Operating System: Architecture: Unknown/Multiple | Unknown/Multiple Difficulty: Unknown | Type of failure: Blocked By: | None/Unknown Related Tickets: | Test Case: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Harbormaster helpfully tries building every commit and every differential revision. However, when it fails, we only get the tail of the output, with no way to get more information. A case in point is [https://phabricator.haskell.org/harbormaster/build/2736/ this build], where a performance test case failed with `[stat too good]`. In this particular case, the commit is intended to be an optimization, so this failure is not terribly unexpected. I wanted to update `all.T` with the new figure, but I couldn't get the figure that Harbormaster's configuration had. Instead, I had to run the test on my machine (a Mac), get a different number, and hope that Harbormaster's configuration fell within 5% of mine. It did, in this case, but might not next time. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9912 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#9912: Allow access to full logs in Harbormaster builds -------------------------------------+------------------------------------- Reporter: goldfire | Owner: thoughtpolice Type: bug | Status: new Priority: normal | Milestone: Component: Trac & Git | Version: Resolution: | Keywords: Operating System: | Architecture: Unknown/Multiple Unknown/Multiple | Difficulty: Unknown Type of failure: | Blocked By: None/Unknown | Related Tickets: Test Case: | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Changes (by hvr): * owner: hvr => thoughtpolice * version: 7.8.3 => -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9912#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#9912: Allow access to full logs in Harbormaster builds -------------------------------------+------------------------------------- Reporter: goldfire | Owner: thoughtpolice Type: bug | Status: new Priority: normal | Milestone: Component: Trac & Git | Version: Resolution: | Keywords: Operating System: | Architecture: Unknown/Multiple Unknown/Multiple | Difficulty: Unknown Type of failure: | Blocked By: None/Unknown | Related Tickets: Test Case: | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Comment (by goldfire): I thought "Trac & Git" was the best value for the Component field for this ticket, and that component sets the owner to hvr. Perhaps there should be a new Phab component? In any case, I wasn't intending to say that hvr is responsible here! -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9912#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#9912: Allow access to full logs in Harbormaster builds -------------------------------------+------------------------------------- Reporter: goldfire | Owner: | thoughtpolice Type: bug | Status: closed Priority: normal | Milestone: Component: Trac & Git | Version: Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: -------------------------------------+------------------------------------- Changes (by thomie): * status: new => closed * resolution: => fixed Comment: Phabricator now show 1000 lines of log on failed builds. Ping thoughtpolice or open a ticket here if that's still not good enough: https://github.com/haskell-infra/phab-ghc-builder. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9912#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#9912: Allow access to full logs in Harbormaster builds -------------------------------------+------------------------------------- Reporter: goldfire | Owner: | thoughtpolice Type: bug | Status: closed Priority: normal | Milestone: Component: Trac & Git | Version: Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by goldfire): Why can't we just have no limit? Or an option to download the original log? Though I don't have a concrete example, I think 1000 is way too small, given that there are almost 5000 test cases. If an early one fails, we won't be able to see the failure output. (This is //not// to suggest that 5000 would be a good limit, a priori. Does each test case use only one line of output?) -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9912#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#9912: Allow access to full logs in Harbormaster builds -------------------------------------+------------------------------------- Reporter: goldfire | Owner: | thoughtpolice Type: bug | Status: closed Priority: normal | Milestone: Component: Trac & Git | Version: Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by thomie): Ask thoughtpolice. Something about Phabricator putting the logfile in a database record. But only tests that fail produce output (Phabricator calls `make test VERBOSE=1`), so unless you have 5000 failing test cases, you should be ok. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9912#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#9912: Allow access to full logs in Harbormaster builds -------------------------------------+------------------------------------- Reporter: goldfire | Owner: | thoughtpolice Type: bug | Status: closed Priority: normal | Milestone: Component: Trac & Git | Version: Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by goldfire): Ah. That's a bit better than. 1000 might indeed be enough. Thanks! -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9912#comment:6 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC