[GHC] #8789: includes/stg/SMP.h: use 'NOSMP' instead of never defined 'WITHSMP'
#8789: includes/stg/SMP.h: use 'NOSMP' instead of never defined 'WITHSMP' ------------------------------------+------------------------------------- Reporter: slyfox | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.6.3 Keywords: | Operating System: Unknown/Multiple Architecture: Unknown/Multiple | Type of failure: None/Unknown Difficulty: Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | ------------------------------------+------------------------------------- Looks like WITHSMP is not generated anywere, thus don't know how it worked before. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8789> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#8789: includes/stg/SMP.h: use 'NOSMP' instead of never defined 'WITHSMP' -------------------------------------+------------------------------------ Reporter: slyfox | Owner: thoughtpolice Type: bug | Status: new Priority: high | Milestone: 7.10.1 Component: Compiler | Version: 7.6.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Unknown/Multiple Type of failure: None/Unknown | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: -------------------------------------+------------------------------------ Changes (by simonmar): * owner: => thoughtpolice * priority: normal => high * milestone: => 7.10.1 Comment: Looks good to me. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8789#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#8789: includes/stg/SMP.h: use 'NOSMP' instead of never defined 'WITHSMP' -------------------------------------+------------------------------------ Reporter: slyfox | Owner: thoughtpolice Type: bug | Status: patch Priority: high | Milestone: 7.10.1 Component: Compiler | Version: 7.6.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Unknown/Multiple Type of failure: None/Unknown | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: -------------------------------------+------------------------------------ Changes (by slyfox): * status: new => patch -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8789#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#8789: includes/stg/SMP.h: use 'NOSMP' instead of never defined 'WITHSMP' -------------------------------------+------------------------------------ Reporter: slyfox | Owner: thoughtpolice Type: bug | Status: patch Priority: high | Milestone: 7.10.1 Component: Compiler | Version: 7.6.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Unknown/Multiple Type of failure: None/Unknown | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: -------------------------------------+------------------------------------ Comment (by Austin Seipp <austin@…>): In [changeset:"34bae1f737e1492c152ccaafd457697b621c606b/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="34bae1f737e1492c152ccaafd457697b621c606b" includes/stg/SMP.h: use 'NOSMP' instead of never defined 'WITHSMP' (Trac #8789) Summary: git history does not contain state where 'WITHSMP' macro was ever defined. It should have always been '!NOSMP'. Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org> Test Plan: build tested Reviewers: austin, simonmar Reviewed By: austin, simonmar Subscribers: simonmar, relrod, carter Differential Revision: https://phabricator.haskell.org/D33 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8789#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#8789: includes/stg/SMP.h: use 'NOSMP' instead of never defined 'WITHSMP' -------------------------------------+------------------------------------ Reporter: slyfox | Owner: thoughtpolice Type: bug | Status: closed Priority: high | Milestone: 7.10.1 Component: Compiler | Version: 7.6.3 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: Unknown/Multiple Type of failure: None/Unknown | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: -------------------------------------+------------------------------------ Changes (by thoughtpolice): * status: patch => closed * resolution: => fixed Comment: Merged, thanks! -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8789#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#8789: includes/stg/SMP.h: use 'NOSMP' instead of never defined 'WITHSMP' -------------------------------------+------------------------------------- Reporter: slyfox | Owner: Type: bug | thoughtpolice Priority: high | Status: closed Component: Compiler | Milestone: 7.10.1 Resolution: fixed | Version: 7.6.3 Operating System: Unknown/Multiple | Keywords: Type of failure: None/Unknown | Architecture: Blocked By: | Unknown/Multiple Related Tickets: | Test Case: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by nomeata): Might this be related to #10244? -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8789#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#8789: includes/stg/SMP.h: use 'NOSMP' instead of never defined 'WITHSMP' -------------------------------------+------------------------------------- Reporter: slyfox | Owner: Type: bug | thoughtpolice Priority: high | Status: closed Component: Compiler | Milestone: 7.10.1 Resolution: fixed | Version: 7.6.3 Operating System: Unknown/Multiple | Keywords: Type of failure: None/Unknown | Architecture: Blocked By: | Unknown/Multiple Related Tickets: | Test Case: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by rwbarton): Yes, it's definitely the cause. Effectively this change turned the behavior for architectures that don't have a specific memory barrier implementation from "do nothing and hope for the best" to "raise a compile-time error". -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8789#comment:6> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC