[GHC] #15439: Refactor `printMinimalImports` into two functions and reexport them
#15439: Refactor `printMinimalImports` into two functions and reexport them -------------------------------------+------------------------------------- Reporter: chshersh | Owner: (none) Type: feature | Status: new request | Priority: normal | Milestone: 8.6.1 Component: GHC API | Version: 8.4.3 Keywords: | Operating System: Unknown/Multiple imports,refactoring,source | plugins | Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- Currently the `printMinimalImports` function finds set of minimal imports and prints them into file. * https://github.com/ghc/ghc/blob/0f5a63e3d763f18c683f076e0e96396166863f56/com... But it's more convenient to have function that returns set of minimal imports that can later be used by external tools like source plugins without need to parse content of `.import` file. And without need to copy- paste existing function. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15439> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15439: Refactor `printMinimalImports` into two functions and reexport them -------------------------------------+------------------------------------- Reporter: chshersh | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: 8.6.1 Component: GHC API | Version: 8.4.3 Resolution: | Keywords: | imports,refactoring,source plugins Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by simonpj): I'm all for it. Send a patch? Thanks! -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15439#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15439: Refactor `printMinimalImports` into two functions and reexport them -------------------------------------+------------------------------------- Reporter: chshersh | Owner: vrom911 Type: feature request | Status: new Priority: normal | Milestone: 8.6.1 Component: GHC API | Version: 8.4.3 Resolution: | Keywords: | imports,refactoring,source plugins Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D5045 Wiki Page: | -------------------------------------+------------------------------------- Changes (by vrom911): * owner: (none) => vrom911 * differential: => Phab:D5045 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15439#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15439: Refactor `printMinimalImports` into two functions and reexport them -------------------------------------+------------------------------------- Reporter: chshersh | Owner: vrom911 Type: feature request | Status: new Priority: normal | Milestone: 8.6.1 Component: GHC API | Version: 8.4.3 Resolution: | Keywords: | imports,refactoring,source plugins Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D5045 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Krzysztof Gogolewski <krz.gogolewski@…>): In [changeset:"73683f143d352343b00b1ab4f3abeb38b81794be/ghc" 73683f1/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="73683f143d352343b00b1ab4f3abeb38b81794be" Refactor printMinimalImports (#15439) Summary: Split into getMinimalImports and printMinimalImports. Export both functions from RnNames module. Reviewers: bgamari, mpickering Reviewed By: mpickering Subscribers: mpickering, rwbarton, carter GHC Trac Issues: #15439 Differential Revision: https://phabricator.haskell.org/D5045 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15439#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15439: Refactor `printMinimalImports` into two functions and reexport them -------------------------------------+------------------------------------- Reporter: chshersh | Owner: vrom911 Type: feature request | Status: merge Priority: normal | Milestone: 8.6.1 Component: GHC API | Version: 8.4.3 Resolution: | Keywords: | imports,refactoring,source plugins Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D5045 Wiki Page: | -------------------------------------+------------------------------------- Changes (by monoidal): * status: new => merge -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15439#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15439: Refactor `printMinimalImports` into two functions and reexport them -------------------------------------+------------------------------------- Reporter: chshersh | Owner: vrom911 Type: feature request | Status: closed Priority: normal | Milestone: 8.6.1 Component: GHC API | Version: 8.4.3 Resolution: fixed | Keywords: | imports,refactoring,source plugins Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D5045 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: merge => closed * resolution: => fixed Comment: Merged with f6e889fd1b9aa4e6f3ddaf69bc9446a7ca86fc8f. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15439#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC