[GHC] #12223: Get rid of extra_files.py
#12223: Get rid of extra_files.py -------------------------------------+------------------------------------- Reporter: ezyang | Owner: thomie Type: bug | Status: new Priority: normal | Milestone: Component: Test Suite | Version: 8.0.1 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- Hello thomie! When you refactored the test suite you added `testsuite/driver/extra_files.py` to record what extra files need to get copied. In it, there is a comment "Maybe move this information to .T files at some point." This ticket is to remind you so you don't forget. This file is *extremely* un-discoverable. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12223> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12223: Get rid of extra_files.py -------------------------------------+------------------------------------- Reporter: ezyang | Owner: thomie Type: bug | Status: new Priority: normal | Milestone: Component: Test Suite | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by thomie): Yes, I will do this right before the 8.2 branching. I could do it now, but it would just cause merge conflicts when cherry-picking patches to the 8.0 branch. Sorry for not making it more discoverable. Please use the `extra_files` setup function for new tests, as described on [wiki:Building/RunningTests/Adding]. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12223#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12223: Get rid of extra_files.py -------------------------------------+------------------------------------- Reporter: ezyang | Owner: thomie Type: task | Status: new Priority: normal | Milestone: 8.2.1 Component: Test Suite | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * type: bug => task * milestone: => 8.2.1 Comment: I appreciate you waiting for fix this thomie! Thanks. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12223#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12223: Get rid of extra_files.py -------------------------------------+------------------------------------- Reporter: ezyang | Owner: thomie Type: task | Status: new Priority: highest | Milestone: 8.2.1 Component: Test Suite | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * priority: normal => highest Comment: Thomie, I suspect we are close enough to the branch point that it would be reasonable to carry this out now. Bumping priority so we don't lose track of this. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12223#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12223: Get rid of extra_files.py -------------------------------------+------------------------------------- Reporter: ezyang | Owner: thomie Type: task | Status: new Priority: highest | Milestone: 8.2.1 Component: Test Suite | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"5d38fb69fd1e7a434ccc3147ae6a17fe0b5b0be3/ghc" 5d38fb69/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="5d38fb69fd1e7a434ccc3147ae6a17fe0b5b0be3" Remove clean_cmd and extra_clean usage from .T files The `clean_cmd` and `extra_clean` setup functions don't do anything. Remove them from .T files. Created using https://github.com/thomie/refactor-ghc-testsuite. This diff is a test for the .T-file parser/processor/pretty-printer in that repository. find . -name '*.T' -exec ~/refactor-ghc-testsuite/Main "{}" \; Tests containing inline comments or multiline strings are not modified. Preparation for #12223. Test Plan: Harbormaster Reviewers: austin, hvr, simonmar, mpickering, bgamari Reviewed By: mpickering Subscribers: mpickering Differential Revision: https://phabricator.haskell.org/D3000 GHC Trac Issues: #12223 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12223#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12223: Get rid of extra_files.py -------------------------------------+------------------------------------- Reporter: ezyang | Owner: rwbarton Type: task | Status: new Priority: highest | Milestone: 8.2.1 Component: Test Suite | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by rwbarton): * owner: thomie => rwbarton -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12223#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12223: Get rid of extra_files.py -------------------------------------+------------------------------------- Reporter: ezyang | Owner: rwbarton Type: task | Status: new Priority: highest | Milestone: 8.2.1 Component: Test Suite | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"3415bcaa0b1903b5e12dfaadb5b774718e406eab/ghc" 3415bca/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="3415bcaa0b1903b5e12dfaadb5b774718e406eab" tests: remove extra_files.py (#12223) The script I used is included as testsuite/driver/kill_extra_files.py, though at this point it is for mostly historical interest. Some of the tests in libraries/hpc relied on extra_files.py, so this commit includes an update to that submodule. One test in libraries/process also relies on extra_files.py, but we cannot update that submodule so easily, so for now we special-case it in the test driver. }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12223#comment:6> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12223: Get rid of extra_files.py -------------------------------------+------------------------------------- Reporter: ezyang | Owner: rwbarton Type: task | Status: closed Priority: highest | Milestone: 8.2.1 Component: Test Suite | Version: 8.0.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => closed * resolution: => fixed -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12223#comment:7> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC