[GHC] #13636: Enable -Wcpp-undef
#13636: Enable -Wcpp-undef -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: task | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.1 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- e5b3492f23c2296d0d8221e1787ee585331f726e tried (again) to enable `-Wcpp- undef` in `mk/warnings.mk`, {{{#!make SRC_HC_OPTS_STAGE1 += $(WERROR) #-Wcpp-undef SRC_HC_OPTS_STAGE2 += $(WERROR) #-Wcpp-undef }}} Unfortunately, this caused build failures in boot libraries on some platforms (e.g. `time` on Darwin). Resolve these and reenable `-Wcpp- undef`. An alternative would be to instead only add `-Wcpp-undef` to `GhcRtsHcOpts`, `GhcStage1HcOpts` and `GhcStage2HcOpts`. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13636> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13636: Enable -Wcpp-undef -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: task | Status: new Priority: normal | Milestone: 8.4.1 Component: Compiler | Version: 8.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * version: 8.1 => 8.3 * milestone: => 8.4.1 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13636#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13636: Enable -Wcpp-undef -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: task | Status: new Priority: normal | Milestone: 8.4.1 Component: Compiler | Version: 8.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"6267d8c9e54663a23f0ac13556522a53580d0910/ghc" 6267d8c9/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="6267d8c9e54663a23f0ac13556522a53580d0910" Enable -Wcpp-undef for GHC and runtime system This gets us much of the benefit of enabling it globally, which avoiding (at least for now) the pain of making the core libraries build as well. See #13636. Test Plan: Validate Reviewers: erikd, austin Subscribers: rwbarton, thomie GHC Trac Issues: #13636 Differential Revision: https://phabricator.haskell.org/D3517 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13636#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13636: Enable -Wcpp-undef -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: task | Status: closed Priority: normal | Milestone: 8.4.1 Component: Compiler | Version: 8.3 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => closed * resolution: => fixed -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13636#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC