[GHC] #12484: Missing pattern synonym signatures gives incorrect fix
#12484: Missing pattern synonym signatures gives incorrect fix -------------------------------------+------------------------------------- Reporter: alanz | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.0.1 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: Incorrect Unknown/Multiple | warning at compile-time Test Case: | Blocked By: Blocking: | Related Tickets: #11053 Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- The following pattern definition {{{#!hs pattern RP pname help type' <- ParamDesc pname help type' Required where RP pname help type' = ParamDesc pname help type' Required }}} Gives the warning {{{ /....../PluginTypes.hs:248:1: warning: [-Wmissing-signatures] Top-level binding with no type signature: RP :: ParamName -> ParamHelp -> ParamType -> ParamDescription }}} The required signature is in fact {{{#!hs pattern RP :: ParamName -> ParamHelp -> ParamType -> ParamDescription }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12484> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12484: Missing pattern synonym signatures gives incorrect fix -------------------------------------+------------------------------------- Reporter: alanz | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect | Unknown/Multiple warning at compile-time | Test Case: Blocked By: | Blocking: Related Tickets: #11053 | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by Simon Peyton Jones <simonpj@…>): In [changeset:"ac0e11252af149f085e2262200b7a1638b4a1553/ghc" ac0e1125/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="ac0e11252af149f085e2262200b7a1638b4a1553" Improve missing-sig warning Fixes Trac #12484 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12484#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12484: Missing pattern synonym signatures gives incorrect fix -------------------------------------+------------------------------------- Reporter: alanz | Owner: Type: bug | Status: merge Priority: normal | Milestone: Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect | Unknown/Multiple warning at compile-time | Test Case: Blocked By: | Blocking: Related Tickets: #11053 | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by simonpj): * status: new => merge Comment: Good point, thanks. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12484#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12484: Missing pattern synonym signatures gives incorrect fix -------------------------------------+------------------------------------- Reporter: alanz | Owner: Type: bug | Status: merge Priority: normal | Milestone: Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect | Unknown/Multiple warning at compile-time | Test Case: Blocked By: | Blocking: Related Tickets: #11053 | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"ca58946e7b3ac32785ef073e0e4daeece31dfd70/ghc" ca58946e/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="ca58946e7b3ac32785ef073e0e4daeece31dfd70" Improve missing-sig warning Fixes Trac #12484 (cherry picked from commit ac0e11252af149f085e2262200b7a1638b4a1553) }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12484#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12484: Missing pattern synonym signatures gives incorrect fix -------------------------------------+------------------------------------- Reporter: alanz | Owner: Type: bug | Status: closed Priority: normal | Milestone: 8.0.2 Component: Compiler | Version: 8.0.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect | Unknown/Multiple warning at compile-time | Test Case: Blocked By: | Blocking: Related Tickets: #11053 | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: merge => closed * resolution: => fixed * milestone: => 8.0.2 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12484#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC