[GHC] #13836: Some event log events won't be flushed if capability count decreased with setNumCapabitilies
#13836: Some event log events won't be flushed if capability count decreased with setNumCapabitilies -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: Runtime | Version: 8.0.1 System | Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- Currently the eventlog code assumes that there have been at most `n_capabilities` capabilities at the time of cleanup. This may not hold in the event that the capability count was decreased using `setNumCapabilities`. This means that some `EventBuf`s won't be flushed when the program terminates. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13836 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#13836: Some event log events won't be flushed if capability count decreased with setNumCapabitilies -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: patch Priority: normal | Milestone: Component: Runtime System | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3654 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => patch * differential: => Phab:D3654 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13836#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#13836: Some event log events won't be flushed if capability count decreased with setNumCapabitilies -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: patch Priority: normal | Milestone: Component: Runtime System | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3654 Wiki Page: | -------------------------------------+------------------------------------- Comment (by duog): I'm probably missing something, but by my reading of setNumCapabilities in Shedule.c, n_capabilities can never decrease. If the number of capabilities decreases, enabled_capabilities is used to disable capabiltities. If that is true, then I don't think this can ever happen? -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13836#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#13836: Some event log events won't be flushed if capability count decreased with setNumCapabitilies -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: closed Priority: normal | Milestone: Component: Runtime System | Version: 8.0.1 Resolution: invalid | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3654 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: patch => closed * resolution: => invalid Comment: Nope, you aren't missing anything at all. I didn't look too carefully at `setNumCapabilities`; it looks like you are right! Good catch. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13836#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC