[GHC] #10483: Refactor HsForAllTy
#10483: Refactor HsForAllTy -------------------------------------+------------------------------------- Reporter: simonpj | Owner: Type: task | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.10.1 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Blocked By: Test Case: | Related Tickets: Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- I got sucked into refactoring `HsForAllTy`, like this: {{{ data HsType name = HsForAllTy (HsForAll name) (LHsType name) | ... data HsForAll name -- The quantifiers of a HsForAllTy = HSF { hsf_flag :: HsExplicitFlag , hsf_extra :: Maybe SrcSpan , hsf_qtvs :: LHsTyVarBndrs name , hsf_ctxt :: LHsContext name } }}} This makes a number of functions neater, as well as naming the fields of a troublesomely-high-arity data constructor. This ticket is here to track progress. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10483 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#10483: Refactor HsForAllTy -------------------------------------+------------------------------------- Reporter: simonpj | Owner: Type: task | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.10.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: Phab:D953 -------------------------------------+------------------------------------- Changes (by simonpj): * differential: => Phab:D953 Comment: Current failures {{{ Unexpected failures: ghc-api/annotations T10268 [bad stdout] (normal) ghc-api/annotations T10278 [bad stderr] (normal) ghc-api/annotations T10354 [bad stdout] (normal) ghc-api/annotations T10396 [bad stdout] (normal) ghc-api/annotations listcomps [bad stdout] (normal) ghc-api/landmines landmines [bad stdout] (normal) rename/should_fail T5951 [stderr mismatch] (normal) }}} Alan Z: could you possibly look at the annotations ones? I tried not to change anything, so I supsect that there is one bug causing all of them. Thank you! I will deal with T5951. Simon -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10483#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#10483: Refactor HsForAllTy -------------------------------------+------------------------------------- Reporter: simonpj | Owner: Type: task | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.10.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D953 -------------------------------------+------------------------------------- Comment (by simonpj): Please don't look at this any more! I've been working on an alternative. Very sorry, should have mentioned this. Simon -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10483#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#10483: Refactor HsForAllTy -------------------------------------+------------------------------------- Reporter: simonpj | Owner: Type: task | Status: closed Priority: normal | Milestone: Component: Compiler | Version: 7.10.1 Resolution: wontfix | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D953 Wiki Page: | -------------------------------------+------------------------------------- Changes (by simonpj): * status: new => closed * resolution: => wontfix Comment: Abandoned in favour of `wip/spj-wildcard-refactor` and Phab:D1428. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10483#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC