[GHC] #11763: Implement `-f(no-)version-macros` flag for controlling version macro generation
#11763: Implement `-f(no-)version-macros` flag for controlling version macro generation -------------------------------------+------------------------------------- Reporter: hvr | Owner: Type: feature | Status: new request | Priority: highest | Milestone: 8.0.1 Component: Compiler | Version: 7.11 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: #10970 Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- Since a9c93bdd8b027d6de09a3eada7721e7fd2d3e050 / #10970 GHC is able to generate `MIN_VERSION_...` and `VERSION_...` natively without Cabal's help. Currently, this feature is currently triggered by `-hide-all-packages`. However, additionally, it seems reasonable to be able to control this more explicitly. E.g. either to be able to explicitly disable even if `-hide- all-packages` implicitly enabled the macros, as well as be able to explicitly request macro generation for currently visible packages even without any `-hide-all-package`/`-package` flags. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11763> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11763: Implement `-f(no-)version-macros` flag for controlling version macro generation -------------------------------------+------------------------------------- Reporter: hvr | Owner: Type: feature request | Status: new Priority: highest | Milestone: 8.0.1 Component: Compiler | Version: 7.11 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #10970 | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by rwbarton): I thought this was already fixed to always generate the macros? -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11763#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11763: Implement `-f(no-)version-macros` flag for controlling version macro generation -------------------------------------+------------------------------------- Reporter: hvr | Owner: Type: feature request | Status: new Priority: highest | Milestone: 8.0.1 Component: Compiler | Version: 7.11 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #10970 | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by hvr): Replying to [comment:1 rwbarton]:
I thought this was already fixed to always generate the macros?
even in that case (which doesn't seem to be the case with a current GHC HEAD snapshot), we want the ability to explicitly say `-fno-version- macros` -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11763#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11763: Implement `-f(no-)version-macros` flag for controlling version macro generation -------------------------------------+------------------------------------- Reporter: hvr | Owner: Type: feature request | Status: new Priority: highest | Milestone: 8.0.1 Component: Compiler | Version: 7.11 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #10970 | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by bgamari): Not yet; Phab:D1869 enables macro generation always, but I've held off on merging it in hopes that someone would pick up this ticket. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11763#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11763: Implement `-f(no-)version-macros` flag for controlling version macro generation -------------------------------------+------------------------------------- Reporter: hvr | Owner: ezyang Type: feature request | Status: new Priority: highest | Milestone: 8.0.1 Component: Compiler | Version: 7.11 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #10970 | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by ezyang): * owner: => ezyang -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11763#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11763: Implement `-f(no-)version-macros` flag for controlling version macro generation -------------------------------------+------------------------------------- Reporter: hvr | Owner: ezyang Type: feature request | Status: patch Priority: highest | Milestone: 8.0.1 Component: Compiler | Version: 7.11 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #10970 | Differential Rev(s): Phab:D2058 Wiki Page: | -------------------------------------+------------------------------------- Changes (by ezyang): * status: new => patch * differential: => Phab:D2058 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11763#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11763: Implement `-f(no-)version-macros` flag for controlling version macro generation -------------------------------------+------------------------------------- Reporter: hvr | Owner: ezyang Type: feature request | Status: patch Priority: highest | Milestone: 8.0.1 Component: Compiler | Version: 7.11 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #10970 | Differential Rev(s): Phab:D2058 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"bc953fcdbc76ffbb4f06a2b74be271268f73328f/ghc" bc953fc/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="bc953fcdbc76ffbb4f06a2b74be271268f73328f" Add -f(no-)version-macro to explicitly control macros. Test Plan: validate Reviewers: thomie, austin, bgamari Reviewed By: bgamari Subscribers: hvr Differential Revision: https://phabricator.haskell.org/D2058 GHC Trac Issues: #11763 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11763#comment:6> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11763: Implement `-f(no-)version-macros` flag for controlling version macro generation -------------------------------------+------------------------------------- Reporter: hvr | Owner: ezyang Type: feature request | Status: closed Priority: highest | Milestone: 8.0.1 Component: Compiler | Version: 7.11 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #10970 | Differential Rev(s): Phab:D2058 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: patch => closed * resolution: => fixed Comment: Merged to `ghc-8.0` as eb2c0edf950e4c1d8e2ce058eda017e6bd6e398c. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11763#comment:7> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC