[GHC] #11550: ghc-HEAD -DDEBUG is broken (possiby by D1880)
#11550: ghc-HEAD -DDEBUG is broken (possiby by D1880) -------------------------------------+------------------------------------- Reporter: slyfox | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.1 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: Compile-time Unknown/Multiple | crash Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- Was found when tried to build with BuildFlavour = devel2 {{{ ghc-validate $ LANG=C make V=0 HC [stage 2] libraries/parallel/dist-install/build/Control/Seq.o WARNING: file compiler/stgSyn/CoreToStg.hs, line 250 using False True ghc-stage2: panic! (the 'impossible' happened) (GHC version 8.1.20160206 for x86_64-unknown-linux): ASSERT failed! CallStack (from HasCallStack): assertPprPanic, called at compiler/stgSyn/CoreToStg.hs:216:59 in ghc:CoreToStg using Please report this as a GHC bug: http://www.haskell.org/ghc/reportabug }}} https://travis-ci.org/ghc/ghc/builds suggests changeset:4f9967aa3d1f7cfd539d0c173cafac0fe290e26f might be at fault. Reverting it on top of master fixes devel2 build. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11550> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11550: ghc-HEAD -DDEBUG is broken (possiby by D1880) -------------------------------------+------------------------------------- Reporter: slyfox | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Compile-time | Unknown/Multiple crash | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by osa1): I have a fix, I'm waiting for Simon's review. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11550#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11550: ghc-HEAD -DDEBUG is broken (possiby by D1880) -------------------------------------+------------------------------------- Reporter: slyfox | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Compile-time | Unknown/Multiple crash | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by slyfox): Yay! Do you happen to have it published anywhere so i could apply it locally? -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11550#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11550: ghc-HEAD -DDEBUG is broken (possiby by D1880) -------------------------------------+------------------------------------- Reporter: slyfox | Owner: Type: bug | Status: patch Priority: normal | Milestone: Component: Compiler | Version: 8.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Compile-time | Unknown/Multiple crash | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1889 Wiki Page: | -------------------------------------+------------------------------------- Changes (by osa1): * status: new => patch * differential: => Phab:D1889 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11550#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11550: ghc-HEAD -DDEBUG is broken (possiby by D1880) -------------------------------------+------------------------------------- Reporter: slyfox | Owner: Type: bug | Status: patch Priority: normal | Milestone: Component: Compiler | Version: 8.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Compile-time | Unknown/Multiple crash | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1889 Wiki Page: | -------------------------------------+------------------------------------- Comment (by osa1): FYI I reverted the patch in the meantime. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11550#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11550: ghc-HEAD -DDEBUG is broken (possiby by D1880) -------------------------------------+------------------------------------- Reporter: slyfox | Owner: Type: bug | Status: closed Priority: normal | Milestone: Component: Compiler | Version: 8.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Compile-time | Unknown/Multiple crash | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1889 Wiki Page: | -------------------------------------+------------------------------------- Changes (by slyfox): * status: patch => closed * resolution: => fixed Comment: Thanks! -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11550#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11550: ghc-HEAD -DDEBUG is broken (possiby by D1880) -------------------------------------+------------------------------------- Reporter: slyfox | Owner: Type: bug | Status: closed Priority: normal | Milestone: Component: Compiler | Version: 8.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Compile-time | Unknown/Multiple crash | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1889 Wiki Page: | -------------------------------------+------------------------------------- Comment (by simonpj): I responded to the Phab: There's an easier way. Use the old code for `stgArgHasCafRefs` use {{{ stgIdHasCafRefs :: Id -> Bool stgIdHasCafRefs id = isGlobalId id && mayHaveCafRefs (idCafInfo id) }}} After `TidyPgm`, all top-level and imported Ids are `GlobalIds`. Needs a comment of course! -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11550#comment:6> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11550: ghc-HEAD -DDEBUG is broken (possiby by D1880) -------------------------------------+------------------------------------- Reporter: slyfox | Owner: Type: bug | Status: closed Priority: normal | Milestone: Component: Compiler | Version: 8.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Compile-time | Unknown/Multiple crash | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1889 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ömer Sinan Ağacan <omeragacan@…>): In [changeset:"023fc92f6f98a8bd003ce20083d3682aec865cb5/ghc" 023fc92f/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="023fc92f6f98a8bd003ce20083d3682aec865cb5" Remove unused LiveVars and SRT fields of StgCase We also need to update `stgBindHasCafRefs` assertion with this change, as we no longer have the pre-computed SRT, LiveVars etc. We rename it to `topStgBindHasCafRefs` and implement it like this: A non-updatable top-level binding may refer to a CAF by referring to a top-level definition with CAFs. A top-level definition may have CAFs if it's updatable. At this point (because this is done after TidyPgm) top-level Ids (whether imported or defined in this module) are GlobalIds, so the top-levelness test is easy. (see also comments in the code) Reviewers: bgamari, simonpj, austin Reviewed By: simonpj Subscribers: thomie Differential Revision: https://phabricator.haskell.org/D1889 GHC Trac Issues: #11550 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11550#comment:7> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC