[GHC] #8283: utils/fingerprint/fingerprint.py doesn't work on Windows
#8283: utils/fingerprint/fingerprint.py doesn't work on Windows -------------------------------------------+------------------------------- Reporter: schyler | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Build System | Version: 7.7 Keywords: | Operating System: Windows Architecture: Unknown/Multiple | Type of failure: Difficulty: Easy (less than 1 hour) | None/Unknown Blocked By: | Test Case: Related Tickets: | Blocking: -------------------------------------------+------------------------------- Invocation: {{{ utils/fingerprint/fingerprint.py create }}} Produces: {{{ WindowsError: [Error 193] %1 is not a valid Win32 application }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8283> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#8283: utils/fingerprint/fingerprint.py doesn't work on Windows -------------------------------+------------------------------------------- Reporter: schyler | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Build | Version: 7.7 System | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: Windows | Difficulty: Easy (less than 1 hour) Type of failure: | Blocked By: None/Unknown | Related Tickets: Test Case: | Blocking: | -------------------------------+------------------------------------------- Comment (by leroux): Here's the stack trace that should have been included with the error message. {{{ Traceback (most recent call last): File "utils/fingerprint/fingerprint.py", line 249, in <module> main() File "utils/fingerprint/fingerprint.py", line 15, in main opts.action(opts) File "utils/fingerprint/fingerprint.py", line 22, in create_action fp = fingerprint(opts.source) File "utils/fingerprint/fingerprint.py", line 59, in fingerprint source = Popen(sync_all, stdout=PIPE) File "c:\Python27\lib\subprocess.py", line 711, in __init__ errread, errwrite) File "c:\Python27\lib\subprocess.py", line 948, in _execute_child startupinfo) WindowsError: [Error 193] %1 is not a valid Win32 application }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8283#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#8283: utils/fingerprint/fingerprint.py doesn't work on Windows -------------------------------+------------------------------------------- Reporter: schyler | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Build | Version: 7.7 System | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: Windows | Difficulty: Easy (less than 1 hour) Type of failure: | Blocked By: None/Unknown | Related Tickets: Test Case: | Blocking: | -------------------------------+------------------------------------------- Comment (by leroux): This patch does away with some compatibility in the fact that if {{{sync- all}}} ever changes its scripting language, this file will have to be altered. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8283#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#8283: utils/fingerprint/fingerprint.py doesn't work on Windows -------------------------------+------------------------------------------- Reporter: schyler | Owner: Type: bug | Status: patch Priority: normal | Milestone: Component: Build | Version: 7.7 System | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: Windows | Difficulty: Easy (less than 1 hour) Type of failure: | Blocked By: None/Unknown | Related Tickets: Test Case: | Blocking: | -------------------------------+------------------------------------------- Changes (by leroux): * status: new => patch -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8283#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#8283: utils/fingerprint/fingerprint.py doesn't work on Windows -------------------------------+------------------------------------------- Reporter: schyler | Owner: Type: bug | Status: patch Priority: low | Milestone: Component: Build | Version: 7.7 System | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: Windows | Difficulty: Easy (less than 1 hour) Type of failure: Other | Blocked By: Test Case: | Related Tickets: Blocking: | -------------------------------+------------------------------------------- Changes (by leroux): * priority: normal => low * failure: None/Unknown => Other Comment: Just a few clarifications... The main problem is that shebangs won't work correctly under mingw by default since scripts usually invoke things like {{{#!/usr/bin/perl}}} whereas perl is actually located at {{{/mingw/msys/1.0/usr/bin/perl}}} or something similar. This can actually be remedied by making sure the mingw shell is mounting the correct directories with it's {{{/etc/fstab}}}...which is how it should be. For example, {{{mount}}} should output: {{{ /c/mingw /mingw /mingw/msys/1.0 / /mingw/msys/1.0 /usr }}} or something similar. An alternate solution to this is to maintain a Windows frequented problems/solutions. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8283#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#8283: utils/fingerprint/fingerprint.py doesn't work on Windows -------------------------------+------------------------------------------- Reporter: schyler | Owner: Type: bug | Status: patch Priority: low | Milestone: Component: Build | Version: 7.7 System | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: Windows | Difficulty: Easy (less than 1 hour) Type of failure: Other | Blocked By: Test Case: | Related Tickets: Blocking: | -------------------------------+------------------------------------------- Comment (by schyler): /usr/bin/perl exists for me, but the script still fails. I don't think changing your fstab will help. The patch '''does''' work for me though, whereas it would not before. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8283#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#8283: utils/fingerprint/fingerprint.py doesn't work on Windows -------------------------------+------------------------------------------- Reporter: schyler | Owner: leroux Type: bug | Status: patch Priority: low | Milestone: Component: Build | Version: 7.7 System | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: Windows | Difficulty: Easy (less than 1 hour) Type of failure: Other | Blocked By: Test Case: | Related Tickets: Blocking: | -------------------------------+------------------------------------------- Changes (by leroux): * owner: => leroux -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8283#comment:6> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#8283: utils/fingerprint/fingerprint.py doesn't work on Windows -------------------------------+------------------------------------------- Reporter: schyler | Owner: leroux Type: bug | Status: patch Priority: low | Milestone: Component: Build | Version: 7.7 System | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: Windows | Difficulty: Easy (less than 1 hour) Type of failure: Other | Blocked By: Test Case: | Related Tickets: Blocking: | -------------------------------+------------------------------------------- Comment (by Austin Seipp <austin@…>): In [changeset:70ccf23f7e2f67c395be4cb87c8f4a26dd65918d/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="70ccf23f7e2f67c395be4cb87c8f4a26dd65918d" fingerprint.py: Invoke 'perl' manually (#8283) This fixes the fingerprint script on windows, since we can't rely on using '#!/usr/bin/perl' Signed-off-by: Austin Seipp <austin@well-typed.com> }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8283#comment:7> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#8283: utils/fingerprint/fingerprint.py doesn't work on Windows -------------------------------+------------------------------------------- Reporter: schyler | Owner: leroux Type: bug | Status: closed Priority: low | Milestone: Component: Build | Version: 7.7 System | Keywords: Resolution: fixed | Architecture: Unknown/Multiple Operating System: Windows | Difficulty: Easy (less than 1 hour) Type of failure: Other | Blocked By: Test Case: | Related Tickets: Blocking: | -------------------------------+------------------------------------------- Changes (by thoughtpolice): * status: patch => closed * resolution: => fixed Comment: Merged, thanks! -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8283#comment:8> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC