[GHC] #13561: Remove unsafe Chan combinators
#13561: Remove unsafe Chan combinators -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: task | Status: new Priority: high | Milestone: 8.4.1 Component: Compiler | Version: 8.0.1 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: #4154 Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- Namely `isEmptyChan` and `unGetChan`. See #4154. Let's delete them for 8.4. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13561> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13561: Remove unsafe Chan combinators -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: task | Status: new Priority: high | Milestone: 8.4.1 Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #4154 | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by osa1): It seems like some of GHC's dependencies use those functions (e.g. `haskeline` uses `isEmptyChan`). -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13561#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13561: Remove unsafe Chan combinators -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: task | Status: new Priority: high | Milestone: 8.4.1 Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #4154 | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by bgamari): See https://github.com/judah/haskeline/pull/61/files for a fix for haskeline. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13561#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13561: Remove unsafe Chan combinators -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: task | Status: patch Priority: high | Milestone: 8.4.1 Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #4154 | Differential Rev(s): Phab:D4060 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => patch * differential: => Phab:D4060 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13561#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13561: Remove unsafe Chan combinators -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: task | Status: patch Priority: high | Milestone: 8.4.1 Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #4154 | Differential Rev(s): Phab:D4060 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"361af6280d7025ac3e24d79c209b465db6f231f8/ghc" 361af62/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="361af6280d7025ac3e24d79c209b465db6f231f8" base: Remove deprecated Chan combinators Removes isEmptyChan and unGetChan, which have been deprecated for a very long time. See #13561. Test Plan: Validate Reviewers: austin, hvr Subscribers: rwbarton, thomie GHC Trac Issues: #13561 Differential Revision: https://phabricator.haskell.org/D4060 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13561#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13561: Remove unsafe Chan combinators -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: task | Status: closed Priority: high | Milestone: 8.4.1 Component: Compiler | Version: 8.0.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #4154 | Differential Rev(s): Phab:D4060 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: patch => closed * resolution: => fixed -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13561#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC