#8276: Building Haddock documentation panics with perf build on x86_64 Linux ---------------------------------------+---------------------------------- Reporter: jstolarek | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Documentation | Version: 7.7 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: x86_64 (amd64) Type of failure: Compile-time crash | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: ---------------------------------------+---------------------------------- Description changed by jstolarek: Old description:

After setting `BuildFlavor = perf` in `build.mk` compilation ends with a panic:

{{{ "/home/luite/buildtest/ghc-clean-buildtest/ghc/inplace/bin/haddock" --odir="libraries/ghc-prim/dist-install/doc/html/ghc-prim" --no-tmp-comp- dir --dump-interface=libraries/ghc-prim/dist-install/doc/html/ghc-prim /ghc-prim.haddock --html --hoogle --title="ghc-prim-0.3.1.0: GHC primitives" --prologue="libraries/ghc-prim/dist-install/haddock- prologue.txt" --optghc=-hisuf --optghc=dyn_hi --optghc=-osuf --optghc=dyn_o --optghc=-hcsuf --optghc=dyn_hc --optghc=-fPIC --optghc=-dynamic --optghc=-H32m --optghc=-O --optghc=-package-name --optghc=ghc-prim-0.3.1.0 --optghc=-hide-all-packages --optghc=-i --optghc=-ilibraries/ghc-prim/. --optghc=-ilibraries/ghc-prim/dist- install/build --optghc=-ilibraries/ghc-prim/dist-install/build/autogen --optghc=-Ilibraries/ghc-prim/dist-install/build --optghc=-Ilibraries /ghc-prim/dist-install/build/autogen --optghc=-Ilibraries/ghc-prim/. --optghc=-optP-include --optghc=-optPlibraries/ghc-prim/dist- install/build/autogen/cabal_macros.h --optghc=-package --optghc=rts-1.0 --optghc=-package-name --optghc=ghc-prim --optghc=-XHaskell98 --optghc=-XCPP --optghc=-XMagicHash --optghc=-XForeignFunctionInterface --optghc=-XUnliftedFFITypes --optghc=-XUnboxedTuples --optghc=-XEmptyDataDecls --optghc=-XNoImplicitPrelude --optghc=-O2 --optghc=-no-user-package-db --optghc=-rtsopts --optghc=-odir --optghc=libraries/ghc-prim/dist-install/build --optghc=-hidir --optghc=libraries/ghc-prim/dist-install/build --optghc=-stubdir --optghc=libraries/ghc-prim/dist-install/build --source- module=src/%{MODULE/./-}.html --source- entity=src/%{MODULE/./-}.html#%{NAME} libraries/ghc- prim/./GHC/Classes.hs libraries/ghc-prim/./GHC/CString.hs libraries /ghc-prim/./GHC/Debug.hs libraries/ghc-prim/./GHC/Magic.hs libraries /ghc-prim/dist-install/build/GHC/PrimopWrappers.hs libraries/ghc- prim/./GHC/PrimWrappers.hs libraries/ghc-prim/./GHC/IntWord64.hs libraries/ghc-prim/./GHC/Tuple.hs libraries/ghc-prim/./GHC/Types.hs libraries/ghc-prim/dist-install/build/autogen/GHC/Prim.hs +RTS -tlibraries/ghc-prim/dist-install/doc/html/ghc-prim/ghc-prim.haddock.t --machine-readable Haddock coverage: 100% ( 1 / 1) in 'GHC.IntWord64' 78% ( 7 / 9) in 'GHC.Types' 3% ( 2 / 63) in 'GHC.Tuple' 0% ( 0 / 3) in 'GHC.Debug' 0% ( 0 /351) in 'GHC.PrimopWrappers' 2% ( 1 / 43) in 'GHC.PrimWrappers' 17% ( 1 / 6) in 'GHC.CString' 31% (170 /540) in 'GHC.Prim' 100% ( 3 / 3) in 'GHC.Magic' 38% ( 6 / 16) in 'GHC.Classes' haddock: internal error: haddock: panic! (the 'impossible' happened) (GHC version 7.7.20130912 for x86_64-unknown-linux): Static flags have not been initialised! Please call GHC.newSession or GHC.parseStaticFlags early enough.

Please report this as a GHC bug: http://www.haskell.org/ghc/reportabug

make[1]: *** [libraries/ghc-prim/dist-install/doc/html/ghc-prim/ghc- prim.haddock] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [all] Error 2 }}}

I've seen this problem before, but I thought that it was related to my patch. Now I got it on master branch and Luite reported the same problem on #ghc (log above is actually his).

A workaround for this is disabling building of dicumentation in "perf" section of `build.mk`.

New description: After setting `BuildFlavor = perf` in `build.mk` compilation ends with a panic: {{{ "/home/luite/buildtest/ghc-clean-buildtest/ghc/inplace/bin/haddock" --odir="libraries/ghc-prim/dist-install/doc/html/ghc-prim" --no-tmp-comp- dir --dump-interface=libraries/ghc-prim/dist-install/doc/html/ghc-prim /ghc-prim.haddock --html --hoogle --title="ghc-prim-0.3.1.0: GHC primitives" --prologue="libraries/ghc-prim/dist-install/haddock- prologue.txt" --optghc=-hisuf --optghc=dyn_hi --optghc=-osuf --optghc=dyn_o --optghc=-hcsuf --optghc=dyn_hc --optghc=-fPIC --optghc=-dynamic --optghc=-H32m --optghc=-O --optghc=-package-name --optghc=ghc-prim-0.3.1.0 --optghc=-hide-all-packages --optghc=-i --optghc=-ilibraries/ghc-prim/. --optghc=-ilibraries/ghc-prim/dist- install/build --optghc=-ilibraries/ghc-prim/dist-install/build/autogen --optghc=-Ilibraries/ghc-prim/dist-install/build --optghc=-Ilibraries/ghc- prim/dist-install/build/autogen --optghc=-Ilibraries/ghc-prim/. --optghc =-optP-include --optghc=-optPlibraries/ghc-prim/dist- install/build/autogen/cabal_macros.h --optghc=-package --optghc=rts-1.0 --optghc=-package-name --optghc=ghc-prim --optghc=-XHaskell98 --optghc=-XCPP --optghc=-XMagicHash --optghc=-XForeignFunctionInterface --optghc=-XUnliftedFFITypes --optghc=-XUnboxedTuples --optghc=-XEmptyDataDecls --optghc=-XNoImplicitPrelude --optghc=-O2 --optghc=-no-user-package-db --optghc=-rtsopts --optghc=-odir --optghc=libraries/ghc-prim/dist-install/build --optghc=-hidir --optghc=libraries/ghc-prim/dist-install/build --optghc=-stubdir --optghc=libraries/ghc-prim/dist-install/build --source- module=src/%{MODULE/./-}.html --source- entity=src/%{MODULE/./-}.html#%{NAME} libraries/ghc- prim/./GHC/Classes.hs libraries/ghc-prim/./GHC/CString.hs libraries/ghc- prim/./GHC/Debug.hs libraries/ghc-prim/./GHC/Magic.hs libraries/ghc-prim /dist-install/build/GHC/PrimopWrappers.hs libraries/ghc- prim/./GHC/PrimWrappers.hs libraries/ghc-prim/./GHC/IntWord64.hs libraries/ghc-prim/./GHC/Tuple.hs libraries/ghc-prim/./GHC/Types.hs libraries/ghc-prim/dist-install/build/autogen/GHC/Prim.hs +RTS -tlibraries /ghc-prim/dist-install/doc/html/ghc-prim/ghc-prim.haddock.t --machine- readable Haddock coverage: 100% ( 1 / 1) in 'GHC.IntWord64' 78% ( 7 / 9) in 'GHC.Types' 3% ( 2 / 63) in 'GHC.Tuple' 0% ( 0 / 3) in 'GHC.Debug' 0% ( 0 /351) in 'GHC.PrimopWrappers' 2% ( 1 / 43) in 'GHC.PrimWrappers' 17% ( 1 / 6) in 'GHC.CString' 31% (170 /540) in 'GHC.Prim' 100% ( 3 / 3) in 'GHC.Magic' 38% ( 6 / 16) in 'GHC.Classes' haddock: internal error: haddock: panic! (the 'impossible' happened) (GHC version 7.7.20130912 for x86_64-unknown-linux): Static flags have not been initialised! Please call GHC.newSession or GHC.parseStaticFlags early enough. Please report this as a GHC bug: http://www.haskell.org/ghc/reportabug make[1]: *** [libraries/ghc-prim/dist-install/doc/html/ghc-prim/ghc- prim.haddock] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [all] Error 2 }}} I've seen this problem before, but I thought that it was related to my patch. Now I got it on master branch and Luite reported the same problem on #ghc (log above is actually his). A workaround for this is disabling building of documentation in "perf" section of `build.mk`. -- -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8276#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8276: Building Haddock documentation panics with perf build on x86_64 Linux ---------------------------------------+---------------------------------- Reporter: jstolarek | Owner: Type: bug | Status: new Priority: high | Milestone: Component: Documentation | Version: 7.7 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: x86_64 (amd64) Type of failure: Compile-time crash | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: ---------------------------------------+---------------------------------- Changes (by bos): * priority: normal => high -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8276#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8276: Building Haddock documentation panics with perf build on x86_64 Linux ---------------------------------------+---------------------------------- Reporter: jstolarek | Owner: Type: bug | Status: new Priority: high | Milestone: Component: Documentation | Version: 7.7 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: x86_64 (amd64) Type of failure: Compile-time crash | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: ---------------------------------------+---------------------------------- Changes (by kazu-yamamoto): * cc: kazu@… (added) -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8276#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8276: Building Haddock documentation panics with perf build on x86_64 Linux ---------------------------------------+---------------------------------- Reporter: jstolarek | Owner: Type: bug | Status: new Priority: high | Milestone: Component: Documentation | Version: 7.7 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: x86_64 (amd64) Type of failure: Compile-time crash | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: ---------------------------------------+---------------------------------- Comment (by SimonHengel): To be precise with static flags I mean {{{v_opt_C}}} and {{{v_opt_C_ready}}}. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8276#comment:7 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8276: Building Haddock documentation panics with perf build on x86_64 Linux ---------------------------------------+---------------------------------- Reporter: jstolarek | Owner: Type: bug | Status: new Priority: high | Milestone: Component: Documentation | Version: 7.7 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: x86_64 (amd64) Type of failure: Compile-time crash | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: ---------------------------------------+---------------------------------- Comment (by kazu-yamamoto): I guess that a7f9930a24a91cfb5e2579867e5a0b1d83b5a947 by jstolarek introduced this bug. Since I cannot revert this patch due to the changes after this patch, I could not verify yet. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8276#comment:9 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8276: Building Haddock documentation panics with perf build on x86_64 Linux ---------------------------------------+---------------------------------- Reporter: jstolarek | Owner: Type: bug | Status: new Priority: high | Milestone: Component: Documentation | Version: 7.7 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: x86_64 (amd64) Type of failure: Compile-time crash | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: ---------------------------------------+---------------------------------- Changes (by jstolarek): * cc: jan.stolarek@… (added) Comment: How interesting that most bugs that hit me are the ones I myself introduced. Unfortunately at the moment I don't have time to look into this, because I'm fixing profiling (also broken by me). I wouldn't go with any hacky solutions here - we just need to figure out what is exactly going on and fix it properly. It would be good to have a small test case for this. I think this might be a good recipe: https://github.com/sol /doctest-haskell/pull/60#issuecomment-24287554 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8276#comment:11 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8276: Building Haddock documentation panics with perf build on x86_64 Linux ---------------------------------------+---------------------------------- Reporter: jstolarek | Owner: Type: bug | Status: new Priority: high | Milestone: Component: Documentation | Version: 7.7 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: x86_64 (amd64) Type of failure: Compile-time crash | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: ---------------------------------------+---------------------------------- Comment (by jstolarek): Yes, I also think that the fix should be done in GHC. Kazu, I think that code posted by you in the comment I linked will make a perfect testcase for this bug (provided it is correct). -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8276#comment:13 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8276: Building Haddock documentation panics with perf build on x86_64 Linux ---------------------------------------+---------------------------------- Reporter: jstolarek | Owner: Type: bug | Status: new Priority: high | Milestone: Component: Documentation | Version: 7.7 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: x86_64 (amd64) Type of failure: Compile-time crash | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: ---------------------------------------+---------------------------------- Comment (by darchon): The problem is that pretty-printing (code in `Outputable.hs`) an error tries to access the staticFlag "-dppr-debug". For some weird reason, the staticFlags are not parsed when the error message is converted to a String; that's the reason for this bug. The error that it is trying to print is #8320, but I don't think the error would only show up for that particular failure. What my patch does is not revert static flags to their unparsed state in the exception handling code of haddock. It makes this particular error go away, but it is not a proper fix. I find it weird that the exception handler can unparse the static flags before the error is converted to a string. Perhaps there is a way to force the error to printed before the staticFlags are unparsed? Also I want to point out that this bug, and the problem reported in https://github.com/sol/doctest-haskell/issues/59, are each others inverse: where the conflicting code in this bug expects staticFlags to be parsed, "kazu's" code expects the staticFlags not to be parsed yet. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8276#comment:15 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8276: Building Haddock documentation panics with perf build on x86_64 Linux ---------------------------------------+---------------------------------- Reporter: jstolarek | Owner: Type: bug | Status: new Priority: high | Milestone: Component: Documentation | Version: 7.7 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: x86_64 (amd64) Type of failure: Compile-time crash | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: ---------------------------------------+---------------------------------- Comment (by kazu-yamamoto): Does anyone know the reason why the initial value of v_opt_C_ready in GHCi change? For GHCi 7.6.3: {{{ % ghci -package ghc

import StaticFlags (v_opt_C_ready) import Data.IORef readIORef v_opt_C_ready False }}}

For GHCi head: {{{ % ghci -package ghc

import StaticFlags (v_opt_C_ready) import Data.IORef readIORef v_opt_C_ready True }}}

I don't understand why this value can stay False in GHCi 7.6.3. And I don't know which commit changed the behavior. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8276#comment:17 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8276: Building Haddock documentation panics with perf build on x86_64 Linux ---------------------------------------+---------------------------------- Reporter: jstolarek | Owner: Type: bug | Status: new Priority: high | Milestone: Component: Documentation | Version: 7.7 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: x86_64 (amd64) Type of failure: Compile-time crash | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: ---------------------------------------+---------------------------------- Comment (by krakrjak): Replying to [comment:16 darchon]:

A "better" patch for haddock can be found here: https://gist.github.com/christiaanb/6687503

This "better" patch does not fix ghc compilation for me when applied. It moves the ball forward, but gives a different error instead. {{{ Haddock coverage: 100% ( 1 / 1) in 'GHC.IntWord64' 80% ( 8 / 10) in 'GHC.Types' 17% ( 1 / 6) in 'GHC.CString' 3% ( 2 / 63) in 'GHC.Tuple' 0% ( 0 / 3) in 'GHC.Debug' 0% ( 0 /354) in 'GHC.PrimopWrappers' 72% (813 /1123) in 'GHC.Prim' 100% ( 3 / 3) in 'GHC.Magic' 38% ( 6 / 16) in 'GHC.Classes' attempting to use module ‛ghc-prim:GHC.Types’ (libraries/ghc- prim/./GHC/Types.hs) which is not loaded make[1]: *** [libraries/ghc-prim/dist-install/doc/html/ghc-prim/ghc- prim.haddock] Error 1 make: *** [all] Error 2 }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8276#comment:19 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8276: Building Haddock documentation panics with perf build on x86_64 Linux ---------------------------------------+---------------------------------- Reporter: jstolarek | Owner: Type: bug | Status: new Priority: high | Milestone: Component: Documentation | Version: 7.7 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: x86_64 (amd64) Type of failure: Compile-time crash | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: ---------------------------------------+---------------------------------- Comment (by SimonHengel): The {{{saveStaticFlagGlobals}}}/{{{restoreStaticFlagGlobals}}} was added by me 1 1/2 years ago, so that you can run {{{createInterfaces}}} several times within the same process. The motivation for this was to be able to run Doctests test suite from GHCi and rerun after {{{:reload}}}. Doctest is not depending on Haddock anymore, but we now have similar code in Doctest (https://github.com/sol/doctest- haskell/blob/master/src/GhcUtil.hs). -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8276#comment:21 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8276: Building Haddock documentation panics with perf build on x86_64 Linux ---------------------------------------+---------------------------------- Reporter: jstolarek | Owner: Type: bug | Status: new Priority: high | Milestone: Component: Documentation | Version: 7.7 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: x86_64 (amd64) Type of failure: Compile-time crash | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: ---------------------------------------+---------------------------------- Changes (by AndreasVoellmy): * cc: andreas.voellmy@… (added) -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8276#comment:23 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8276: Building Haddock documentation panics with perf build on x86_64 Linux ---------------------------------------+---------------------------------- Reporter: jstolarek | Owner: Type: bug | Status: new Priority: high | Milestone: Component: Documentation | Version: 7.7 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: x86_64 (amd64) Type of failure: Compile-time crash | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: ---------------------------------------+---------------------------------- Changes (by tibbe): * cc: johan.tibell@… (added) -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8276#comment:25 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8276: Building Haddock documentation panics with perf build on x86_64 Linux ---------------------------------------+---------------------------------- Reporter: jstolarek | Owner: Type: bug | Status: new Priority: high | Milestone: Component: Documentation | Version: 7.7 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: x86_64 (amd64) Type of failure: Compile-time crash | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: ---------------------------------------+---------------------------------- Comment (by kazu-yamamoto): Compiling test.hs with dynamic linking results in False. Strange. {{{ % ghc -O2 -package ghc test.hs -fforce-recomp % ./test False % ghc -O2 -dynamic -package ghc test.hs -fforce-recomp % ./test False }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8276#comment:27 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8276: Building Haddock documentation panics with perf build on x86_64 Linux ---------------------------------------+---------------------------------- Reporter: jstolarek | Owner: thoughtpolice Type: bug | Status: new Priority: highest | Milestone: 7.8.1 Component: Documentation | Version: 7.7 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: x86_64 (amd64) Type of failure: Compile-time crash | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: ---------------------------------------+---------------------------------- Comment (by SimonHengel): Here is some (very simplified!) code from Doctest. In Haddock we have something similar. {{{ parse :: [String] -> IO [TypecheckedModule] parse args = bracket saveStaticFlagGlobals restoreStaticFlagGlobals $ \_ -> do args_ <- fst <$> parseStaticFlags (map noLoc args) runGhc (Just libdir) $ do (dynflags, files, _) <- getSessionDynFlags >>= (`parseDynamicFlags` args_) _ <- setSessionDynFlags dynflags mapM (`guessTarget` Nothing) (map unLoc files) >>= setTargets mods <- depanal [] False let sortedMods = flattenSCCs (topSortModuleGraph False mods Nothing) mapM (parseModule >=> typecheckModule >=> loadModule) sortedMods }}} (both Doctest and Haddock accept arbitrary GHC flags) If we can safely ignore static flags altogether, and change this to {{{ parse :: [String] -> IO [TypecheckedModule] parse args = runGhc (Just libdir) $ do (dynflags, files, _) <- getSessionDynFlags >>= (`parseDynamicFlags` map noLoc args) _ <- setSessionDynFlags dynflags mapM (`guessTarget` Nothing) (map unLoc files) >>= setTargets mods <- depanal [] False let sortedMods = flattenSCCs (topSortModuleGraph False mods Nothing) mapM (parseModule >=> typecheckModule >=> loadModule) sortedMods }}} then I have no need for {{{saveStaticFlagGlobals}}}/{{{restoreStaticFlagGlobals}}} anymore. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8276#comment:29 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8276: Building Haddock documentation panics with perf build on x86_64 Linux ---------------------------------------+---------------------------------- Reporter: jstolarek | Owner: thoughtpolice Type: bug | Status: new Priority: highest | Milestone: 7.8.1 Component: Documentation | Version: 7.7 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: x86_64 (amd64) Type of failure: Compile-time crash | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: ---------------------------------------+---------------------------------- Changes (by JohnWiegley): * cc: johnw@… (added) -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8276#comment:31 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8276: Building Haddock documentation panics with perf build on x86_64 Linux ---------------------------------------+---------------------------------- Reporter: jstolarek | Owner: thoughtpolice Type: bug | Status: new Priority: highest | Milestone: 7.8.1 Component: Documentation | Version: 7.7 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: x86_64 (amd64) Type of failure: Compile-time crash | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: ---------------------------------------+---------------------------------- Comment (by SimonHengel): Austin, do you think what I proposed for the Haddock side of things is the way to go? I'm still puzzled what triggered the issue. A couple of weeks ago the documentation still build for me. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8276#comment:33 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8276: Building Haddock documentation panics with perf build on x86_64 Linux ---------------------------------------+---------------------------------- Reporter: jstolarek | Owner: thoughtpolice Type: bug | Status: new Priority: highest | Milestone: 7.8.1 Component: Documentation | Version: 7.7 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: x86_64 (amd64) Type of failure: Compile-time crash | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: ---------------------------------------+---------------------------------- Comment (by thoughtpolice): And I double checked Cabal - none of the remaining static flags are passed to GHC. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8276#comment:35 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8276: Building Haddock documentation panics with perf build on x86_64 Linux ---------------------------------------+---------------------------------- Reporter: jstolarek | Owner: thoughtpolice Type: bug | Status: new Priority: highest | Milestone: 7.8.1 Component: Documentation | Version: 7.7 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: x86_64 (amd64) Type of failure: Compile-time crash | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: ---------------------------------------+---------------------------------- Comment (by SimonHengel): If we can add a function {{{ discardStaticFlags :: [String] -> [String] }}} that removes static (including any arguments given to them, if any, not sure if there are static flags that take arguments) to the GHC API, then I'm fine with ignoring them in Haddock/Doctest. Medium term it would still be nice to get rid of static flags completely, of course. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8276#comment:37 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8276: Building Haddock documentation panics with perf build on x86_64 Linux ---------------------------------------+---------------------------------- Reporter: jstolarek | Owner: thoughtpolice Type: bug | Status: new Priority: highest | Milestone: 7.8.1 Component: Documentation | Version: 7.7 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: x86_64 (amd64) Type of failure: Compile-time crash | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: ---------------------------------------+---------------------------------- Comment (by Austin Seipp ): In [changeset:"16c401137a0d2aa803a5806493889056538c2de4/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="16c401137a0d2aa803a5806493889056538c2de4" Nuke {save,restore}StaticFlagGlobals. As discussed in #8276, this code was somewhat broken because while you could always revert the actual argument list, you can never revert the CAFs upon which they are based - so really this didn't buy you much. However, Haddock in particular expects to be able to parse GHC flags, including static flags, and used this code to do so. In its place, we instead have discardStaticFlags, which will safely remove any of the remaining 5 flags from a list of arguments. Haddock instead discards these, as they aren't related to anything it does anyway (mostly controlling debugging output and some basic optimizer phases.) This fixes #8276. In the future, we will eventually completely remove the remaining StaticFlags, removing the need for this fix. Unfortunately these changes will be quite invasive and require more time. Signed-off-by: Austin Seipp }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8276#comment:39 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8276: Building Haddock documentation panics with perf build on x86_64 Linux ---------------------------------------+---------------------------------- Reporter: jstolarek | Owner: thoughtpolice Type: bug | Status: new Priority: highest | Milestone: 7.8.1 Component: Documentation | Version: 7.7 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: x86_64 (amd64) Type of failure: Compile-time crash | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: ---------------------------------------+---------------------------------- Comment (by SimonHengel): Looks good to me. :) -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8276#comment:41 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8276: Building Haddock documentation panics with perf build on x86_64 Linux ---------------------------------------+---------------------------------- Reporter: jstolarek | Owner: thoughtpolice Type: bug | Status: closed Priority: highest | Milestone: 7.8.1 Component: Documentation | Version: 7.7 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: x86_64 (amd64) Type of failure: Compile-time crash | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: ---------------------------------------+---------------------------------- Comment (by RyanGlScott): I still experience this panic on GHC 7.8.2 with Windows x86_64: {{{ $ ghci GHCi, version 7.8.2: http://www.haskell.org/ghc/ :? for help Loading package ghc-prim ... linking ... done. Loading package integer-gmp ... linking ... done. Loading package base ... linking ... done. λ> import StaticFlags λ> import Data.IORef λ> readIORef v_opt_C_ready Loading package array-0.5.0.0 ... linking ... done. Loading package deepseq-1.3.0.2 ... linking ... done. Loading package bytestring-0.10.4.0 ... linking ... done. Loading package containers-0.5.5.1 ... linking ... done. Loading package Win32-2.3.0.2 ... linking ... done. Loading package filepath-1.3.0.2 ... linking ... done. Loading package old-locale-1.0.0.6 ... linking ... done. Loading package time-1.4.2 ... linking ... done. Loading package directory-1.2.1.0 ... linking ... done. Loading package pretty-1.1.1.1 ... linking ... done. Loading package process-1.2.0.0 ... linking ... done. Loading package Cabal-1.18.1.3 ... linking ... done. Loading package binary-0.7.1.0 ... linking ... done. Loading package bin-package-db-0.0.0.0 ... linking ... done. Loading package hoopl-3.10.0.1 ... linking ... done. Loading package hpc-0.6.0.1 ... linking ... done. Loading package template-haskell ... linking ... done. Loading package transformers-0.3.0.0 ... linking ... done. Loading package ghc-7.8.2 ... linking ... done. False λ> staticFlags ghc.exe: panic! (the 'impossible' happened) (GHC version 7.8.2 for x86_64-unknown-mingw32): Static flags have not been initialised! Please call GHC.parseStaticFlags early enough. Please report this as a GHC bug: http://www.haskell.org/ghc/reportabug }}} But not with GHC 7.8.2 on Linux x86_64: {{{ $ ghci GHCi, version 7.8.2: http://www.haskell.org/ghc/ :? for help Loading package ghc-prim ... linking ... done. Loading package integer-gmp ... linking ... done. Loading package base ... linking ... done. λ> import StaticFlags λ> import Data.IORef λ> readIORef v_opt_C_ready Loading package array-0.5.0.0 ... linking ... done. Loading package deepseq-1.3.0.2 ... linking ... done. Loading package bytestring-0.10.4.0 ... linking ... done. Loading package containers-0.5.5.1 ... linking ... done. Loading package filepath-1.3.0.2 ... linking ... done. Loading package old-locale-1.0.0.6 ... linking ... done. Loading package time-1.4.2 ... linking ... done. Loading package directory-1.2.1.0 ... linking ... done. Loading package pretty-1.1.1.1 ... linking ... done. Loading package process-1.2.0.0 ... linking ... done. Loading package Cabal-1.18.1.3 ... linking ... done. Loading package binary-0.7.1.0 ... linking ... done. Loading package bin-package-db-0.0.0.0 ... linking ... done. Loading package hoopl-3.10.0.1 ... linking ... done. Loading package hpc-0.6.0.1 ... linking ... done. Loading package template-haskell ... linking ... done. Loading package transformers-0.3.0.0 ... linking ... done. Loading package ghc-7.8.2 ... linking ... done. True λ> staticFlags [] }}} This has caused problems for me when running programs such as [https://github.com/ku-fpg/hermit/ HERMIT] on Windows, since at some point, {{{parseStaticFlagsFull}}} seems to be called during program execution. A workaround is to call {{{initStaticOpts}}} manually somewhere in the program, but I feel like that shouldn't be necessary. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8276#comment:43 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8276: Building Haddock documentation panics with perf build on x86_64 Linux ---------------------------------------+---------------------------------- Reporter: jstolarek | Owner: Type: bug | Status: new Priority: highest | Milestone: 7.8.1 Component: Documentation | Version: 7.7 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: x86_64 (amd64) Type of failure: Compile-time crash | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: ---------------------------------------+---------------------------------- Comment (by RyanGlScott): Here is a minimal plugin example which triggers the error (the full code is [https://github.com/RyanGlScott/ghc-plugin-test here]): {{{ module TestPlugin (plugin) where import CoreMonad import GhcPlugins import HscTypes import Outputable plugin :: Plugin plugin = defaultPlugin { installCoreToDos = install } install :: [CommandLineOption] -> [CoreToDo] -> CoreM [CoreToDo] install _ todo = do reinitializeGlobals putMsgS "Hello!" return $ CoreDoPluginPass "Say module name" pass : todo pass :: ModGuts -> CoreM ModGuts pass guts = do dflags <- getDynFlags putMsgS "Will this crash on Windows?" putMsgS $ showPpr dflags (mg_module guts) putMsgS "Nope" return guts }}} Here is the output: {{{ $ ghc Main.hs -fplugin=TestPlugin [1 of 1] Compiling Main ( Main.hs, Main.o ) [TestPlugin changed] Loading package ghc-prim ... linking ... done. Loading package integer-gmp ... linking ... done. Loading package base ... linking ... done. Loading package array-0.5.0.0 ... linking ... done. Loading package deepseq-1.3.0.2 ... linking ... done. Loading package bytestring-0.10.4.0 ... linking ... done. Loading package containers-0.5.5.1 ... linking ... done. Loading package Win32-2.3.0.2 ... linking ... done. Loading package filepath-1.3.0.2 ... linking ... done. Loading package old-locale-1.0.0.6 ... linking ... done. Loading package time-1.4.2 ... linking ... done. Loading package directory-1.2.1.0 ... linking ... done. Loading package pretty-1.1.1.1 ... linking ... done. Loading package process-1.2.0.0 ... linking ... done. Loading package Cabal-1.18.1.3 ... linking ... done. Loading package binary-0.7.1.0 ... linking ... done. Loading package bin-package-db-0.0.0.0 ... linking ... done. Loading package hoopl-3.10.0.1 ... linking ... done. Loading package hpc-0.6.0.1 ... linking ... done. Loading package template-haskell ... linking ... done. Loading package transformers-0.3.0.0 ... linking ... done. Loading package ghc-7.8.2 ... linking ... done. Loading package ghc-plugin-test-0.1.0.0 ... linking ... done. Hello! Will this crash on Windows? ghc.exe: panic! (the 'impossible' happened) (GHC version 7.8.2 for x86_64-unknown-mingw32): Static flags have not been initialised! Please call GHC.parseStaticFlags early enough. Please report this as a GHC bug: http://www.haskell.org/ghc/reportabug }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8276#comment:45 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8276: Building Haddock documentation panics with perf build on x86_64 Linux ---------------------------------------+---------------------------------- Reporter: jstolarek | Owner: Type: bug | Status: new Priority: high | Milestone: 7.8.4 Component: Documentation | Version: 7.7 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: x86_64 (amd64) Type of failure: Compile-time crash | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: ---------------------------------------+---------------------------------- Changes (by thoughtpolice): * priority: highest => high * milestone: 7.8.1 => 7.8.4 Comment: Thanks, moving to 7.8.4. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8276#comment:47 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8276: Building Haddock documentation panics with perf build on x86_64 Linux -------------------------------------+------------------------------------- Reporter: jstolarek | Owner: Type: bug | thoughtpolice Priority: high | Status: new Component: Documentation | Milestone: 7.10.2 Resolution: | Version: 7.7 Operating System: Unknown/Multiple | Keywords: Type of failure: Compile-time | Architecture: x86_64 crash | (amd64) Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by mjmrotek): Hello, A similar panic also happens when running Liquid Haskell [http://goto.ucsd.edu/~rjhala/liquid/haskell/blog/about/] on a file that uses the Units of Measure plugin [https://github.com/adamgundry/uom- plugin] {{{ liquid: liquid: panic! (the 'impossible' happened) (GHC version 7.10.1 for x86_64-unknown-linux): Static flags have not been initialised! Please call GHC.parseStaticFlags early enough. }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8276#comment:51 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler