[GHC] #12839: mmap functions not properly guarded by RTS_LINKER_USE_MMAP in Linker.c
#12839: mmap functions not properly guarded by RTS_LINKER_USE_MMAP in Linker.c -------------------------------------+------------------------------------- Reporter: shlevy | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Runtime | Version: 8.1 System (Linker) | Keywords: | Operating System: Other Architecture: | Type of failure: Compile-time Unknown/Multiple | crash or panic Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- A few uses of munmap etc. are inside of C conditional statements (e.g. `if (RTS_LINKER_USE_MMAP && oc->imageMapped)`) instead of CPP conditional statements, causing compilation failure on systems that don't use MMAP -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12839> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12839: mmap functions not properly guarded by RTS_LINKER_USE_MMAP in Linker.c -------------------------------------+------------------------------------- Reporter: shlevy | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Runtime System | Version: 8.1 (Linker) | Resolution: | Keywords: Operating System: Other | Architecture: Type of failure: Compile-time | Unknown/Multiple crash or panic | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by shlevy): Patch already ready, just combining it with a few other build fixes and will push all at once. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12839#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12839: mmap functions not properly guarded by RTS_LINKER_USE_MMAP in Linker.c -------------------------------------+------------------------------------- Reporter: shlevy | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Runtime System | Version: 8.1 (Linker) | Resolution: | Keywords: Operating System: Other | Architecture: Type of failure: Compile-time | Unknown/Multiple crash or panic | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"a637eeb7a1852adfd99b06d2c0a3496e4f238a0c/ghc" a637eeb7/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="a637eeb7a1852adfd99b06d2c0a3496e4f238a0c" Don't use mmap symbols when !RTS_LINKER_USE_MMAP Some usages of symbols from sys/mman.h are guarded by RTS_LINKER_USE_MMAP by C conditionals, not CPP conditionals. Since those branches are dead anyway when !RTS_LINKER_USE_MMAP, we just stub out the relevant symbols rather than increasing CPP branching. Fixes #12839. Reviewers: simonmar, austin, bgamari, erikd Reviewed By: simonmar, bgamari, erikd Subscribers: thomie Differential Revision: https://phabricator.haskell.org/D2710 GHC Trac Issues: #12839 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12839#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12839: mmap functions not properly guarded by RTS_LINKER_USE_MMAP in Linker.c -------------------------------------+------------------------------------- Reporter: shlevy | Owner: Type: bug | Status: closed Priority: normal | Milestone: 8.2.1 Component: Runtime System | Version: 8.1 (Linker) | Resolution: fixed | Keywords: Operating System: Other | Architecture: Type of failure: Compile-time | Unknown/Multiple crash or panic | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => closed * resolution: => fixed * milestone: => 8.2.1 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12839#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC