[GHC] #10239: Fragile CPP test for big endian in T7600
#10239: Fragile CPP test for big endian in T7600 -------------------------------------+------------------------------------- Reporter: trommler | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Test Suite | Version: 7.10.1 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: Other Unknown/Multiple | Blocked By: Test Case: T7600 | Related Tickets: Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- In test T7600 the C pre-processor test for big endian is broken in older versions of glibc. I have a patch that replaces the fragile CPP test with an integer read, which will always be the correct endianness. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10239 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#10239: Fragile CPP test for big endian in T7600 -------------------------------------+------------------------------------- Reporter: trommler | Owner: trommler Type: bug | Status: new Priority: normal | Milestone: Component: Test Suite | Version: 7.10.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Other | Unknown/Multiple Blocked By: | Test Case: T7600 Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Changes (by trommler): * owner: => trommler -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10239#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#10239: Fragile CPP test for big endian in T7600 -------------------------------------+------------------------------------- Reporter: trommler | Owner: trommler Type: bug | Status: new Priority: normal | Milestone: Component: Test Suite | Version: 7.10.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Other | Unknown/Multiple Blocked By: | Test Case: T7600 Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by trommler): This is fixed in HEAD. The fix is to include `ghcconfig.h`, which defines the appropriate macro. I'll submit my patch anyway and we can discuss it in Phabricator. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10239#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#10239: Fragile CPP test for big endian in T7600 -------------------------------------+------------------------------------- Reporter: trommler | Owner: trommler Type: bug | Status: patch Priority: normal | Milestone: Component: Test Suite | Version: 7.10.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Other | Unknown/Multiple Blocked By: | Test Case: T7600 Related Tickets: | Blocking: | Differential Revisions: Phab:D795 -------------------------------------+------------------------------------- Changes (by trommler): * status: new => patch * differential: => Phab:D795 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10239#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#10239: Fragile CPP test for big endian in T7600 -------------------------------------+------------------------------------- Reporter: trommler | Owner: trommler Type: bug | Status: patch Priority: normal | Milestone: Component: Test Suite | Version: 7.10.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Other | Unknown/Multiple Blocked By: | Test Case: T7600 Related Tickets: | Blocking: | Differential Revisions: Phab:D795 -------------------------------------+------------------------------------- Comment (by trommler): Replying to [ticket:10239 trommler]:
In test T7600 the C pre-processor test for big endian is broken in older versions of glibc. I tested HEAD on one machine and ghc-7.10 on the other and the machine with HEAD also had a newer glibc.
Karel had posted a fix in [changeset:3f30912fcceceea68b8ea6ada6c3135447c6871a] already that was not merged. My patch removes the need for CPP altogether. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10239#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#10239: Fragile CPP test for big endian in T7600
-------------------------------------+-------------------------------------
Reporter: trommler | Owner: trommler
Type: bug | Status: patch
Priority: normal | Milestone:
Component: Test Suite | Version: 7.10.1
Resolution: | Keywords:
Operating System: Unknown/Multiple | Architecture:
Type of failure: Other | Unknown/Multiple
Blocked By: | Test Case: T7600
Related Tickets: | Blocking:
| Differential Revisions: Phab:D795
-------------------------------------+-------------------------------------
Comment (by Austin Seipp
#10239: Fragile CPP test for big endian in T7600 -------------------------------------+------------------------------------- Reporter: trommler | Owner: trommler Type: bug | Status: closed Priority: normal | Milestone: 7.12.1 Component: Test Suite | Version: 7.10.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Other | Unknown/Multiple Blocked By: | Test Case: T7600 Related Tickets: | Blocking: | Differential Revisions: Phab:D795 -------------------------------------+------------------------------------- Changes (by thomie): * status: patch => closed * resolution: => fixed * milestone: => 7.12.1 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10239#comment:6 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC