[GHC] #14654: Nofib: Strip called without .exe extension resulting in errors.
#14654: Nofib: Strip called without .exe extension resulting in errors. -------------------------------------+------------------------------------- Reporter: AndreasK | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: NoFib | Version: 8.2.2 benchmark suite | Keywords: nofib, | Operating System: Windows windows | Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- {{{ ... ==nofib== bernouilli: size of Main.o follows... text data bss dec hex filename 8080 1632 0 9712 25f0 Main.o ==nofib== bernouilli: time to link bernouilli follows... <<ghc: 27269080 bytes, 11 GCs, 471856/801256 avg/max bytes residency (2 samples), 32M in use, 0.000 INIT (0.000 elapsed), 0.016 MUT (1.134 elapsed), 0.016 GC (0.015 elapsed) :ghc>> C:\ghc\msys64\mingw64\bin\strip.exe: 'bernouilli': No such file make[2]: *** [../../mk/target.mk:96: size] Error 1 make[2]: Target 'all' not remade because of errors. Finished making all in bernouilli: 0 ... }}} I assume strip looks for a file, not an executable. And as such requires the full name "foo.exe" instead of just "foo". Make sees this error and stops before the actual benchmark is run. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14654> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14654: Nofib: Strip called without .exe extension resulting in errors. -------------------------------------+------------------------------------- Reporter: AndreasK | Owner: AndreasK Type: bug | Status: new Priority: normal | Milestone: Component: NoFib benchmark | Version: 8.2.2 suite | Keywords: nofib, Resolution: | windows Operating System: Windows | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4297 Wiki Page: | -------------------------------------+------------------------------------- Changes (by AndreasK): * owner: (none) => AndreasK * differential: => Phab:D4297 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14654#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14654: Nofib: Strip called without .exe extension resulting in errors. -------------------------------------+------------------------------------- Reporter: AndreasK | Owner: AndreasK Type: bug | Status: patch Priority: normal | Milestone: Component: NoFib benchmark | Version: 8.2.2 suite | Keywords: nofib, Resolution: | windows Operating System: Windows | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4297 Wiki Page: | -------------------------------------+------------------------------------- Changes (by AndreasK): * status: new => patch -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14654#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14654: Nofib: Strip called without .exe extension resulting in errors. -------------------------------------+------------------------------------- Reporter: AndreasK | Owner: AndreasK Type: bug | Status: patch Priority: normal | Milestone: Component: NoFib benchmark | Version: 8.2.2 suite | Keywords: nofib, Resolution: | windows Operating System: Windows | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4297 Wiki Page: | -------------------------------------+------------------------------------- Comment (by bgamari): Thanks for the patch! -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14654#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14654: Nofib: Strip called without .exe extension resulting in errors. -------------------------------------+------------------------------------- Reporter: AndreasK | Owner: AndreasK Type: bug | Status: merge Priority: normal | Milestone: 8.4.1 Component: NoFib benchmark | Version: 8.2.2 suite | Keywords: nofib, Resolution: | windows Operating System: Windows | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4297 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: patch => merge * milestone: => 8.4.1 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14654#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14654: Nofib: Strip called without .exe extension resulting in errors. -------------------------------------+------------------------------------- Reporter: AndreasK | Owner: AndreasK Type: bug | Status: merge Priority: normal | Milestone: 8.6.1 Component: NoFib benchmark | Version: 8.2.2 suite | Keywords: nofib, Resolution: | windows Operating System: Windows | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4297 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Tamar Christina <tamar@…>): In [changeset:"1364fe623f9216108a285a8804a27bdd8dfea3c4/nofib" 1364fe6/nofib]: {{{ #!CommitTicketReference repository="nofib" revision="1364fe623f9216108a285a8804a27bdd8dfea3c4" Recognize shells reporting as MINGW under windows. Summary: My msys instance at least reports MINGW instead of MSYS for uname. This commit adjusts the regex to match either one. Without this some errors occur because of missing .exe extensions in file names. This fixes #14654 Test Plan: make Reviewers: O26 nofib, Phyx, bgamari Reviewed By: Phyx, bgamari Subscribers: bgamari, Phyx GHC Trac Issues: #14654 Differential Revision: https://phabricator.haskell.org/D4297 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14654#comment:6> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14654: Nofib: Strip called without .exe extension resulting in errors. -------------------------------------+------------------------------------- Reporter: AndreasK | Owner: AndreasK Type: bug | Status: closed Priority: normal | Milestone: 8.6.1 Component: NoFib benchmark | Version: 8.2.2 suite | Keywords: nofib, Resolution: fixed | windows Operating System: Windows | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4297 Wiki Page: | -------------------------------------+------------------------------------- Changes (by Phyx-): * status: merge => closed * resolution: => fixed -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14654#comment:7> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC