[GHC] #11777: RTS source code issues
#11777: RTS source code issues
-------------------------------------+-------------------------------------
Reporter: simonpj | Owner:
Type: bug | Status: new
Priority: normal | Milestone:
Component: Compiler | Version: 7.10.3
Keywords: | Operating System: Unknown/Multiple
Architecture: | Type of failure: None/Unknown
Unknown/Multiple |
Test Case: | Blocked By:
Blocking: | Related Tickets:
Differential Rev(s): | Wiki Page:
-------------------------------------+-------------------------------------
Tiago Silva
#11777: RTS source code issues
-------------------------------------+-------------------------------------
Reporter: simonpj | Owner:
Type: bug | Status: new
Priority: normal | Milestone:
Component: Compiler | Version: 7.10.3
Resolution: | Keywords:
Operating System: Unknown/Multiple | Architecture:
| Unknown/Multiple
Type of failure: None/Unknown | Test Case:
Blocked By: | Blocking:
Related Tickets: | Differential Rev(s):
Wiki Page: |
-------------------------------------+-------------------------------------
Comment (by Simon Marlow
#11777: RTS source code issues -------------------------------------+------------------------------------- Reporter: simonpj | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.10.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by bgamari): Regarding `RetainerSet.c`, perhaps we should trim down some of the retainer schemes? It looks like we currently use `RETAINER_SCHEME_CCS`. Is there anyone using the other two? -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11777#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11777: RTS source code issues -------------------------------------+------------------------------------- Reporter: simonpj | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.10.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by simonmar): No, I think it's all experimental code and probably doesn't work. Wouldn't hurt to delete it. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11777#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11777: RTS source code issues
-------------------------------------+-------------------------------------
Reporter: simonpj | Owner:
Type: bug | Status: new
Priority: normal | Milestone:
Component: Compiler | Version: 7.10.3
Resolution: | Keywords:
Operating System: Unknown/Multiple | Architecture:
| Unknown/Multiple
Type of failure: None/Unknown | Test Case:
Blocked By: | Blocking:
Related Tickets: | Differential Rev(s):
Wiki Page: |
-------------------------------------+-------------------------------------
Comment (by Ben Gamari
#11777: RTS source code issues
-------------------------------------+-------------------------------------
Reporter: simonpj | Owner:
Type: bug | Status: new
Priority: normal | Milestone:
Component: Runtime System | Version: 7.10.3
Resolution: | Keywords: newcomer
Operating System: Unknown/Multiple | Architecture:
| Unknown/Multiple
Type of failure: None/Unknown | Test Case:
Blocked By: | Blocking:
Related Tickets: | Differential Rev(s):
Wiki Page: |
-------------------------------------+-------------------------------------
Changes (by thomie):
* keywords: => newcomer
* cc: erikd (added)
* component: Compiler => Runtime System
@@ -2,1 +2,4 @@
- the C files used in GHC and noticed these issues:
+ the C files used in GHC and noticed these issues [edit: this list now
+ shows only those issues that haven't been fixed yet]:
+
+ * driver/utils/dynwrapper.c:
@@ -4,1 +7,4 @@
- /driver/utils/cwrapper.c : int main(int, char **);
+ int main(int argc, char *argv[]) {
+ void *p;
+ ...
+ }
@@ -6,0 +12,1 @@
+
@@ -9,0 +16,3 @@
+
+
+ * rts/RetainerSet.c:
@@ -10,7 +20,0 @@
- /rts/RetainerProfile.c : static nat sanityCheckHeapClosure(StgClosure *)
- }}}
- `StgInfoTable *info` has the same issue as above
-
- {{{
- /rts/RetainerSet.c
-
@@ -32,0 +35,1 @@
+ * rts/win32/IOManager.c:
@@ -33,14 +37,1 @@
- /rts/sm/MarkWeak.c : void markWeakPtrList (void);
-
- if (w->header.info == &stg_DEAD_WEAK_info) {
- last_w = &(w->link);
- } else {
- last_w = &(w->link);
- }
- }}}
- Not sure what's going on here. Regardless of the test the two branches do
- the same thing.
- {{{
-
- /rts/win32/IOManager.c : AddIORequest, AddDelayRequest, AddProcRequest
- functions
+ AddIORequest, AddDelayRequest, AddProcRequest functions
New description:
Tiago Silva
#11777: RTS source code issues -------------------------------------+------------------------------------- Reporter: simonpj | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Runtime System | Version: 7.10.3 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by erikd): I am in the process of cleaning up and generally improving the quality of the C code throughtout the RTS. At some point I intend to turn on more C compiler warning flags and that will undoubtedly turn up stuff like this. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11777#comment:6 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11777: RTS source code issues -------------------------------------+------------------------------------- Reporter: simonpj | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Runtime System | Version: 7.10.3 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by dobenour): erikd: any progress? -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11777#comment:7 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11777: RTS source code issues -------------------------------------+------------------------------------- Reporter: simonpj | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Runtime System | Version: 7.10.3 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by erikd): I've been really busy with a new job the last 6 months, so no progress by me personally on this issue. However there are at least 3 or 4 others currently working on cleaning up the RTS and they do seem t be making definite progress. There have been dozens of commits to the `rts/` part of the tree in the last 6 months and only a small number of them were for new features. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11777#comment:8 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11777: RTS source code issues -------------------------------------+------------------------------------- Reporter: simonpj | Owner: sjakobi Type: bug | Status: new Priority: normal | Milestone: Component: Runtime System | Version: 7.10.3 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4426, Wiki Page: | Phab:D4427, Phab:D4428 -------------------------------------+------------------------------------- Changes (by sjakobi): * owner: (none) => sjakobi * differential: => Phab:D4426, Phab:D4427, Phab:D4428 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11777#comment:9 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11777: RTS source code issues
-------------------------------------+-------------------------------------
Reporter: simonpj | Owner: sjakobi
Type: bug | Status: new
Priority: normal | Milestone:
Component: Runtime System | Version: 7.10.3
Resolution: | Keywords: newcomer
Operating System: Unknown/Multiple | Architecture:
| Unknown/Multiple
Type of failure: None/Unknown | Test Case:
Blocked By: | Blocking:
Related Tickets: | Differential Rev(s): Phab:D4426,
Wiki Page: | Phab:D4427, Phab:D4428
-------------------------------------+-------------------------------------
Comment (by Ben Gamari
#11777: RTS source code issues
-------------------------------------+-------------------------------------
Reporter: simonpj | Owner: sjakobi
Type: bug | Status: new
Priority: normal | Milestone:
Component: Runtime System | Version: 7.10.3
Resolution: | Keywords: newcomer
Operating System: Unknown/Multiple | Architecture:
| Unknown/Multiple
Type of failure: None/Unknown | Test Case:
Blocked By: | Blocking:
Related Tickets: | Differential Rev(s): Phab:D4426,
Wiki Page: | Phab:D4427, Phab:D4428
-------------------------------------+-------------------------------------
Comment (by Ben Gamari
#11777: RTS source code issues
-------------------------------------+-------------------------------------
Reporter: simonpj | Owner: sjakobi
Type: bug | Status: new
Priority: normal | Milestone:
Component: Runtime System | Version: 7.10.3
Resolution: | Keywords: newcomer
Operating System: Unknown/Multiple | Architecture:
| Unknown/Multiple
Type of failure: None/Unknown | Test Case:
Blocked By: | Blocking:
Related Tickets: | Differential Rev(s): Phab:D4426,
Wiki Page: | Phab:D4427, Phab:D4428
-------------------------------------+-------------------------------------
Comment (by Ben Gamari
#11777: RTS source code issues -------------------------------------+------------------------------------- Reporter: simonpj | Owner: sjakobi Type: bug | Status: closed Priority: normal | Milestone: 8.6.1 Component: Runtime System | Version: 7.10.3 Resolution: fixed | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4426, Wiki Page: | Phab:D4427, Phab:D4428 -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => closed * resolution: => fixed * milestone: => 8.6.1 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11777#comment:13 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC