#10511: Simplify some preprocessor expressions -------------------------------------+------------------------------------- Reporter: Berdes | Owner: Berdes Type: task | Status: patch Priority: low | Milestone: Component: Compiler | Version: 7.10.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: D981 -------------------------------------+------------------------------------- Changes (by Berdes): * status: new => patch * differential: => D981 Old description:

Some proprocessor expressions can be simplified. For exemple, when `_MSC_VER` is defined, `_WIN32` is also defined.

So `#if defined(_MSC_VER) || defined(_WIN32)` can be simplified to `#if defined(_WIN32)`.

New description: Some preprocessor expressions can be simplified. For exemple, when `_MSC_VER` is defined, `_WIN32` is also defined. So `#if defined(_MSC_VER) || defined(_WIN32)` can be simplified to `#if defined(_WIN32)`. -- -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10511#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#10511: Simplify some preprocessor expressions -------------------------------------+------------------------------------- Reporter: Berdes | Owner: Berdes Type: task | Status: closed Priority: low | Milestone: 7.10.2 Component: Compiler | Version: 7.10.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: D981 -------------------------------------+------------------------------------- Changes (by thomie): * status: patch => closed * resolution: => fixed * milestone: => 7.10.2 Comment: Thanks. Feel free to cleanup other things if you see them. First discuss if it would be a very large patch, since we prefer to do those only if they have significant benefit. The problem is that they make it more difficult to use 'git blame' effectively. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10511#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#10511: Simplify some preprocessor expressions -------------------------------------+------------------------------------- Reporter: Berdes | Owner: Berdes Type: task | Status: closed Priority: low | Milestone: 7.12.1 Component: Compiler | Version: 7.10.1 Resolution: fixed | Keywords: Operating System: Windows | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: Phab:D981 -------------------------------------+------------------------------------- Changes (by thomie): * milestone: 7.10.2 => 7.12.1 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10511#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler