#14236: Typeable App pattern doesn't match function types -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: new Priority: low | Milestone: 8.4.1 Component: Compiler | Version: 8.2.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2369 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * differential: => Phab:D2369 Old description:

Consider the type representation, {{{#!hs rep = typeRep @(Int -> Char) }}}

We would expect this to match the pattern, {{{#!hs (App (App arrowRep intRep) charRep) }}}

However, this is currently not the case. Fix this.

New description: Consider the type representation, {{{#!hs rep = typeRep @(Int -> Char) }}} We would expect this to match the pattern, {{{#!hs (App (App arrowRep intRep) charRep) }}} where {{{#!hs arrowRep :: TypeRep ((->) :: Type -> Type -> Type) intRep :: TypeRep Int charRep :: TypeRep Char }}} However, this is currently not the case. Fix this. -- -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14236#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

#14236: Typeable App pattern doesn't match function types -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: new Priority: low | Milestone: 8.4.1 Component: Compiler | Version: 8.2.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3969 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"cc6be3a2f23c9b2e04f9f491099149e1e1d4d20b/ghc" cc6be3a2/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="cc6be3a2f23c9b2e04f9f491099149e1e1d4d20b" Typeable: Allow App to match arrow types Test Plan: T14236 Reviewers: austin, hvr, goldfire Reviewed By: goldfire Subscribers: RyanGlScott, simonpj, rwbarton, goldfire, thomie, dfeuer GHC Trac Issues: #14236 Differential Revision: https://phabricator.haskell.org/D3969 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14236#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

#14236: Typeable App pattern doesn't match function types -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: closed Priority: low | Milestone: 8.4.1 Component: Compiler | Version: 8.2.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3969 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Herbert Valerio Riedel <hvr@…>): In [changeset:"9c7d0657e2d6c626c6aa7aac061820e8828b857e/ghc" 9c7d065/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="9c7d0657e2d6c626c6aa7aac061820e8828b857e" Revert "Typeable: Allow App to match arrow types" This reverts commit cc6be3a2f23c9b2e04f9f491099149e1e1d4d20b. because it caused the regression #14270 which according to Richard probably doesn't have an easy fix. So this one goes back to the drawning board. This reopens #14236 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14236#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

#14236: Typeable App pattern doesn't match function types -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: new Priority: low | Milestone: 8.4.1 Component: Compiler | Version: 8.2.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #14270 | Differential Rev(s): Phab:D3969 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Simon Peyton Jones <simonpj@…>): In [changeset:"3de788c4eaa0592165bf1fb9e9a6d5b8e2c27554/ghc" 3de788c/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="3de788c4eaa0592165bf1fb9e9a6d5b8e2c27554" Re-apply "Typeable: Allow App to match arrow types" This re-applies commit cc6be3a2f23c9b2e04f9f491099149e1e1d4d20b Author: Ben Gamari <bgamari.foss@gmail.com> Date: Tue Sep 19 18:57:38 2017 -0400 Typeable: Allow App to match arrow types which was reverted because of Trac #14270. Now the latter is fixed we can re-apply it. The original ticket was Trac #14236 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14236#comment:7> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

#14236: Typeable App pattern doesn't match function types -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: closed Priority: low | Milestone: 8.4.1 Component: Compiler | Version: 8.2.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #14270 | Differential Rev(s): Phab:D3969 Wiki Page: | -------------------------------------+------------------------------------- Comment (by bgamari): Thanks for re-applying, Simon! -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14236#comment:9> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler