[GHC] #15923: Skip performance tests if not in a git repo
#15923: Skip performance tests if not in a git repo -------------------------------------+------------------------------------- Reporter: davide | Owner: (none) Type: bug | Status: new Priority: high | Milestone: 8.6.3 Component: Test Suite | Version: 8.6.2 Keywords: performance | Operating System: Unknown/Multiple tests git notes | Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: 12758 Differential Rev(s): | Wiki Page: | Performance/Tests -------------------------------------+------------------------------------- As of #12758 performance tests now compare to the results of the previous commit. Results are stored in git notes. If for some reason the rood directory is not a git repo, we have no results to compare to, nor can we save the new results to git notes. Hence we should skip all performance tests. Such a use case was encountered in simonpj's workflow where he copies/syslinks the work tree without the .git directory before validating. An open question is can we allow performance testing while not in a git repo or by adjusting the workflow? Tasks: * When the ghc root directory is not a git repository, skip all performance tests. * Update the [https://ghc.haskell.org/trac/ghc/wiki/Performance/Tests wiki page]. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15923 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#15923: Skip performance tests if not in a git repo -------------------------------------+------------------------------------- Reporter: davide | Owner: davide Type: bug | Status: new Priority: high | Milestone: 8.6.3 Component: Test Suite | Version: 8.6.2 Resolution: | Keywords: performance | tests git notes Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: 12758 | Differential Rev(s): Wiki Page: | Performance/Tests | -------------------------------------+------------------------------------- Changes (by davide): * owner: (none) => davide -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15923#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#15923: Skip performance tests if not in a git repo -------------------------------------+------------------------------------- Reporter: davide | Owner: davide Type: bug | Status: new Priority: high | Milestone: 8.6.3 Component: Test Suite | Version: 8.6.2 Resolution: | Keywords: performance | tests git notes Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: 12758 | Differential Rev(s): D5367 Wiki Page: | Performance/Tests | -------------------------------------+------------------------------------- Changes (by davide): * differential: => D5367 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15923#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
When the ghc root directory is not a git repository, skip all
#15923: Skip performance tests if not in a git repo -------------------------------------+------------------------------------- Reporter: davide | Owner: davide Type: bug | Status: new Priority: high | Milestone: 8.6.3 Component: Test Suite | Version: 8.6.2 Resolution: | Keywords: performance | tests git notes Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: 12758 | Differential Rev(s): D5367 Wiki Page: | Performance/Tests | -------------------------------------+------------------------------------- Comment (by osa1): performance tests. Is this really what we want? It doesn't make sense to me to skip performance tests simply because we're not in a git repo, as it doesn't indicate that I'm not interested in performance tests. Why not just skip recording perf numbers when not in a git repo instead? -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15923#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#15923: Skip performance tests if not in a git repo
-------------------------------------+-------------------------------------
Reporter: davide | Owner: davide
Type: bug | Status: new
Priority: high | Milestone: 8.6.3
Component: Test Suite | Version: 8.6.2
Resolution: | Keywords: performance
| tests git notes
Operating System: Unknown/Multiple | Architecture:
| Unknown/Multiple
Type of failure: None/Unknown | Test Case:
Blocked By: | Blocking:
Related Tickets: 12758 | Differential Rev(s): D5367
Wiki Page: |
Performance/Tests |
-------------------------------------+-------------------------------------
Comment (by David Eichmann
#15923: Skip performance tests if not in a git repo -------------------------------------+------------------------------------- Reporter: davide | Owner: davide Type: bug | Status: closed Priority: high | Milestone: Component: Test Suite | Version: 8.6.2 Resolution: fixed | Keywords: performance | tests git notes Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: 12758 | Differential Rev(s): D5367 Wiki Page: | Performance/Tests | -------------------------------------+------------------------------------- Changes (by davide): * status: new => closed * resolution: => fixed -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15923#comment:6 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC