[GHC] #9317: Add PolyKinds extension to Data.Monoid
#9317: Add PolyKinds extension to Data.Monoid -------------------------------------+------------------------------------- Reporter: bernalex | Owner: Type: bug | Status: new Priority: low | Milestone: Component: libraries/base | Version: 7.8.2 Keywords: | Differential Revisions: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Test Case: | Difficulty: Easy (less Blocking: | than 1 hour) | Blocked By: | Related Tickets: -------------------------------------+------------------------------------- PolyKinds got lost in 1d1ff77aaa09efaddc8cfe0dcf92d6763297cf11. See discussion here: <http://www.haskell.org/pipermail/libraries/2014-July/023261.html>. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9317> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9317: Add PolyKinds extension to Data.Monoid -------------------------------------+------------------------------------- Reporter: bernalex | Owner: Type: bug | Status: patch Priority: low | Milestone: Component: | Version: 7.8.2 libraries/base | Keywords: Resolution: | Operating System: Unknown/Multiple Differential Revisions: | Type of failure: None/Unknown Architecture: | Test Case: Unknown/Multiple | Blocking: Difficulty: Easy (less | than 1 hour) | Blocked By: | Related Tickets: | -------------------------------------+------------------------------------- Changes (by bernalex): * status: new => patch -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9317#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9317: Add PolyKinds extension to Data.Monoid -------------------------------------+------------------------------------- Reporter: bernalex | Owner: Type: bug | Status: patch Priority: low | Milestone: Component: | Version: 7.8.2 libraries/base | Keywords: Resolution: | Operating System: Unknown/Multiple Differential Revisions: | Type of failure: None/Unknown Architecture: | Test Case: Unknown/Multiple | Blocking: Difficulty: Easy (less | than 1 hour) | Blocked By: | Related Tickets: | -------------------------------------+------------------------------------- Comment (by ekmett): This was very much an accidental regression, not something consciously done. Makes sense to fix it. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9317#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9317: Add PolyKinds extension to Data.Monoid -------------------------------------+------------------------------------- Reporter: bernalex | Owner: Type: bug | Status: patch Priority: low | Milestone: Component: | Version: 7.8.2 libraries/base | Keywords: Resolution: | Operating System: Unknown/Multiple Differential Revisions: Phab:D70 | Type of failure: None/Unknown Architecture: | Test Case: Unknown/Multiple | Blocking: Difficulty: Easy (less | than 1 hour) | Blocked By: | Related Tickets: | -------------------------------------+------------------------------------- Changes (by bernalex): * differential: => Phab:D70 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9317#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9317: Add PolyKinds extension to Data.Monoid -------------------------------------+------------------------------------- Reporter: bernalex | Owner: Type: bug | Status: patch Priority: low | Milestone: Component: | Version: 7.8.2 libraries/base | Keywords: Resolution: | Operating System: Unknown/Multiple Differential Revisions: Phab:D70 | Type of failure: None/Unknown Architecture: | Test Case: Unknown/Multiple | Blocking: Difficulty: Easy (less | than 1 hour) | Blocked By: | Related Tickets: | -------------------------------------+------------------------------------- Comment (by Austin Seipp <austin@…>): In [changeset:"18b2c46773eccb974bdd042a2f400edd23e193d7/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="18b2c46773eccb974bdd042a2f400edd23e193d7" Add PolyKinds extension to Data.Monoid Summary: Carl Howells pointed out[0] that the `Monoid` instance for `Data.Proxy.Proxy` is only defined for types with kind *. This is a very mild change. Furthermore, Edward Kmett revealed[1] that it was supposed to be there all along -- the extension simply got lost in commit 1d1ff77aaa09efaddc8cfe0dcf92d6763297cf11, as pointed out by Adam Vogt[2]. This used to be correct in GHC 7.6, so this commit fixes a regression. This addresses #9317. [0] <http://www.haskell.org/pipermail/libraries/2014-July/023261.html>. [1] <http://www.haskell.org/pipermail/libraries/2014-July/023267.html>. [2] <http://www.haskell.org/pipermail/libraries/2014-July/023265.html>. Signed-off-by: Alexander Berntsen <alexander@plaimi.net> Test Plan: See [0] Reviewers: austin, hvr, ekmett Reviewed By: austin, hvr, ekmett Subscribers: phaskell, simonmar, relrod, carter Differential Revision: https://phabricator.haskell.org/D70 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9317#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9317: Add PolyKinds extension to Data.Monoid -------------------------------------+------------------------------------- Reporter: bernalex | Owner: Type: bug | Status: closed Priority: low | Milestone: Component: | Version: 7.8.2 libraries/base | Keywords: Resolution: fixed | Operating System: Unknown/Multiple Differential Revisions: Phab:D70 | Type of failure: None/Unknown Architecture: | Test Case: Unknown/Multiple | Blocking: Difficulty: Easy (less | than 1 hour) | Blocked By: | Related Tickets: | -------------------------------------+------------------------------------- Changes (by thoughtpolice): * status: patch => closed * resolution: => fixed Comment: Merged, thanks! -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9317#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9317: Add PolyKinds extension to Data.Monoid -------------------------------------+------------------------------------- Reporter: bernalex | Owner: Type: bug | Status: closed Priority: low | Milestone: 7.10.1 Component: | Version: 7.8.2 libraries/base | Keywords: Resolution: fixed | Operating System: Unknown/Multiple Differential Revisions: Phab:D70 | Type of failure: None/Unknown Architecture: | Test Case: Unknown/Multiple | Blocking: Difficulty: Easy (less | than 1 hour) | Blocked By: | Related Tickets: | -------------------------------------+------------------------------------- Changes (by thoughtpolice): * milestone: => 7.10.1 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9317#comment:6> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC