[GHC] #8322: Report all missing module, not just the first or last
#8322: Report all missing module, not just the first or last ------------------------------------+------------------------------------- Reporter: nomeata | Owner: Type: feature request | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.6.3 Keywords: | Operating System: Unknown/Multiple Architecture: Unknown/Multiple | Type of failure: None/Unknown Difficulty: Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | ------------------------------------+------------------------------------- This is a usability issue bothering me for a while, so I’ll write it down (and potentially attempt to solve it myself). Given `Imports.hs` with {{{ import ABC import XYZ }}} with `ghc -c Imports.hs` I get {{{ Imports.hs:1:1: Failed to load interface for ‛ABC’ Use -v to see a list of the files searched for. }}} When I would want {{{ Imports.hs:1:1: Failed to load interface for ‛ABC’ Use -v to see a list of the files searched for. Imports.hs:2:1: Failed to load interface for ‛XYZ’ Use -v to see a list of the files searched for. }}} Interestingly, with `-c` ghc reports (just) the first, with `--make` (just) the last import... -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8322 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#8322: Report all missing module, not just the first or last -------------------------------------+------------------------------------ Reporter: nomeata | Owner: nomeata Type: feature request | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.6.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Unknown/Multiple Type of failure: None/Unknown | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: -------------------------------------+------------------------------------ Changes (by nomeata): * owner: => nomeata Comment: I gave it a shot (branch wip/T8322, http://git.haskell.org/ghc.git/commitdiff/f3d1e79c8f22e2c96b49050e14c250b17f...) It was easy for `-c`, a small change in `RnNames`. It was not so easy for `--make`, where I had add a bunch of `Eithers` to the return value of a few functions. I’m happy to take advise about how to structure that more typical for GHC code. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8322#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#8322: Report all missing module, not just the first or last -------------------------------------+------------------------------------ Reporter: nomeata | Owner: nomeata Type: feature request | Status: patch Priority: normal | Milestone: Component: Compiler | Version: 7.6.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Unknown/Multiple Type of failure: None/Unknown | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: -------------------------------------+------------------------------------ Changes (by nomeata): * status: new => patch Comment: I did a round of self-code-review and made the code a bit nicer. I believe this can be merged now. Can someone review and me the green light? I’ll then push and push the test suite accordingly (`tcfail082` needs updating). -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8322#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#8322: Report all missing module, not just the first or last -------------------------------------+------------------------------------ Reporter: nomeata | Owner: nomeata Type: feature request | Status: patch Priority: normal | Milestone: Component: Compiler | Version: 7.6.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Unknown/Multiple Type of failure: None/Unknown | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: -------------------------------------+------------------------------------ Comment (by thoughtpolice): LGTM. Joachim, I'll go ahead and merge this for you. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8322#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#8322: Report all missing module, not just the first or last
-------------------------------------+------------------------------------
Reporter: nomeata | Owner: nomeata
Type: feature request | Status: patch
Priority: normal | Milestone:
Component: Compiler | Version: 7.6.3
Resolution: | Keywords:
Operating System: Unknown/Multiple | Architecture: Unknown/Multiple
Type of failure: None/Unknown | Difficulty: Unknown
Test Case: | Blocked By:
Blocking: | Related Tickets:
-------------------------------------+------------------------------------
Comment (by Austin Seipp
#8322: Report all missing module, not just the first or last
-------------------------------------+------------------------------------
Reporter: nomeata | Owner: nomeata
Type: feature request | Status: patch
Priority: normal | Milestone:
Component: Compiler | Version: 7.6.3
Resolution: | Keywords:
Operating System: Unknown/Multiple | Architecture: Unknown/Multiple
Type of failure: None/Unknown | Difficulty: Unknown
Test Case: | Blocked By:
Blocking: | Related Tickets:
-------------------------------------+------------------------------------
Comment (by Austin Seipp
#8322: Report all missing module, not just the first or last -------------------------------------+------------------------------------ Reporter: nomeata | Owner: nomeata Type: feature request | Status: closed Priority: normal | Milestone: Component: Compiler | Version: 7.6.3 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: Unknown/Multiple Type of failure: None/Unknown | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: -------------------------------------+------------------------------------ Changes (by thoughtpolice): * status: patch => closed * resolution: => fixed Comment: Merged, thanks Joachim! -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8322#comment:6 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC