[GHC] #13173: Investigate old comment at the top of SrcLoc
#13173: Investigate old comment at the top of SrcLoc -------------------------------------+------------------------------------- Reporter: mpickering | Owner: Type: task | Status: new Priority: lowest | Milestone: Component: Compiler | Version: 8.0.1 Keywords: newcomer | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- There is a comment at the top of `SrcLoc` which says {{{ {-# OPTIONS_GHC -fno-omit-interface-pragmas #-} -- Workaround for Trac #5252 crashes the bootstrap compiler without -O -- When the earliest compiler we want to boostrap with is -- GHC 7.2, we can make RealSrcLoc properly abstract }}} This is a well-defined small task so I will mark it for newcomers. 1. Try to work out what the pragma is meant to do by reading #5252 2. Work out whether we can now make `RealSrcLoc` "properly abstract" (if it is not already) 3. Remove or update this comment and pragma. 4. Pray it doesn't break the whole compiler. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13173 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#13173: Investigate old comment at the top of SrcLoc -------------------------------------+------------------------------------- Reporter: mpickering | Owner: supersven Type: task | Status: new Priority: lowest | Milestone: Component: Compiler | Version: 8.0.1 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by supersven): * owner: (none) => supersven -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13173#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#13173: Investigate old comment at the top of SrcLoc -------------------------------------+------------------------------------- Reporter: mpickering | Owner: supersven Type: task | Status: new Priority: lowest | Milestone: Component: Compiler | Version: 8.0.1 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by supersven): Regarding {{{ -- When the earliest compiler we want to boostrap with is -- GHC 7.2, we can make RealSrcLoc properly abstract }}} Building/Preparation/Tools states:
In general, we support building with the previous 2 major releases, e.g.:
[...]
To build 8.0.* you need GHC >= 7.8 [[BR]] To build 8.2.* you need GHC >= 7.10
So, according to the comment, it should be save to remove the option. I'm now running `validate` to ensure that the option really can be removed... -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13173#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#13173: Investigate old comment at the top of SrcLoc -------------------------------------+------------------------------------- Reporter: mpickering | Owner: supersven Type: task | Status: new Priority: lowest | Milestone: Component: Compiler | Version: 8.0.1 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): D3763 Wiki Page: | -------------------------------------+------------------------------------- Changes (by supersven): * differential: => D3763 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13173#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#13173: Investigate old comment at the top of SrcLoc -------------------------------------+------------------------------------- Reporter: mpickering | Owner: supersven Type: task | Status: new Priority: lowest | Milestone: Component: Compiler | Version: 8.0.1 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): D3763 Wiki Page: | -------------------------------------+------------------------------------- Comment (by supersven): I'm now running this build .mk (`make -j4`) {{{ SRC_HC_OPTS = -O0 -H64m GhcStage1HcOpts = -O0 GhcStage2HcOpts = -O0 GhcLibHcOpts = -O0 BUILD_PROF_LIBS = NO SplitObjs = NO SplitSections = NO HADDOCK_DOCS = NO BUILD_SPHINX_HTML = NO BUILD_SPHINX_PDF = NO BUILD_MAN = NO }}} to make sure nothing breaks without optimization (-O0 -> no optimization). My machine config (output of `./configure`): {{{ ---------------------------------------------------------------------- Configure completed successfully. Building GHC version : 8.3.20170720 Git commit id : fa28ec2927e905228283708d6dcc194e4f65d49c Build platform : x86_64-unknown-linux Host platform : x86_64-unknown-linux Target platform : x86_64-unknown-linux Bootstrapping using : /usr/bin/ghc which is version : 8.0.2 Using (for bootstrapping) : /usr/bin/gcc Using gcc : gcc which is version : 6.3.0 Building a cross compiler : NO Unregisterised : NO hs-cpp : gcc hs-cpp-flags : -E -undef -traditional ar : ar ld : ld.gold nm : nm libtool : objdump : ranlib : ranlib windres : dllwrap : Happy : /usr/bin/happy (1.19.5) Alex : /usr/bin/alex (3.1.7) Perl : /usr/bin/perl sphinx-build : /usr/local/bin/sphinx-build xelatex : /usr/bin/xelatex Using LLVM tools llc : opt : HsColour : /usr/bin/HsColour Tools to build Sphinx HTML documentation available: YES Tools to build Sphinx PDF documentation available: YES ---------------------------------------------------------------------- }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13173#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#13173: Investigate old comment at the top of SrcLoc -------------------------------------+------------------------------------- Reporter: mpickering | Owner: supersven Type: task | Status: patch Priority: lowest | Milestone: Component: Compiler | Version: 8.0.1 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): D3763 Wiki Page: | -------------------------------------+------------------------------------- Changes (by supersven): * status: new => patch -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13173#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#13173: Investigate old comment at the top of SrcLoc
-------------------------------------+-------------------------------------
Reporter: mpickering | Owner: supersven
Type: task | Status: patch
Priority: lowest | Milestone:
Component: Compiler | Version: 8.0.1
Resolution: | Keywords: newcomer
Operating System: Unknown/Multiple | Architecture:
| Unknown/Multiple
Type of failure: None/Unknown | Test Case:
Blocked By: | Blocking:
Related Tickets: | Differential Rev(s): D3763
Wiki Page: |
-------------------------------------+-------------------------------------
Comment (by Ben Gamari
#13173: Investigate old comment at the top of SrcLoc -------------------------------------+------------------------------------- Reporter: mpickering | Owner: supersven Type: task | Status: closed Priority: lowest | Milestone: 8.4.1 Component: Compiler | Version: 8.0.1 Resolution: fixed | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): D3763 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: patch => closed * resolution: => fixed * milestone: => 8.4.1 Old description:
There is a comment at the top of `SrcLoc` which says
{{{ {-# OPTIONS_GHC -fno-omit-interface-pragmas #-} -- Workaround for Trac #5252 crashes the bootstrap compiler without -O -- When the earliest compiler we want to boostrap with is -- GHC 7.2, we can make RealSrcLoc properly abstract }}}
This is a well-defined small task so I will mark it for newcomers.
1. Try to work out what the pragma is meant to do by reading #5252 2. Work out whether we can now make `RealSrcLoc` "properly abstract" (if it is not already) 3. Remove or update this comment and pragma. 4. Pray it doesn't break the whole compiler.
New description: There is a comment at the top of `SrcLoc` which says {{{#!hs {-# OPTIONS_GHC -fno-omit-interface-pragmas #-} -- Workaround for Trac #5252 crashes the bootstrap compiler without -O -- When the earliest compiler we want to boostrap with is -- GHC 7.2, we can make RealSrcLoc properly abstract }}} This is a well-defined small task so I will mark it for newcomers. 1. Try to work out what the pragma is meant to do by reading #5252 2. Work out whether we can now make `RealSrcLoc` "properly abstract" (if it is not already) 3. Remove or update this comment and pragma. 4. Pray it doesn't break the whole compiler. -- -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13173#comment:7 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC