#10603: Output of -ddump-splices is parenthesized incorrectly -------------------------------------+------------------------------------- Reporter: RyanGlScott | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Template Haskell | Version: 7.10.1 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: Type of failure: Other | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Changes (by goldfire): * keywords: => newcomer Comment: This is indeed a bug, but straightforward to fix. The code is all in `libraries/template-haskell/Language/Haskell/TH/Ppr.hs`. Anyone want to submit a patch? -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10603#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#10603: Output of -ddump-splices is parenthesized incorrectly -------------------------------------+------------------------------------- Reporter: RyanGlScott | Owner: dnusbaum Type: bug | Status: new Priority: normal | Milestone: Component: Template Haskell | Version: 7.10.1 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: Type of failure: Other | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by goldfire): Hooray! Let me know if I can be of help. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10603#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#10603: Output of -ddump-splices is parenthesized incorrectly -------------------------------------+------------------------------------- Reporter: RyanGlScott | Owner: dnusbaum Type: bug | Status: patch Priority: normal | Milestone: Component: Template Haskell | Version: 7.10.1 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: D1114 -------------------------------------+------------------------------------- Comment (by rodlogic): Sorry @dnusbaum, I had my nose around this issue, which was a problem pretty printing the HsSyn AST and not TH AST. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10603#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#10603: Output of -ddump-splices is parenthesized incorrectly -------------------------------------+------------------------------------- Reporter: RyanGlScott | Owner: dnusbaum Type: bug | Status: patch Priority: normal | Milestone: 7.12.1 Component: Template Haskell | Version: 7.10.1 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: #10703 | Differential Revisions: Phab:D1114 -------------------------------------+------------------------------------- Comment (by osa1): Just to keep this ticket updated: There are some other, related problems with GHC printing that made it to the testsuite. Example: https://github.com/ghc/ghc/blob/5ff4daddd9bc8f424d8f71fb01ebbbae9d608cdf/tes... this is not a valid syntax. (needs a paren around the function) -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10603#comment:7 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#10603: Output of -ddump-splices is parenthesized incorrectly -------------------------------------+------------------------------------- Reporter: RyanGlScott | Owner: dnusbaum Type: bug | Status: patch Priority: normal | Milestone: 8.0.1 Component: Template Haskell | Version: 7.10.1 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: #10703 | Differential Rev(s): Phab:D1114 Wiki Page: | -------------------------------------+------------------------------------- Changes (by simonpj): * milestone: 8.2.1 => 8.0.1 Comment: This whole ticket is just symptomatic of a broader issue. As Richard says: "The problem is that HsExpr is intended to be parsed Haskell source. Printing should thus be a breeze: the programmer had to insert all the necessary parens, so we just spit back out what the programmer said. "However, splicing in TH also produces HsExpr. Because it's not programmer-specified, the parentheses are unnecessary here, because no parser will ever look at it. But here we do want parentheses. "We could try to get the HsExpr pretty-printer to be smarter about all of this. But I think that's barking up the wrong tree -- ideally, the HsExprpretty-printer should be very dumb about parentheses. (Indeed, I believe that ppr_expr should never recur into pprParendExpr. But that's more than we need to accomplish today.) "Instead, I think a better approach is to have the Convert module add HsPar nodes. By doing this, we make it more possible that printing HsExpr will be exactly what the programmer wrote, while still getting valid output from TH." And in `HsExpr` we find {{{ HsSyn records exactly where the user put parens, with HsPar. So generally speaking we print without adding any parens. However, some code is internally generated, and in some places parens are absolutely required; so for these places we use pprParendExpr (but don't print double parens of course). For operator applications we don't add parens, because the operator fixities should do the job, except in debug mode (-dppr-debug) so we can see the structure of the parse tree. }}} I like Richard's proposed solution. Let's do that rather than making an ad-hoc fix for this particular example. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10603#comment:10 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#10603: Output of -ddump-splices is parenthesized incorrectly -------------------------------------+------------------------------------- Reporter: RyanGlScott | Owner: dnusbaum Type: bug | Status: patch Priority: normal | Milestone: 8.0.1 Component: Template Haskell | Version: 7.10.1 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: #10703 | Differential Rev(s): Phab:D1114 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari ): In [changeset:"5cb236dd6b497da0b9072b20ca74c298477f7a61/ghc" 5cb236d/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="5cb236dd6b497da0b9072b20ca74c298477f7a61" fix -ddump-splices to parenthesize ((\x -> x) a) correctly Test Plan: ./validate Reviewers: goldfire, austin, bgamari Subscribers: goldfire, osa1, thomie Differential Revision: https://phabricator.haskell.org/D1114 GHC Trac Issues: #10603 }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10603#comment:12 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler