[GHC] #11580: panic on incompatible options
#11580: panic on incompatible options -------------------------------------+------------------------------------- Reporter: dougm | Owner: Type: bug | Status: new Priority: low | Milestone: Component: Compiler | Version: 7.8.4 Keywords: | Operating System: Linux Architecture: x86_64 | Type of failure: Compile-time (amd64) | crash Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- This torture test causes ghc to panic for incompatible options Unsafe and Trustworthy {{{ ghc `ghc --supported-languages | sed 's/^/-X/'` }}} The two options alone lead to a correct diagnostic. So does deletion of either from the full list. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11580> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11580: panic on incompatible options -------------------------------------+------------------------------------- Reporter: dougm | Owner: Type: bug | Status: new Priority: low | Milestone: Component: Compiler | Version: 7.8.4 Resolution: | Keywords: newcomer Operating System: Linux | Architecture: x86_64 Type of failure: Compile-time | (amd64) crash | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by thomie): * keywords: => newcomer Comment: Nice test :) Would you like to submit a patch? See [wiki:Newcomers] and [wiki:WorkingConventions/FixingBugs]. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11580#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11580: panic on incompatible options -------------------------------------+------------------------------------- Reporter: dougm | Owner: Type: bug | Status: patch Priority: low | Milestone: Component: Compiler | Version: 7.8.4 Resolution: | Keywords: newcomer Operating System: Linux | Architecture: x86_64 Type of failure: Compile-time | (amd64) crash | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1925 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => patch * differential: => Phab:D1925 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11580#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11580: panic on incompatible options -------------------------------------+------------------------------------- Reporter: dougm | Owner: Type: bug | Status: patch Priority: low | Milestone: Component: Compiler | Version: 7.8.4 Resolution: | Keywords: newcomer Operating System: Linux | Architecture: x86_64 Type of failure: Compile-time | (amd64) crash | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1925 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"2b906af0dab01c30c28792d39161e01449b85cb0/ghc" 2b906af0/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="2b906af0dab01c30c28792d39161e01449b85cb0" DynFlags: Don't panic on incompatible Safe Haskell flags We just return an arbitrary value since we are destined to fail due to the error anyways. Fixes #11580. Test Plan: Needs to be tested Reviewers: austin Subscribers: thomie Differential Revision: https://phabricator.haskell.org/D1925 GHC Trac Issues: #11580 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11580#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11580: panic on incompatible options -------------------------------------+------------------------------------- Reporter: dougm | Owner: Type: bug | Status: merge Priority: low | Milestone: 8.0.1 Component: Compiler | Version: 7.8.4 Resolution: | Keywords: newcomer Operating System: Linux | Architecture: x86_64 Type of failure: Compile-time | (amd64) crash | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1925 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: patch => merge * milestone: => 8.0.1 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11580#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11580: panic on incompatible options -------------------------------------+------------------------------------- Reporter: dougm | Owner: Type: bug | Status: merge Priority: low | Milestone: 8.0.1 Component: Compiler | Version: 7.8.4 Resolution: | Keywords: newcomer Operating System: Linux | Architecture: x86_64 Type of failure: Compile-time | (amd64) crash | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1925 Wiki Page: | -------------------------------------+------------------------------------- Comment (by rwbarton): For anyone else who was confused at first like me, the panic actually arises from specifying all ''three'' of `-XSafe`, `-XUnsafe` and `-XTrustworthy` because then the result of combining the first two flags is demanded when adding the third flag. We should still add * a test for `-XSafe -XUnsafe -XTrustworthy` (under `safeHaskell/flags`; I'm not going to do it right now just because I would have to build ghc to find out what the right error message is) * the original test in this ticket * possibly other versions of that test for the `-d`, `-f` and `-W` flags. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11580#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11580: panic on incompatible options -------------------------------------+------------------------------------- Reporter: dougm | Owner: Type: bug | Status: new Priority: low | Milestone: 8.0.1 Component: Compiler | Version: 7.8.4 Resolution: | Keywords: newcomer Operating System: Linux | Architecture: x86_64 Type of failure: Compile-time | (amd64) crash | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1925 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: merge => new Comment: Merged to `ghc-7.10` as ad6a7a3c65e6083417230521e28cb3ed831bf184. Still needs tests as pointed out by rwbarton. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11580#comment:6> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11580: panic on incompatible options -------------------------------------+------------------------------------- Reporter: dougm | Owner: kaiha Type: bug | Status: new Priority: low | Milestone: 8.0.1 Component: Compiler | Version: 7.8.4 Resolution: | Keywords: newcomer Operating System: Linux | Architecture: x86_64 Type of failure: Compile-time | (amd64) crash | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1925 Wiki Page: | -------------------------------------+------------------------------------- Changes (by kaiha): * owner: => kaiha -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11580#comment:7> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11580: panic on incompatible options -------------------------------------+------------------------------------- Reporter: dougm | Owner: kaiha Type: bug | Status: patch Priority: low | Milestone: 8.0.1 Component: Compiler | Version: 7.8.4 Resolution: | Keywords: newcomer Operating System: Linux | Architecture: x86_64 Type of failure: Compile-time | (amd64) crash | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1925 Wiki Page: | Phab:D2013 -------------------------------------+------------------------------------- Changes (by kaiha): * status: new => patch * differential: Phab:D1925 => Phab:D1925 Phab:D2013 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11580#comment:8> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11580: panic on incompatible options -------------------------------------+------------------------------------- Reporter: dougm | Owner: kaiha Type: bug | Status: patch Priority: low | Milestone: 8.0.1 Component: Compiler | Version: 7.8.4 Resolution: | Keywords: newcomer Operating System: Linux | Architecture: x86_64 Type of failure: Compile-time | (amd64) crash | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1925 Wiki Page: | Phab:D2013 -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"289d57a6894b5d3eb5daf696a75275a8146f0092/ghc" 289d57a/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="289d57a6894b5d3eb5daf696a75275a8146f0092" Add test for incompatible flags (issue #11580) Reviewers: austin, bgamari Reviewed By: bgamari Subscribers: thomie Differential Revision: https://phabricator.haskell.org/D2013 GHC Trac Issues: #11580 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11580#comment:9> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11580: panic on incompatible options -------------------------------------+------------------------------------- Reporter: dougm | Owner: kaiha Type: bug | Status: closed Priority: low | Milestone: 8.0.1 Component: Compiler | Version: 7.8.4 Resolution: fixed | Keywords: newcomer Operating System: Linux | Architecture: x86_64 Type of failure: Compile-time | (amd64) crash | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1925 Wiki Page: | Phab:D2013 -------------------------------------+------------------------------------- Changes (by bgamari): * status: patch => closed * resolution: => fixed -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11580#comment:10> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11580: panic on incompatible options -------------------------------------+------------------------------------- Reporter: dougm | Owner: Type: bug | Status: new Priority: low | Milestone: 8.0.1 Component: Compiler | Version: 7.8.4 Resolution: | Keywords: newcomer Operating System: Linux | Architecture: x86_64 Type of failure: Compile-time | (amd64) crash | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1925 Wiki Page: | Phab:D2013 -------------------------------------+------------------------------------- Changes (by bgamari): * owner: kaiha => * status: closed => new * resolution: fixed => Comment: Merged to `ghc-8.0` as 552df38b6ab5f397817d5c8eaf787f1ea304c19a. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11580#comment:11> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11580: panic on incompatible options -------------------------------------+------------------------------------- Reporter: dougm | Owner: Type: bug | Status: closed Priority: low | Milestone: 8.0.1 Component: Compiler | Version: 7.8.4 Resolution: fixed | Keywords: newcomer Operating System: Linux | Architecture: x86_64 Type of failure: Compile-time | (amd64) crash | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1925 Wiki Page: | Phab:D2013 -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => closed * resolution: => fixed -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11580#comment:12> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC