[GHC] #12084: ghc --help suggests -auto-all instead of -fprof-auto
#12084: ghc --help suggests -auto-all instead of -fprof-auto -------------------------------------+------------------------------------- Reporter: kjslag | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.10.3 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: Documentation Unknown/Multiple | bug Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- 'ghc --help' suggests the use of -auto-all (see below), but according to [#r1 [1]], "-fprof-auto was known as -auto-all prior to GHC 7.4.1." I assume this means that GHC >= 7.4.1 should not mention -auto-all, and that -fprof-auto should be suggested instead. {{{ $ ghc --help ... -prof Compile for cost-centre profiling (add -auto-all for automagic cost-centres on all top-level functions) ... }}} [=#r1 [1]] https://downloads.haskell.org/~ghc/latest/docs/html/users_guide/profiling.ht... -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12084> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12084: ghc --help suggests -auto-all instead of -fprof-auto -------------------------------------+------------------------------------- Reporter: kjslag | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.10.3 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: Type of failure: Documentation | Unknown/Multiple bug | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by thomie): * keywords: => newcomer -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12084#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12084: ghc --help suggests -auto-all instead of -fprof-auto -------------------------------------+------------------------------------- Reporter: kjslag | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.10.3 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: Type of failure: Documentation | Unknown/Multiple bug | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by seraphime): I can do it tomorrow. Should the message suggest also that -auto-all is deprecated ? If it is so, maybe ghc should emit a warning message if -auto-all is used. The latest docs don't mention the -auto-all flag [1]. Older docs on the other hand describe it in the same terms as the newer -fprof-auto flag.[2] [1] https://downloads.haskell.org/~ghc/7.2-latest/docs/html/users_guide /prof-compiler-options.html [2] https://downloads.haskell.org/~ghc/latest/docs/html/users_guide/prof- compiler-options.html -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12084#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12084: ghc --help suggests -auto-all instead of -fprof-auto -------------------------------------+------------------------------------- Reporter: kjslag | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.10.3 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: Type of failure: Documentation | Unknown/Multiple bug | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by thomie): `ghc --help` doesn't need to mention `-auto-all` Deprecating `-auto-all`, `-auto` and `-caf-all` is ok, but you'll have to mention it in the release notes (`docs/users_guide/8.2.1-notes.rst`), and update all places where they are used in the `testsuite`, `docs` and `nofib`. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12084#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12084: ghc --help suggests -auto-all instead of -fprof-auto -------------------------------------+------------------------------------- Reporter: kjslag | Owner: seraphime Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.10.3 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: Type of failure: Documentation | Unknown/Multiple bug | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by seraphime): * owner: => seraphime -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12084#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12084: ghc --help suggests -auto-all instead of -fprof-auto -------------------------------------+------------------------------------- Reporter: kjslag | Owner: seraphime Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.10.3 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: Type of failure: Documentation | Unknown/Multiple bug | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by Thomas Miedema <thomasmiedema@…>): In [changeset:"35fc121fc8cc501ea2713c579a053be7ea65b16e/nofib" 35fc121/nofib]: {{{ #!CommitTicketReference repository="nofib" revision="35fc121fc8cc501ea2713c579a053be7ea65b16e" Fix: #12084 deprecate old profiling flags }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12084#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12084: ghc --help suggests -auto-all instead of -fprof-auto -------------------------------------+------------------------------------- Reporter: kjslag | Owner: seraphime Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.10.3 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: Type of failure: Documentation | Unknown/Multiple bug | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by Thomas Miedema <thomasmiedema@…>): In [changeset:"1956cbf13bd2138500daebd5f1f0a4931d8710ec/ghc" 1956cbf1/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="1956cbf13bd2138500daebd5f1f0a4931d8710ec" Fix: #12084 deprecate old profiling flags Change help message so it doesn't specify -auto-all. Make old profiling flags deprecated as they are no longer documented. Update Makefile and documentation accordingly. Update release notes for ghc 8.2 Test Plan: ./verify; `ghc --help` shouldn't specify the -auto-all flag. Furthermore `ghc -fprof -auto-all` should emit a warning Reviewed By: thomie, austin Differential Revision: https://phabricator.haskell.org/D2257 GHC Trac Issues: #12084 Update submodule nofib }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12084#comment:6> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12084: ghc --help suggests -auto-all instead of -fprof-auto -------------------------------------+------------------------------------- Reporter: kjslag | Owner: seraphime Type: bug | Status: closed Priority: normal | Milestone: 8.2.1 Component: Compiler | Version: 7.10.3 Resolution: fixed | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: Type of failure: Documentation | Unknown/Multiple bug | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by thomie): * status: new => closed * resolution: => fixed * milestone: => 8.2.1 Comment: seraphime: congratulations with your first GHC patch. kjslag: thank you for the report. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12084#comment:7> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC