[GHC] #11354: Install script installs docs without -version suffix
#11354: Install script installs docs without -version suffix -------------------------------------+------------------------------------- Reporter: osa1 | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Build System | Version: 8.1 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- This is potentially bad when multiple GHC versions are installed - last installed one overwrites all the docs. It seems like docs are installed under {{{$PACKAGE_TARNAME}}}, and tarname is initialized as {{{"ghc"}}} in the {{{ac}}} file. I guess one solution would be to add version suffix to tarname (it seems like tarname is only used when installing docs) or alternatively use {{{${PACKAGE_TARNAME}-${PACKAGE_VERSION}}}} to install docs. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11354> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11354: Install script installs docs without -version suffix -------------------------------------+------------------------------------- Reporter: osa1 | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Build System | Version: 7.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1868 Wiki Page: | -------------------------------------+------------------------------------- Changes (by thomie): * version: 8.1 => 7.0.1 * differential: => Phab:D1868 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11354#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11354: Install script installs docs without -version suffix -------------------------------------+------------------------------------- Reporter: osa1 | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Build System | Version: 7.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1868 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Thomas Miedema <thomasmiedema@…>): In [changeset:"b61f5f734d08fe9cdca3ac06560fc15e97aa77ab/ghc" b61f5f73/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="b61f5f734d08fe9cdca3ac06560fc15e97aa77ab" Put docs in /usr/share/doc/ghc-<version> `make install` puts libraries in a direcory containing the version number. Do the same for the docs, such that multiple installs can live side-by-side. Delete unused ghcdocdir. Test Plan: ``` ./boot ./configure make show! VALUE=docdir ``` Reviewed by: bgamari Differential Revision: https://phabricator.haskell.org/D1868 GHC Trac Issues: #11354 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11354#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11354: Install script installs docs without -version suffix -------------------------------------+------------------------------------- Reporter: osa1 | Owner: Type: bug | Status: merge Priority: normal | Milestone: Component: Build System | Version: 7.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1868 Wiki Page: | -------------------------------------+------------------------------------- Changes (by thomie): * status: new => merge Comment: Should be safe to merge, but please use your own judgement. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11354#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11354: Install script installs docs without -version suffix -------------------------------------+------------------------------------- Reporter: osa1 | Owner: Type: bug | Status: merge Priority: normal | Milestone: 8.0.1 Component: Build System | Version: 7.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1868 Wiki Page: | -------------------------------------+------------------------------------- Changes (by thomie): * milestone: => 8.0.1 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11354#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11354: Install script installs docs without -version suffix -------------------------------------+------------------------------------- Reporter: osa1 | Owner: Type: bug | Status: closed Priority: normal | Milestone: 8.0.1 Component: Build System | Version: 7.0.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1868 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: merge => closed * resolution: => fixed Comment: This sounds quite reasonable to me. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11354#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11354: Install script installs docs without -version suffix -------------------------------------+------------------------------------- Reporter: osa1 | Owner: Type: bug | Status: closed Priority: normal | Milestone: 8.0.1 Component: Build System | Version: 7.0.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1868 Wiki Page: | -------------------------------------+------------------------------------- Comment (by thomie): This patch might cause problems for some people, see for example: https://github.com/fpco/ghc-rc- stackage/blob/e96839cdf392a217c7638b249a6e56d205b9e614/Dockerfile#L24-L26 I think you should be able to do the following to put the docs in the old place: `./configure --docdir='${datarootdir}/doc/ghc'`. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11354#comment:6> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11354: Install script installs docs without -version suffix -------------------------------------+------------------------------------- Reporter: osa1 | Owner: Type: bug | Status: closed Priority: normal | Milestone: 8.0.1 Component: Build System | Version: 7.0.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1868 Wiki Page: | -------------------------------------+------------------------------------- Comment (by juhpetersen): I think this is not refected in the 'configure --help' output which still says docdir defaults to [DATAROOTDIR/doc/ghc], which is confusing. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11354#comment:7> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11354: Install script installs docs without -version suffix -------------------------------------+------------------------------------- Reporter: osa1 | Owner: Type: bug | Status: closed Priority: normal | Milestone: 8.0.1 Component: Build System | Version: 7.0.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1868 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"a74a3846c84ad55de3deeed8b2401a2ed514b2e1/ghc" a74a384/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="a74a3846c84ad55de3deeed8b2401a2ed514b2e1" Include version in AC_PACKAGE_TARNAME `AC_PACKAGE_TARNAME` is used by autoconf to generate the default value of docdir, which we now set to include a version number (see #11354). This fixed #11659. Test Plan: `./configure --help`, validate Reviewers: austin, thomie, hvr, erikd Reviewed By: hvr, erikd Subscribers: erikd Differential Revision: https://phabricator.haskell.org/D1983 GHC Trac Issues: #11659 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11354#comment:8> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC