#9156: Duplicate record field ------------------------------------------------+-------------------------- Reporter: wojteknar | Owner: Type: bug | Status: new Priority: low | Milestone: Component: Compiler | Version: 7.8.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: GHC accepts invalid program | Unknown/Multiple Test Case: | Difficulty: Blocking: | Unknown | Blocked By: | Related Tickets: ------------------------------------------------+-------------------------- Changes (by wojteknar): * failure: None/Unknown => GHC accepts invalid program -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9156#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#9156: Duplicate record field ------------------------------------------------+-------------------------- Reporter: wojteknar | Owner: gintas Type: bug | Status: new Priority: low | Milestone: Component: Compiler | Version: 7.8.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: GHC accepts invalid program | Unknown/Multiple Test Case: T9156 | Difficulty: Blocking: | Unknown | Blocked By: | Related Tickets: ------------------------------------------------+-------------------------- Changes (by gintas): * testcase: => T9156 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9156#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#9156: Duplicate record field ------------------------------------------------+-------------------------- Reporter: wojteknar | Owner: gintas Type: bug | Status: patch Priority: low | Milestone: Component: Compiler | Version: 7.8.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: GHC accepts invalid program | Unknown/Multiple Test Case: T9156 | Difficulty: Blocking: | Unknown | Blocked By: | Related Tickets: ------------------------------------------------+-------------------------- Changes (by gintas): * status: new => patch Comment: OK, the failures do look like a fluke, although I'm not quite sure. Could someone take a look? -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9156#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#9156: Duplicate record field ------------------------------------------------+-------------------------- Reporter: wojteknar | Owner: gintas Type: bug | Status: patch Priority: low | Milestone: Component: Compiler | Version: 7.8.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: GHC accepts invalid program | Unknown/Multiple Test Case: T9156 | Difficulty: Blocking: | Unknown | Blocked By: | Related Tickets: ------------------------------------------------+-------------------------- Comment (by gintas): The 0002-Refactored-record-field-duplicate-code-to-use-nested.patch is broken, I accidentally uploaded a stale version. Sorry about that. Use 0002-fixed-refactor.patch instead. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9156#comment:7 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#9156: Duplicate record field ------------------------------------------------+-------------------------- Reporter: wojteknar | Owner: gintas Type: bug | Status: patch Priority: low | Milestone: Component: Compiler | Version: 7.8.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: GHC accepts invalid program | Unknown/Multiple Test Case: T9156 | Difficulty: Blocking: | Unknown | Blocked By: | Related Tickets: ------------------------------------------------+-------------------------- Comment (by nomeata): Sorry for the delay. The refactoring patch lost your comment, and I believe the code could use some comments. Also, your `dropOneUnloc (unloc v)` could be a `deleteBy (\v' -> unloc v == unloc v')` or `deleteBy ((==) `on` unloc)`, unless I’m mistaken. This would make the code a tad smaller and easier to read (assuming you add a comment that states that it is important here that `deleteBy` deletes only the first occurence). Very minor, but I slightly tripped over `(L loc name : r') ++ go remSeen' rs`, and would not have tripped over `(L loc name) : r' ++ go remSeen' rs`. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9156#comment:9 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#9156: Duplicate record field -------------------------------------+------------------------------------- Reporter: wojteknar | Owner: gintas Type: bug | Status: patch Priority: low | Milestone: Component: Compiler | Version: 7.8.2 Resolution: | Keywords: Differential Revisions: | Operating System: Unknown/Multiple Architecture: | Type of failure: GHC accepts Unknown/Multiple | invalid program Difficulty: Unknown | Test Case: T9156 Blocked By: | Blocking: Related Tickets: | -------------------------------------+------------------------------------- Comment (by nomeata): Looks good to me. I think I’ll try to create a Pharicator code review thingy tomorrow, just to get used to the new tool. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9156#comment:11 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#9156: Duplicate record field -------------------------------------+------------------------------------- Reporter: wojteknar | Owner: gintas Type: bug | Status: patch Priority: low | Milestone: Component: Compiler | Version: 7.8.2 Resolution: | Keywords: Operating System: | Architecture: Unknown/Multiple Unknown/Multiple | Difficulty: Unknown Type of failure: GHC | Blocked By: accepts invalid program | Related Tickets: Test Case: T9156 | Blocking: | Differential Revisions: Phab:D87 | -------------------------------------+------------------------------------- Comment (by Joachim Breitner ): In [changeset:"d2942184c8cc53cb3b50f78a7ecff930c3e5861f/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="d2942184c8cc53cb3b50f78a7ecff930c3e5861f" Fixed issue with detection of duplicate record fields Duplicate record fields would not be detected when given a type with multiple data constructors, and the first data constructor had a record field r1 and any consecutive data constructors had multiple fields named r1. This fixes #9156 and was reviewed in https://phabricator.haskell.org/D87 }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9156#comment:13 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#9156: Duplicate record field -------------------------------------+------------------------------------- Reporter: wojteknar | Owner: gintas Type: bug | Status: closed Priority: low | Milestone: Component: Compiler | Version: 7.8.2 Resolution: fixed | Keywords: Operating System: | Architecture: Unknown/Multiple Unknown/Multiple | Difficulty: Unknown Type of failure: GHC | Blocked By: accepts invalid program | Related Tickets: Test Case: T9156 | Blocking: | Differential Revisions: Phab:D87 | -------------------------------------+------------------------------------- Changes (by nomeata): * status: patch => closed * resolution: => fixed -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9156#comment:15 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler