[GHC] #15228: Remove use of showSDocUnsafe in extending_ghc.rst
#15228: Remove use of showSDocUnsafe in extending_ghc.rst -------------------------------------+------------------------------------- Reporter: mpickering | Owner: (none) Type: task | Status: new Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: 8.4.3 Keywords: newcomer | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- There are lots of usages of `showSDocUnsafe` in `extending_ghc.rst`. However, they are all unnecessary as far as I could see because the `Hsc` or `TcM` context has a copy of `DynFlags` in it. It should be possible to replace them all with `showSDoc`. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15228> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15228: Remove use of showSDocUnsafe in extending_ghc.rst -------------------------------------+------------------------------------- Reporter: mpickering | Owner: (none) Type: task | Status: patch Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: 8.4.3 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4815 Wiki Page: | -------------------------------------+------------------------------------- Changes (by sighingnow): * status: new => patch * differential: => Phab:D4815 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15228#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15228: Remove use of showSDocUnsafe in extending_ghc.rst -------------------------------------+------------------------------------- Reporter: mpickering | Owner: (none) Type: task | Status: closed Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: 8.4.3 Resolution: fixed | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4815 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: patch => closed * resolution: => fixed -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15228#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15228: Remove use of showSDocUnsafe in extending_ghc.rst -------------------------------------+------------------------------------- Reporter: mpickering | Owner: (none) Type: task | Status: closed Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: 8.4.3 Resolution: fixed | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4815 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"d24e73adf7fb33e2c94b7b6c43fe9feb9b23c3a6/ghc" d24e73a/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="d24e73adf7fb33e2c94b7b6c43fe9feb9b23c3a6" Replace `showSDocUnsafe` with `showSDoc` in extending_ghc.rst ... and fix compile errors. Replace the usage of `showSDocUnsafe` with `showSDoc dflags` in example code in extending_ghc.rts. This example contains several compile errors (missing import and syntax error), this patch also fixes that. Test Plan: [skip ci] Reviewers: bgamari, mpickering Reviewed By: mpickering Subscribers: mpickering, rwbarton, thomie, carter GHC Trac Issues: #15228 Differential Revision: https://phabricator.haskell.org/D4815 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15228#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC