[GHC] #13864: RTS Stats are recorded without -T
#13864: RTS Stats are recorded without -T -------------------------------------+------------------------------------- Reporter: glguy | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: Runtime | Version: 8.2.1-rc2 System | Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- The GHC.Stats module documents that I need to run my program with -T to generate stats, but I don't seem to need to. Perhaps the documentation is wrong or the stats are being collected when they shouldn't be. This is a regression(?) from GHC 8.0.2 where -T was required. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13864> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13864: RTS Stats are recorded without -T -------------------------------------+------------------------------------- Reporter: glguy | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: 8.2.1 Component: Runtime System | Version: 8.2.1-rc2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * cc: DemiMarie (added) * milestone: => 8.2.1 Comment: Mmm, good catch. Indeed 12ad4d417b89462ba8e19a3c7772a931b3a93f0e (Throw an exception on heap overflow) changed `initRtsFlagsDefaults` to enable stats collection by default. It's not entirely clear why, but I suspect it was a mistake. DemiMarie, do you have any recollection of this? -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13864#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13864: RTS Stats are recorded without -T -------------------------------------+------------------------------------- Reporter: glguy | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: 8.2.1 Component: Runtime System | Version: 8.2.1-rc2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by bgamari): Ahhh, indeed this was intentional as the patch requires `stats.allocated_bytes`. However, I'm not sure I agree with how we went about this. If stat collection is now really mandatory then either we should remove the ability to disable it or just make sure that we always collect the bits that we need. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13864#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13864: RTS Stats are recorded without -T -------------------------------------+------------------------------------- Reporter: glguy | Owner: (none) Type: bug | Status: patch Priority: normal | Milestone: 8.2.1 Component: Runtime System | Version: 8.2.1-rc2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3669 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => patch * differential: => Phab:D3669 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13864#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13864: RTS Stats are recorded without -T -------------------------------------+------------------------------------- Reporter: glguy | Owner: (none) Type: bug | Status: patch Priority: normal | Milestone: 8.2.1 Component: Runtime System | Version: 8.2.1-rc2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3669 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"4bd4f561d79de4d056571eca61a5249a5091c985/ghc" 4bd4f56/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="4bd4f561d79de4d056571eca61a5249a5091c985" rts: Always collect stats It seems that 12ad4d417b89462ba8e19a3c7772a931b3a93f0e enabled collection by default as its needs stats.allocated_bytes to determine whether the program has exceeded its grace limit. However, enabling stats also enables some potentially expensive times checks. In general GC statistics should be cheap to compute (relative to the GC itself), so now we always compute them. This allows us to once again disable giveStats by default. Fixes #13864. Reviewers: simonmar, austin, erikd Reviewed By: simonmar Subscribers: rwbarton, thomie GHC Trac Issues: #13864 Differential Revision: https://phabricator.haskell.org/D3669 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13864#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13864: RTS Stats are recorded without -T -------------------------------------+------------------------------------- Reporter: glguy | Owner: (none) Type: bug | Status: merge Priority: normal | Milestone: 8.2.1 Component: Runtime System | Version: 8.2.1-rc2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3669 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: patch => merge -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13864#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13864: RTS Stats are recorded without -T -------------------------------------+------------------------------------- Reporter: glguy | Owner: (none) Type: bug | Status: closed Priority: normal | Milestone: 8.2.1 Component: Runtime System | Version: 8.2.1-rc2 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3669 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: merge => closed * resolution: => fixed Comment: Merged in f19ab07b660589bc7cc04073b9c91fac4be384e1. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13864#comment:6> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC