[GHC] #15195: Merge -XPolyKinds with -XTypeInType
#15195: Merge -XPolyKinds with -XTypeInType -------------------------------------+------------------------------------- Reporter: goldfire | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: 8.2.2 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): Phab:D4748 | Wiki Page: -------------------------------------+------------------------------------- As described in [https://github.com/ghc-proposals/ghc- proposals/blob/master/proposals/0020-no-type-in-type.rst this accepted proposal]. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15195> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15195: Merge -XPolyKinds with -XTypeInType -------------------------------------+------------------------------------- Reporter: goldfire | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: 8.2.2 Resolution: | Keywords: GHCProposal Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4748 Wiki Page: | -------------------------------------+------------------------------------- Changes (by goldfire): * keywords: => GHCProposal -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15195#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15195: Merge -XPolyKinds with -XTypeInType -------------------------------------+------------------------------------- Reporter: goldfire | Owner: int-index Type: bug | Status: new Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: 8.2.2 Resolution: | Keywords: GHCProposal Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4748 Wiki Page: | -------------------------------------+------------------------------------- Changes (by int-index): * cc: int-index (added) * owner: (none) => int-index -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15195#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15195: Merge -XPolyKinds with -XTypeInType -------------------------------------+------------------------------------- Reporter: goldfire | Owner: int-index Type: bug | Status: new Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: 8.2.2 Resolution: | Keywords: GHCProposal Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4748 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Richard Eisenberg <rae@…>): In [changeset:"d650729f9a0f3b6aa5e6ef2d5fba337f6f70fa60/ghc" d650729/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="d650729f9a0f3b6aa5e6ef2d5fba337f6f70fa60" Embrace -XTypeInType, add -XStarIsType Summary: Implement the "Embrace Type :: Type" GHC proposal, .../ghc-proposals/blob/master/proposals/0020-no-type-in-type.rst GHC 8.0 included a major change to GHC's type system: the Type :: Type axiom. Though casual users were protected from this by hiding its features behind the -XTypeInType extension, all programs written in GHC 8+ have the axiom behind the scenes. In order to preserve backward compatibility, various legacy features were left unchanged. For example, with -XDataKinds but not -XTypeInType, GADTs could not be used in types. Now these restrictions are lifted and -XTypeInType becomes a redundant flag that will be eventually deprecated. * Incorporate the features currently in -XTypeInType into the -XPolyKinds and -XDataKinds extensions. * Introduce a new extension -XStarIsType to control how to parse * in code and whether to print it in error messages. Test Plan: Validate Reviewers: goldfire, hvr, bgamari, alanz, simonpj Reviewed By: goldfire, simonpj Subscribers: rwbarton, thomie, mpickering, carter GHC Trac Issues: #15195 Differential Revision: https://phabricator.haskell.org/D4748 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15195#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15195: Merge -XPolyKinds with -XTypeInType -------------------------------------+------------------------------------- Reporter: goldfire | Owner: int-index Type: bug | Status: closed Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: 8.2.2 Resolution: fixed | Keywords: GHCProposal Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4748 Wiki Page: | -------------------------------------+------------------------------------- Changes (by goldfire): * status: new => closed * resolution: => fixed Comment: Thanks, @int-index, for seeing this through. Tests are plentiful, but not new. int-index, add a test case if you're particularly inspired to. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15195#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15195: Merge -XPolyKinds with -XTypeInType -------------------------------------+------------------------------------- Reporter: goldfire | Owner: int-index Type: bug | Status: merge Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: 8.2.2 Resolution: fixed | Keywords: GHCProposal Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4748 Wiki Page: | -------------------------------------+------------------------------------- Changes (by int-index): * status: closed => merge Comment: This actually isn't in a stable branch yet. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15195#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15195: Merge -XPolyKinds with -XTypeInType -------------------------------------+------------------------------------- Reporter: goldfire | Owner: int-index Type: bug | Status: closed Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: 8.2.2 Resolution: fixed | Keywords: GHCProposal Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4748 Wiki Page: | -------------------------------------+------------------------------------- Changes (by goldfire): * status: merge => closed Comment: We don't actually need to merge this to a stable branch, as I don't believe the 8.6 branch has been cut yet. Ben, correct me if I'm wrong. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15195#comment:6> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15195: Merge -XPolyKinds with -XTypeInType -------------------------------------+------------------------------------- Reporter: goldfire | Owner: int-index Type: bug | Status: closed Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: 8.2.2 Resolution: fixed | Keywords: GHCProposal Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4748 Wiki Page: | -------------------------------------+------------------------------------- Comment (by int-index): I might misunderstand how releases work, but the `ghc-8.6` branch already exists and does not include this commit. Ben was actually going to cut a release without this commit but we talked about it over IRC and he agreed to merge. The status I've set is described as:
fixed in GHC HEAD repo; please merge to GHC STABLE branch
and I think it describes the current status perfectly. If not, when would I set it? -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15195#comment:7> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15195: Merge -XPolyKinds with -XTypeInType -------------------------------------+------------------------------------- Reporter: goldfire | Owner: int-index Type: bug | Status: merge Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: 8.2.2 Resolution: fixed | Keywords: GHCProposal Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4748 Wiki Page: | -------------------------------------+------------------------------------- Changes (by goldfire): * status: closed => merge Comment: Oops! I didn't know that 8.6 had been cut. Normally, large commits like yours are not merged in the middle of a release cycle but wait around for the next major release. But it's appropriate to put yours in the 8.6 branch. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15195#comment:8> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15195: Merge -XPolyKinds with -XTypeInType -------------------------------------+------------------------------------- Reporter: goldfire | Owner: int-index Type: bug | Status: merge Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: 8.2.2 Resolution: fixed | Keywords: GHCProposal Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4748 Wiki Page: | -------------------------------------+------------------------------------- Comment (by bgamari): Well, to be clear, the `ghc-8.6` branch does exist but it's still tracking `master`. By the end of the day I suspect it will begin diverging. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15195#comment:9> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15195: Merge -XPolyKinds with -XTypeInType -------------------------------------+------------------------------------- Reporter: goldfire | Owner: int-index Type: bug | Status: closed Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: 8.2.2 Resolution: fixed | Keywords: GHCProposal Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4748 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: merge => closed Comment: Alright, I've pushed a bump of `ghc-8.6` including this patch. Closing. Thanks for doing this, int-index! -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15195#comment:10> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15195: Merge -XPolyKinds with -XTypeInType -------------------------------------+------------------------------------- Reporter: goldfire | Owner: int-index Type: bug | Status: closed Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: 8.2.2 Resolution: fixed | Keywords: GHCProposal, | TypeInType Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4748 Wiki Page: | -------------------------------------+------------------------------------- Changes (by RyanGlScott): * keywords: GHCProposal => GHCProposal, TypeInType -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15195#comment:11> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC