[GHC] #9827: void does not use <$
#9827: void does not use <$ -------------------------------------+------------------------------------- Reporter: dfeuer | Owner: dfeuer Type: task | Status: new Priority: normal | Milestone: 7.10.1 Component: Core Libraries | Version: 7.9 Keywords: | Operating System: Architecture: Unknown/Multiple | Unknown/Multiple Difficulty: Easy (less than 1 | Type of failure: Runtime hour) | performance bug Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: Phab:D521 -------------------------------------+------------------------------------- `Data.Functor.void` is currently defined as {{{#!hs void = fmap (const ()) }}} Some `Functor` instances have an optimized `<$`, so this should be {{{#!hs void x = () <$ x }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9827> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9827: void does not use <$ -------------------------------------+------------------------------------- Reporter: dfeuer | Owner: dfeuer Type: task | Status: patch Priority: normal | Milestone: 7.10.1 Component: Core | Version: 7.9 Libraries | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: | Difficulty: Easy (less than 1 Unknown/Multiple | hour) Type of failure: Runtime | Blocked By: performance bug | Related Tickets: Test Case: | Blocking: | Differential Revisions: Phab:D521 | -------------------------------------+------------------------------------- Changes (by dfeuer): * status: new => patch -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9827#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9827: void does not use <$ -------------------------------------+------------------------------------- Reporter: dfeuer | Owner: dfeuer Type: task | Status: patch Priority: normal | Milestone: 7.10.1 Component: Core | Version: 7.9 Libraries | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: | Difficulty: Easy (less than 1 Unknown/Multiple | hour) Type of failure: Runtime | Blocked By: performance bug | Related Tickets: Test Case: | Blocking: | Differential Revisions: Phab:D521 | -------------------------------------+------------------------------------- Comment (by Herbert Valerio Riedel <hvr@…>): In [changeset:"cc7a735f015510dda6f69d4a48d1b0cdd55856ba/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="cc7a735f015510dda6f69d4a48d1b0cdd55856ba" Define void using <$ (re #9827) `() <$ x` is sometimes better than `fmap (const ()) x` and should never be worse. Reviewed By: ekmett Differential Revision: https://phabricator.haskell.org/D521 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9827#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9827: void does not use <$ -------------------------------------+------------------------------------- Reporter: dfeuer | Owner: dfeuer Type: task | Status: closed Priority: normal | Milestone: 7.10.1 Component: Core | Version: 7.9 Libraries | Keywords: Resolution: fixed | Architecture: Unknown/Multiple Operating System: | Difficulty: Easy (less than 1 Unknown/Multiple | hour) Type of failure: Runtime | Blocked By: performance bug | Related Tickets: Test Case: | Blocking: | Differential Revisions: Phab:D521 | -------------------------------------+------------------------------------- Changes (by dfeuer): * status: patch => closed * resolution: => fixed -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9827#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC