[GHC] #14022: base and ghc-prim should depend upon libm
#14022: base and ghc-prim should depend upon libm -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: 8.2.2 Component: Compiler | Version: 8.2.1 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- Both `base` and `ghc-prim` have references to symbols provided by `libm`. This dependency should be manifest in their respective cabal files. It seems that some `ld.gold` versions are strict about this. See https://github.com/NixOS/nixpkgs/pull/27584. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14022> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14022: base and ghc-prim should depend upon libm -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: patch Priority: normal | Milestone: 8.2.2 Component: Compiler | Version: 8.2.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3780 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => patch * differential: => Phab:D3780 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14022#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14022: base and ghc-prim should depend upon libm -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: patch Priority: normal | Milestone: 8.2.2 Component: Compiler | Version: 8.2.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3787 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * differential: Phab:D3780 => Phab:D3787 Comment: Actually, Phab:D3780 won't quite work; Phab:D3787 is a bit better. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14022#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14022: base and ghc-prim should depend upon libm -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: patch Priority: normal | Milestone: 8.2.2 Component: Compiler | Version: 8.2.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3787 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"0e3c10160472df082fd3decd98c2489a2f8e68bd/ghc" 0e3c1016/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="0e3c10160472df082fd3decd98c2489a2f8e68bd" Ensure that we always link against libm ld.gold is particularly picky that we declare all of our link dependencies on Nix. See #14022. Test Plan: Validate on Nix Reviewers: austin Subscribers: hvr, rwbarton, thomie GHC Trac Issues: #14022 Differential Revision: https://phabricator.haskell.org/D3787 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14022#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14022: base and ghc-prim should depend upon libm -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: merge Priority: normal | Milestone: 8.2.2 Component: Compiler | Version: 8.2.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3787 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: patch => merge -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14022#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14022: base and ghc-prim should depend upon libm -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: closed Priority: normal | Milestone: 8.2.2 Component: Compiler | Version: 8.2.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3787 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: merge => closed * resolution: => fixed Comment: It turns out that the other approach wasn't as simple as I was hoping it would be; keeping the approach in comment:3. Merged to `ghc-8.2` as 93a68595ea27e1c77df0c3092ab706ecd9695299. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14022#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC