#9261: -S prints incorrect number of bound tasks -------------------------------------+------------------------------------- Reporter: edsko | Owner: simonmar Type: bug | Status: new Priority: low | Milestone: Component: Runtime | Version: 7.8.2 System | Keywords: newcomer Resolution: | Architecture: Unknown/Multiple Operating System: | Difficulty: Easy (less than 1 Unknown/Multiple | hour) Type of failure: | Blocked By: None/Unknown | Related Tickets: Test Case: | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Changes (by thomie): * cc: simonmar (added) * component: Compiler => Runtime System * difficulty: Unknown => Easy (less than 1 hour) * keywords: => newcomer * owner: => simonmar Old description:

In `Stats.c` we have:

{{{ statsPrintf(" TASKS: %d (%d bound, %d peak workers (%d total), using -N%d)\n", taskCount, taskCount - workerCount, peakWorkerCount, workerCount, n_capabilities); }}}

but I think `taskCount - workerCount` must be wrong, because `taskCount` is the _current_ number of tasks, while `workerAcount` is the _total_ number of workers (accumulating). I think it should be:

{{{ statsPrintf(" TASKS: %d (%d bound, %d peak workers (%d total), using -N%d)\n", taskCount, taskCount - currentWorkerCount, peakWorkerCount, workerCount, n_capabilities); }}}

New description: In `rts/Stats.c` we have: {{{ statsPrintf(" TASKS: %d (%d bound, %d peak workers (%d total), using -N%d)\n", taskCount, taskCount - workerCount, peakWorkerCount, workerCount, n_capabilities); }}} but I think `taskCount - workerCount` must be wrong, because `taskCount` is the _current_ number of tasks, while `workerAcount` is the _total_ number of workers (accumulating). I think it should be: {{{ statsPrintf(" TASKS: %d (%d bound, %d peak workers (%d total), using -N%d)\n", taskCount, taskCount - currentWorkerCount, peakWorkerCount, workerCount, n_capabilities); }}} -- -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9261#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#9261: -S prints incorrect number of bound tasks -------------------------------------+------------------------------------- Reporter: edsko | Owner: thomie Type: bug | Status: patch Priority: low | Milestone: 7.12.1 Component: Runtime System | Version: 7.8.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: Phab:D746 -------------------------------------+------------------------------------- Changes (by thomie): * status: new => patch * differential: => Phab:D746 * milestone: => 7.12.1 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9261#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#9261: -S prints incorrect number of bound tasks -------------------------------------+------------------------------------- Reporter: edsko | Owner: thomie Type: bug | Status: patch Priority: low | Milestone: 7.12.1 Component: Runtime System | Version: 7.8.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: Phab:D746 -------------------------------------+------------------------------------- Comment (by thomie): Well, I've only studied the source code, I didn't actually run anything.. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9261#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#9261: -S prints incorrect number of bound tasks -------------------------------------+------------------------------------- Reporter: edsko | Owner: thomie Type: bug | Status: closed Priority: low | Milestone: 7.12.1 Component: Runtime System | Version: 7.8.2 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: #8124 | Blocking: | Differential Revisions: Phab:D746 -------------------------------------+------------------------------------- Changes (by thomie): * status: patch => closed * resolution: => fixed * related: => #8124 Comment: The code seems correct to me, so I'm closing this. But if you think you really do see weird numbers reported, of course reopen. Note that if your code doesn't explicitly call `hs_thread_done` (#8124), the number of bound tasks never decreases. So `taskCount` would be the sum of the total number of bound tasks and the total number of worker tasks ever created in that case. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9261#comment:7 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler