[GHC] #13937: @progbits is used incorrectly throughout GHC
#13937: @progbits is used incorrectly throughout GHC -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.0.1 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- GHC uses `.section $SECTION_NAME,$FLAGS,@progbits` directives throughout its produced assembler. However, some architectures (e.g. ARM) use `@` as a comment character and therefore must use some other prefix for section types. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13937> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13937: @progbits is used incorrectly throughout GHC -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: patch Priority: normal | Milestone: Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3712 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => patch * differential: => Phab:D3712 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13937#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13937: @progbits is used incorrectly throughout GHC -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: patch Priority: normal | Milestone: Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3712 Wiki Page: | -------------------------------------+------------------------------------- Comment (by bgamari): This is documented in the [[https://sourceware.org/binutils/docs/as/Section.html|GNU as documentation]]. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13937#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13937: @progbits is used incorrectly throughout GHC -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: patch Priority: normal | Milestone: Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3712 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"9b9f978fdcd13ff7b2a9b7391e02dff06da622a0/ghc" 9b9f978f/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="9b9f978fdcd13ff7b2a9b7391e02dff06da622a0" Use correct section types syntax for architecture Previously GHC would always assume that section types began with `@` while producing assembly, which is not true. For instance, in ARM assembly syntax section types begin with `%`. This abstracts out section type pretty- printing and adjusts it to correctly account for the target architectures assembly flavor. Reviewers: austin, hvr, Phyx Reviewed By: Phyx Subscribers: Phyx, rwbarton, thomie, erikd GHC Trac Issues: #13937 Differential Revision: https://phabricator.haskell.org/D3712 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13937#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13937: @progbits is used incorrectly throughout GHC -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: closed Priority: normal | Milestone: 8.2.1 Component: Compiler | Version: 8.0.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3712 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: patch => closed * resolution: => fixed * milestone: => 8.2.1 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13937#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC