[GHC] #14189: Renamer does not preserve location for IEThingWith list items
#14189: Renamer does not preserve location for IEThingWith list items -------------------------------------+------------------------------------- Reporter: alanz | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.2.1 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: Incorrect API Unknown/Multiple | annotation Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- In the `RenamedSource` for {{{#!hs module Renaming.RenameInExportedType ( MyType (NT) ) where data MyType = MT Int | NT }}} The `(NT)` is given the location of `MyType` earlier on the line in the export list. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14189> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14189: Renamer does not preserve location for IEThingWith list items -------------------------------------+------------------------------------- Reporter: alanz | Owner: alanz Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.2.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect API | Unknown/Multiple annotation | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by alanz): * owner: (none) => alanz -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14189#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14189: Renamer does not preserve location for IEThingWith list items -------------------------------------+------------------------------------- Reporter: alanz | Owner: alanz Type: bug | Status: new Priority: normal | Milestone: 8.2.2 Component: Compiler | Version: 8.2.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect API | Unknown/Multiple annotation | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by alanz): * milestone: => 8.2.2 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14189#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14189: Renamer does not preserve location for IEThingWith list items -------------------------------------+------------------------------------- Reporter: alanz | Owner: alanz Type: bug | Status: new Priority: normal | Milestone: 8.2.2 Component: Compiler | Version: 8.2.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect API | Unknown/Multiple annotation | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3968 Wiki Page: | -------------------------------------+------------------------------------- Changes (by alanz): * differential: => Phab:D3968 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14189#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14189: Renamer does not preserve location for IEThingWith list items -------------------------------------+------------------------------------- Reporter: alanz | Owner: alanz Type: bug | Status: new Priority: normal | Milestone: 8.2.2 Component: Compiler | Version: 8.2.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect API | Unknown/Multiple annotation | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3968 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"9498c50ef5af2680305e0aaea6f32439cacc3da0/ghc" 9498c50/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="9498c50ef5af2680305e0aaea6f32439cacc3da0" Renamer now preserves location for IEThingWith list items Prior to this, in the RenamedSource for module Renaming.RenameInExportedType ( MyType (NT) ) where data MyType = MT Int | NT The (NT) was given the location of MyType earlier on the line in the export list. Also the location was discarded for any field labels, and replaced with a `noLoc`. Test Plan: ./validate Reviewers: bgamari, austin Reviewed By: bgamari Subscribers: rwbarton, thomie GHC Trac Issues: #14189 Differential Revision: https://phabricator.haskell.org/D3968 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14189#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14189: Renamer does not preserve location for IEThingWith list items -------------------------------------+------------------------------------- Reporter: alanz | Owner: alanz Type: bug | Status: merge Priority: normal | Milestone: 8.2.2 Component: Compiler | Version: 8.2.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect API | Unknown/Multiple annotation | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3968 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => merge -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14189#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14189: Renamer does not preserve location for IEThingWith list items -------------------------------------+------------------------------------- Reporter: alanz | Owner: alanz Type: bug | Status: closed Priority: normal | Milestone: 8.2.2 Component: Compiler | Version: 8.2.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect API | Unknown/Multiple annotation | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3968 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: merge => closed * resolution: => fixed -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14189#comment:6> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14189: Renamer does not preserve location for IEThingWith list items -------------------------------------+------------------------------------- Reporter: alanz | Owner: alanz Type: bug | Status: closed Priority: normal | Milestone: 8.2.2 Component: Compiler | Version: 8.2.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect API | Unknown/Multiple annotation | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3968 Wiki Page: | -------------------------------------+------------------------------------- Comment (by bgamari): Merged to `ghc-8.2` as a153d2f26263181440156380559a90ab792d8260. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14189#comment:7> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC