[GHC] #13767: GHCi trips -DS checks at rts/sm/Sanity.c, line 210
#13767: GHCi trips -DS checks at rts/sm/Sanity.c, line 210 -------------------------------------+------------------------------------- Reporter: niteria | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: Runtime | Version: 8.3 System | Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- Error: {{{ $ echo -e ":quit\n" | ./inplace/bin/ghc-stage2 --interactive +RTS -DS -RTS -ignore-dot-ghci GHCi, version 8.3.20170515: http://www.haskell.org/ghc/ :? for help Prelude> Leaving GHCi. ghc-stage2: internal error: ASSERTION FAILED: file rts/sm/Sanity.c, line 210 (GHC version 8.3.20170515 for x86_64_unknown_linux) Please report this as a GHC bug: http://www.haskell.org/ghc/reportabug Aborted (core dumped) }}} Steps to reproduce: * Set `BuildFlavour = prof` in `mk/build.mk` * Add `GhcLibWays += p debug_p thr_debug_p` to `mk/build.mk`, I think you only need `thr_debug_p` * Build GHC * (cd ghc; make re2 GhcDebugged=YES), I think you can build it right away, but I'm not that familiar with the build system * `echo -e ":quit\n" | ./inplace/bin/ghc-stage2 --interactive +RTS -DS -RTS -ignore-dot-ghci` -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13767> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13767: GHCi trips -DS checks at rts/sm/Sanity.c, line 210 -------------------------------------+------------------------------------- Reporter: niteria | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: Runtime System | Version: 8.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Description changed by niteria: @@ -18,1 +18,1 @@ - * Add `GhcLibWays += p debug_p thr_debug_p` to `mk/build.mk`, I + * Add `GhcRTSWays += p debug_p thr_debug_p` to `mk/build.mk`, I New description: Error: {{{ $ echo -e ":quit\n" | ./inplace/bin/ghc-stage2 --interactive +RTS -DS -RTS -ignore-dot-ghci GHCi, version 8.3.20170515: http://www.haskell.org/ghc/ :? for help Prelude> Leaving GHCi. ghc-stage2: internal error: ASSERTION FAILED: file rts/sm/Sanity.c, line 210 (GHC version 8.3.20170515 for x86_64_unknown_linux) Please report this as a GHC bug: http://www.haskell.org/ghc/reportabug Aborted (core dumped) }}} Steps to reproduce: * Set `BuildFlavour = prof` in `mk/build.mk` * Add `GhcRTSWays += p debug_p thr_debug_p` to `mk/build.mk`, I think you only need `thr_debug_p` * Build GHC * (cd ghc; make re2 GhcDebugged=YES), I think you can build it right away, but I'm not that familiar with the build system * `echo -e ":quit\n" | ./inplace/bin/ghc-stage2 --interactive +RTS -DS -RTS -ignore-dot-ghci` -- -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13767#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13767: GHCi trips -DS checks at rts/sm/Sanity.c, line 210 -------------------------------------+------------------------------------- Reporter: niteria | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: Runtime System | Version: 8.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Description changed by niteria: @@ -18,5 +18,3 @@ - * Add `GhcRTSWays += p debug_p thr_debug_p` to `mk/build.mk`, I - think you only need `thr_debug_p` - * Build GHC - * (cd ghc; make re2 GhcDebugged=YES), I think you can build it right away, - but I'm not that familiar with the build system + * Add `GhcRTSWays += thr_debug_p` to `mk/build.mk` + * Build GHC with `./boot; ./configure; GhcDebugged=YES make` + * relink with `(cd ghc; make re2 GhcDebugged=YES)` New description: Error: {{{ $ echo -e ":quit\n" | ./inplace/bin/ghc-stage2 --interactive +RTS -DS -RTS -ignore-dot-ghci GHCi, version 8.3.20170515: http://www.haskell.org/ghc/ :? for help Prelude> Leaving GHCi. ghc-stage2: internal error: ASSERTION FAILED: file rts/sm/Sanity.c, line 210 (GHC version 8.3.20170515 for x86_64_unknown_linux) Please report this as a GHC bug: http://www.haskell.org/ghc/reportabug Aborted (core dumped) }}} Steps to reproduce: * Set `BuildFlavour = prof` in `mk/build.mk` * Add `GhcRTSWays += thr_debug_p` to `mk/build.mk` * Build GHC with `./boot; ./configure; GhcDebugged=YES make` * relink with `(cd ghc; make re2 GhcDebugged=YES)` * `echo -e ":quit\n" | ./inplace/bin/ghc-stage2 --interactive +RTS -DS -RTS -ignore-dot-ghci` -- -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13767#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13767: GHCi trips -DS checks at rts/sm/Sanity.c, line 210 -------------------------------------+------------------------------------- Reporter: niteria | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: Runtime System | Version: 8.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by niteria): This reproduces on https://phabricator.haskell.org/rGHC4d683fa11a5140b74f588b93f93f7891f79ac891 as well. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13767#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13767: GHCi trips -DS checks at rts/sm/Sanity.c, line 210 -------------------------------------+------------------------------------- Reporter: niteria | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: Runtime System | Version: 8.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by niteria): https://phabricator.haskell.org/rGHC4848ab9ce3c4491935888d405412d451294b74ee works 1k commits to bisect. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13767#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13767: GHCi trips -DS checks at rts/sm/Sanity.c, line 210 -------------------------------------+------------------------------------- Reporter: niteria | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: Runtime System | Version: 8.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by niteria): * cc: simonmar (added) Comment: I bisected it to https://phabricator.haskell.org/rGHC394231b301efb6b56654b0a480ab794fe3b7e4db, I guess that makes sense given what it does. cc @simonmar -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13767#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13767: GHCi trips -DS checks at rts/sm/Sanity.c, line 210 -------------------------------------+------------------------------------- Reporter: niteria | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: Runtime System | Version: 8.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3680 Wiki Page: | -------------------------------------+------------------------------------- Changes (by simonmar): * differential: => Phab:D3680 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13767#comment:6> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13767: GHCi trips -DS checks at rts/sm/Sanity.c, line 210 -------------------------------------+------------------------------------- Reporter: niteria | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: Runtime System | Version: 8.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3680 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"f9c6d53fe997f1c560cda6f346f4b201711df37c/ghc" f9c6d53/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="f9c6d53fe997f1c560cda6f346f4b201711df37c" Tag the FUN before making a PAP (#13767) Pointers to FUNs are not guaranteed to be tagged in general, because the compiler doesn't always know the arity of a FUN when it needs to reference it, e.g. with -O0 when the function is in another module. However, there's one case where we can put the correct tag on a FUN: when it is referenced by a PAP, because when building the PAP we know the arity and we can tag the pointer correctly. The AutoApply code does this, and the sanity checker checks it, but the interpreter did not respect this invariant. This patch fixes it. Test Plan: ``` (cd ghc && make 2 GhcDebugged=YES) ./inplace/bin/ghc-stage2 --interpreter +RTS -DS ``` Reviewers: niteria, bgamari, austin, erikd Reviewed By: bgamari Subscribers: rwbarton, thomie GHC Trac Issues: #13767 Differential Revision: https://phabricator.haskell.org/D3680 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13767#comment:7> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13767: GHCi trips -DS checks at rts/sm/Sanity.c, line 210 -------------------------------------+------------------------------------- Reporter: niteria | Owner: (none) Type: bug | Status: closed Priority: normal | Milestone: 8.4.1 Component: Runtime System | Version: 8.3 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3680 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => closed * resolution: => fixed * milestone: => 8.4.1 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13767#comment:8> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13767: GHCi trips -DS checks at rts/sm/Sanity.c, line 210 -------------------------------------+------------------------------------- Reporter: niteria | Owner: (none) Type: bug | Status: closed Priority: normal | Milestone: 8.4.1 Component: Runtime System | Version: 8.3 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3680 Wiki Page: | -------------------------------------+------------------------------------- Comment (by dfeuer): In the unlikely event that we decide to merge this to 8.2 for any reason, we must also merge 60a3f11ff4b7e239a273498812fd9d31f6775726 to fix #14036. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13767#comment:9> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC